azuredatastudio icon indicating copy to clipboard operation
azuredatastudio copied to clipboard

A11y_Azure Data Studio extension 'Azure SQL Migration'_View/Select_Object Information: Issues displayed in assessments results dialog are defined as table instead of list items

Open NiharikaTipirishetty opened this issue 2 years ago • 2 comments

"Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

Github Tags:

#A11yMAS; #A11yTCS; #A11ySev2; #Benchmark; #SH-AzureSQLMigration-Win32-Jun2022; #DesktopApp; #Win32; #SQL Migration Control Plane; #WCAG4.2.1; #Object Information;

Environment and OS details:

Azure Data Studio Version 1.37.0(User Setup) Windows Version 21H2 (OS Build 22000.675)

Repro Steps:

  1. Turn on Narrator/NVDA
  2. Install Azure data studio app and install Azure SQL migration extension
  3. Connect to SQL server, tab till respective server, right click and select manage
  4. Tab till Azure SQL Migration in sitemap and press enter key
  5. Tab till migrate to azure sql and press enter
  6. Navigate to databases grid in "Databases for assessment", select few databases and click next.
  7. In Assessment results and recommendations step, select a azure sql target and navigate to "View/select" button and press enter
  8. After selecting a database in "Assessment results" dialog, issues will be displayed.
  9. Verify that issues displayed in assessments results dialog are defined as table

Actual Result:

Issues displayed in assessments results dialog are defined as table instead of list items

Expected Result:

Issues displayed in assessments results dialog should be defined as list items instead of giving a empty column headers and empty column 1.

Attachment:

table_

NiharikaTipirishetty avatar Jun 29 '22 10:06 NiharikaTipirishetty

@brian-harris, can you please change it to a list component? Example: https://github.com/microsoft/azuredatastudio/blob/4096037167a7fea5ab3c4efcd6a041dfcfa687d4/extensions/resource-deployment/src/ui/resourceTypePickerDialog.ts#L136

It looks like this image

aasimkhan30 avatar Aug 03 '22 22:08 aasimkhan30

@aasimkhan30 please re-assign yourself. The table component was used because we have icons for blocking scenarios and list view doesn't have support.

we also discussed creating a single column table with flex container in each cell to add the icons, but we agreed that adding icons to list view will be the better solution going forward. @aasimkhan30 to add support for this

AkshayMata avatar Aug 08 '22 22:08 AkshayMata

#Closed; Verified the issue in below Environment: Issue is Fixed Version: 1.41.1 (user setup) Screenshot (29)

VijayaBharathyA avatar Feb 10 '23 09:02 VijayaBharathyA