azuredatastudio icon indicating copy to clipboard operation
azuredatastudio copied to clipboard

Added option for separate tab

Open smartguest opened this issue 2 years ago • 3 comments

This PR adds in the requested separate tab feature similar to that of SSMS

This requires moving the functionality of the queryResultsEditor and the queryResultsView into the queryEditor itself to facilitate the layout generation more easily.

Due to the nature of how editors are created in ADS along with the layout function call, its currently only possible to change the editor layout after a restart of ADS (noted on the setting).

This PR also adds the setting to automatically switch to the results tab after a query has been run (similar to SSMS) and this does not require a restart.

Screenshots posted below: Default view (no query plan): QueryDefaultScreen1

Default view (with query plan): QueryDefaultScreen2

Separate tab view (no query plan): QueryNewTabScreen1

Separate tab view (with query plan): QueryNewTabScreen2

Settings page: QuerySettingsScreen

This fixes: #4784

smartguest avatar Jun 06 '22 17:06 smartguest

@smartguest did you mean to put this in draft mode?

alanrenmsft avatar Jun 06 '22 18:06 alanrenmsft

@alanrenmsft Perhaps I should, although functionally it is complete.

smartguest avatar Jun 06 '22 18:06 smartguest

I need to fix the failing tests first before turning this into an actual PR

smartguest avatar Jun 06 '22 19:06 smartguest

@smartguest should we close out this older PR since I think it will still need a bit of work to get merged? We can reopen later if we pick this back up.

kburtram avatar Jan 13 '23 21:01 kburtram

Closing older PR without recent activity. Please reopen if working on this area again.

kburtram avatar Jan 18 '23 20:01 kburtram