azure-maven-plugins icon indicating copy to clipboard operation
azure-maven-plugins copied to clipboard

[Functions] Add all the supported commands to CI

Open pragnagopa opened this issue 6 years ago • 6 comments

CI added https://github.com/Microsoft/azure-maven-plugins/pull/425 is testing the archetype

mvn archetype:generate -DarchetypeCatalog="local" -DarchetypeGroupId="com.microsoft.azure" -DarchetypeArtifactId="azure-functions-archetype" -DarchetypeVersion="$atchetypeVersion" -DgroupId="com.microsoft" -DartifactId="e2etestproject" -Dversion="1.0-SNAPSHOT" -Dpackage="com.microsoft" -DappRegion="westus" -DresourceGroup="e2etest-java-functions-group" -DappName="e2etest-java-functions" -B

This needs to be moved to archetype repo CI. CI for the plugin should do something similar,

<azure.functions.maven.plugin.version>**version built by the CI**</azure.functions.maven.plugin.version>

Tests should include all the supported commands. Please open separate issues if this is a larger workitem

pragnagopa avatar Oct 19 '18 19:10 pragnagopa

cc: @jdneo , @Flanker32

pragnagopa avatar Oct 19 '18 19:10 pragnagopa

@pragnagopa @jdneo How about update the version of function maven plugin in develop branch of archetype and then CI test will covers the latest archetype as well as maven plugin, it will generate function project by archetype and package it through function plugin, so i think one CI test in plugin repo is enough.

Flanker32 avatar Oct 21 '18 14:10 Flanker32

After archetype generated function project, basic verification if the the project generated builds or not should be done in the archetype repo

pragnagopa avatar Oct 22 '18 20:10 pragnagopa

@pragnagopa

CI added #425 is testing the archetype

mvn archetype:generate -DarchetypeCatalog="local" -DarchetypeGroupId="com.microsoft.azure" -DarchetypeArtifactId="azure-functions-archetype" -DarchetypeVersion="$atchetypeVersion" -DgroupId="com.microsoft" -DartifactId="e2etestproject" -Dversion="1.0-SNAPSHOT" -Dpackage="com.microsoft" -DappRegion="westus" -DresourceGroup="e2etest-java-functions-group" -DappName="e2etest-java-functions" -B

This needs to be moved to archetype repo CI. CI for the plugin should do something similar,

<azure.functions.maven.plugin.version>**version built by the CI**</azure.functions.maven.plugin.version>

For this issue, i prefer to clone both the archetype and maven plugin repo in CI script, maven build and intall, then build a function project with archetype built above, and change the version of function plugin by powershell , build and verify the project. It will cover archetype as well as plugin. If we split the CI into two part and we will still need to build a project by archetype in CI of function plugin and i think it could be puzzle.

Tests should include all the supported commands. Please open separate issues if this is a larger workitem

Do you means we should test package,add,run,deploy or we should test all function templates? If is the first one, we will add script to verify add and run (package has been done in script), if you want to test all the function templates, the workitem is a bit large and we will do it after we completed ci cases here https://github.com/Microsoft/azure-maven-plugins/issues/261

Flanker32 avatar Oct 25 '18 06:10 Flanker32

/cc @selvasingh

asavaritayal avatar Jan 18 '19 19:01 asavaritayal

@Flanker32 - Is this duplicate of https://github.com/microsoft/azure-maven-plugins/issues/261?

kulkarnisonia16 avatar Aug 15 '19 04:08 kulkarnisonia16