autogen icon indicating copy to clipboard operation
autogen copied to clipboard

Notebook on web crawling

Open WilliamEspegren opened this issue 1 year ago • 12 comments

Why are these changes needed?

Lacking web crawling examples in both notebooks and the docs/Example.md

Checks

Not any applicable right?

  • [ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
  • [ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
  • [ ] I've made sure all auto checks have passed.

I referred to a previous pull request for inspiration while creating this notebook example for Spider. This PR provided a helpful reference for structure and content, which I have adapted to fit the specific requirements of Spider.

Twitter handle: @WilliamEspegren

WilliamEspegren avatar May 19 '24 17:05 WilliamEspegren

@microsoft-github-policy-service agree

WilliamEspegren avatar May 19 '24 20:05 WilliamEspegren

Thanks. Would you like the notebook to be rendered on the website? If so, https://github.com/microsoft/autogen/blob/main/notebook/contributing.md#how-to-get-a-notebook-displayed-on-the-website is the guide.

sonichi avatar May 21 '24 13:05 sonichi

Thanks. Would you like the notebook to be rendered on the website? If so, https://github.com/microsoft/autogen/blob/main/notebook/contributing.md#how-to-get-a-notebook-displayed-on-the-website is the guide.

Yes please! I will look into this

WilliamEspegren avatar May 21 '24 18:05 WilliamEspegren

@sonichi This notebook will be rendered on the website right?

WilliamEspegren avatar May 22 '24 07:05 WilliamEspegren

@sonichi This notebook will be rendered on the website right?

Some metadata needs to be added for it to render. It's OK to do it in a separate PR if you like.

sonichi avatar May 25 '24 00:05 sonichi

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10493810 Triggered Generic Password 49e8053dd1e5456d3758b4a85f5721e9c9b12e16 notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
10493810 Triggered Generic Password 501610b4fc0c649fa2b1cbf0fd72fa6f14f026d0 notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
10493810 Triggered Generic Password 49e8053dd1e5456d3758b4a85f5721e9c9b12e16 notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
10493810 Triggered Generic Password 501610b4fc0c649fa2b1cbf0fd72fa6f14f026d0 notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
10493810 Triggered Generic Password 49e8053dd1e5456d3758b4a85f5721e9c9b12e16 notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
10493810 Triggered Generic Password 501610b4fc0c649fa2b1cbf0fd72fa6f14f026d0 notebook/agentchat_pgvector_RetrieveChat.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar May 25 '24 00:05 gitguardian[bot]

@sonichi Sorry for that, now it is formatted correctly and passes the checks

image

WilliamEspegren avatar May 26 '24 16:05 WilliamEspegren

@sonichi Sorry for that, now it is formatted correctly and passes the checks

image

Ready to merge :)

WilliamEspegren avatar Jun 19 '24 06:06 WilliamEspegren

@sonichi Ready to merge :)

WilliamEspegren avatar Jun 24 '24 08:06 WilliamEspegren

@sonichi Still ready to merge :100:

WilliamEspegren avatar Jun 29 '24 20:06 WilliamEspegren

@sonichi Should I change this PR in any way?

WilliamEspegren avatar Jul 21 '24 09:07 WilliamEspegren

thank you @ekzhu for the review, ready to merge now :)

WilliamEspegren avatar Oct 04 '24 11:10 WilliamEspegren

@ekzhu - looks like OP updated this one - can you check out the docs file conflict?

rysweet avatar Oct 11 '24 21:10 rysweet

@ekzhu - looks like OP updated this one - can you check out the docs file conflict?

Left a comment on an unaddressed point

ekzhu avatar Oct 11 '24 22:10 ekzhu

@ekzhu sorry, fixed now :)

WilliamEspegren avatar Oct 11 '24 23:10 WilliamEspegren