autogen icon indicating copy to clipboard operation
autogen copied to clipboard

Fix for runtime logging not supported with GPTAssistantAgent

Open pk673 opened this issue 1 year ago • 10 comments

Please review @IANTHEREAL @cheng-tan @jtrugman @ekzhu

Why are these changes needed?

With this change we aim to support runtime-logging with GPTAssistantAgent

Related issue number

Closes #2498 #2644

Checks

  • [ X] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
  • [ X] I've added tests (if relevant) corresponding to the changes introduced in this PR.
  • [ X] I've made sure all auto checks have passed.

pk673 avatar May 11 '24 04:05 pk673

@pk673 good that you started this. Can you work together with @krishnashed on this PR? I think he can submit a PR to your branch on your repo.

ekzhu avatar May 11 '24 05:05 ekzhu

@Hk669 there is still some work left. I'll request for changes when needed

krishnashed avatar May 11 '24 19:05 krishnashed

@Hk669 there is still some work left. I'll request for changes when needed

yeah sure. Thanks

Hk669 avatar May 11 '24 19:05 Hk669

@krishnashed Could you please elaborate on the changes that are still pending?

pk673 avatar May 11 '24 19:05 pk673

@pk673 can we connect? What's your discord username?

krishnashed avatar May 11 '24 19:05 krishnashed

@pk673 can we connect? What's your discord username?

@krishnashed can you add me to the discussion? Thanks

Hk669 avatar May 11 '24 19:05 Hk669

@krishnashed @Hk669 My discord username is priyam_20775

pk673 avatar May 11 '24 19:05 pk673

@Hk669 Can you please let me know what changes are required?

pk673 avatar May 11 '24 20:05 pk673

Can you also add me to the discord chat?

ekzhu avatar May 11 '24 22:05 ekzhu

@krishnashed i think this is only logging the last response of the group chat in chat completion log. is this issue solved? @pk673 please look into the above issue

issue addressed in #2677

Hk669 avatar May 16 '24 05:05 Hk669

@pk673 thanks for the contribution.

Hk669 avatar May 21 '24 17:05 Hk669