autogen icon indicating copy to clipboard operation
autogen copied to clipboard

AgentEval Offline Integration

Open jluey1 opened this issue 1 year ago β€’ 4 comments

Why are these changes needed?

Related issue number

See issue #2162

Checks

  • [x] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
  • [ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
  • [ ] I've made sure all auto checks have passed.

jluey1 avatar Apr 10 '24 17:04 jluey1

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

πŸ”Ž Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10404662 Triggered Generic CLI Secret 9a6ecfa2d0d2bb8189be8887ef29a71010f6dbfb .github/workflows/dotnet-release.yml View secret
10404662 Triggered Generic CLI Secret 0e26a9ebd2b42dd4fbda5c279bad7726a7adc141 .github/workflows/dotnet-release.yml View secret
10404662 Triggered Generic CLI Secret 5a3969a855e006a36f0bfd96686d747f724fb7e5 .github/workflows/dotnet-release.yml View secret
10404662 Triggered Generic CLI Secret 7e64a96e131f34a3f2556bc4f2d52164627ca3f5 .github/workflows/dotnet-release.yml View secret
πŸ›  Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


πŸ¦‰ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Apr 20 '24 01:04 gitguardian[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.31%. Comparing base (ded2d61) to head (5a3969a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2345      +/-   ##
==========================================
- Coverage   33.33%   33.31%   -0.03%     
==========================================
  Files          83       83              
  Lines        8636     8636              
  Branches     1835     1835              
==========================================
- Hits         2879     2877       -2     
- Misses       5516     5517       +1     
- Partials      241      242       +1     
Flag Coverage Ξ”
unittests 33.31% <ΓΈ> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 20 '24 01:04 codecov-commenter

Could you add a test to cover the newly added code? Depending on whether the test requires openai, you can add it to contrib-tests.yml or contrib-openai.yml. It takes some learning to understand how to write the tests. Please check other contrib tests and how they are added to these workflows.

sonichi avatar Apr 29 '24 16:04 sonichi

Apr 29, 2024

@sonichi , I can add a couple tests verifying that the criteria generation and quantifier give back a meaningful result, but I'm not sure what other scenarios would be good to test

jluey1 avatar Apr 30 '24 17:04 jluey1

Closing in order to make a new PR from agenteval_integration into main

jluey1 avatar May 13 '24 17:05 jluey1