appcenter-sdk-apple
appcenter-sdk-apple copied to clipboard
Fix SwiftUI Previews in Xcode 14
SwiftUI Previews in Xcode 14 failing to run when adding AppCenter through SPM
Things to consider before you submit the PR:
- ~[ ] Has
CHANGELOG.md
been updated?~ - ~[ ] Are tests passing locally?~
- [x] Are the files formatted correctly?
- ~[ ] Did you add unit tests?~
- ~[ ] Did you check UI tests on the sample app? They are not executed on CI.~
- [x] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?
Description
This PR fixing SwiftUI Previews in Xcode 14 that failed to run when adding AppCenter through SPM.
Codecov Report
Merging #2433 (2eb6ce2) into develop (07b065f) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #2433 +/- ##
========================================
Coverage 90.71% 90.71%
========================================
Files 125 125
Lines 8774 8774
========================================
Hits 7959 7959
Misses 815 815
Flag | Coverage Δ | |
---|---|---|
MacCatalyst | 90.63% <ø> (ø) |
|
iOS | 90.93% <ø> (ø) |
|
macOS | 90.22% <ø> (ø) |
|
tvOS | 90.47% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
eagerly awaiting this fix.
My team is also eagerly awaiting this fix 😁
any updates on this?
My team just switched to using this branch and our previews work like a charm now 😁
Any updates on this?
@microsoft/appcenter-fte Merge/approve?
Would be great to add this to MSAL login repo as well
https://github.com/AzureAD/microsoft-authentication-library-for-objc/issues/1565
Hi folks, we are having some issues on our CI at this moment. Will merge this PR as soon as possible.
@DmitriyKirakosyan Any update?
I think it works fine in Xcode 14.1 beta. It's kind of a work around but it helps in the time being
@DmitriyKirakosyan , please don't force push into this PR's branch when it can be avoid.. Some people may already use it in SPM to work around the Xcode 14 SwiftUI preview issue. ForcePush'ing will break their SPM setup and they'll have to manually fix up their Packages.resolved file(s).
Hi @geertbleyen , sorry for that. I rebased to make it mergable and keep the history clean. So now the branch is removed anyway. Using swift package from a PR's branch is not a good idea as the branch may be rebased and removed. For stability I would create a fork with that change. Now anyone using this commit can use develop while the fix is not merged to master.
Hey. When will this bugfix be released?
Hi @fnazarios, we are currently working on the release, so I expect it to be published within two weeks.