agent-lightning icon indicating copy to clipboard operation
agent-lightning copied to clipboard

Hitting KeyboardInterrupt produces too many error logs

Open ultmaster opened this issue 1 month ago • 3 comments

When hitting keyboard interrupt (via Ctrl+C for example), there is a lot of tracebacks on the console (particularly when there are a lot of runners). Something like asyncio.CancelledError...

To reproduce, run this file: https://github.com/microsoft/agent-lightning/blob/main/tests/benchmark/benchmark_store.py

I think this part can be greatly simplified and only show the important messages so that the real errors won't be flushed by the tons of logs.

ultmaster avatar Nov 29 '25 14:11 ultmaster

Hi! @ultmaster I'd like to work on this issue. When Ctrl+C is pressed with many runners (e.g., 32), the console floods with asyncio.CancelledError tracebacks, making it hard to see real errors. The fix would suppress CancelledError tracebacks during graceful shutdown while preserving normal error reporting. I can start on this if that works. Should I proceed?

Vasuk12 avatar Dec 02 '25 02:12 Vasuk12

Thanks for reaching out! We might already have people working on this. Please hold on for a day or two to see whether they have worked out.

ultmaster avatar Dec 02 '25 03:12 ultmaster

Thanks for reaching out! We might already have people working on this. Please hold on for a day or two to see whether they have worked out.

Sure no issues! Let me know whatever happens :).

Vasuk12 avatar Dec 02 '25 03:12 Vasuk12