agent-lightning icon indicating copy to clipboard operation
agent-lightning copied to clipboard

[DEBUG]: Remove two unnecessary condition

Open JasonHonKL opened this issue 1 month ago • 7 comments

#329 As mentioned in this issue ticket, the UV restriction is currently too strong. Therefore, please remove these two conditions.

JasonHonKL avatar Nov 22 '25 16:11 JasonHonKL

@ultmaster PTAL thanks

JasonHonKL avatar Nov 22 '25 16:11 JasonHonKL

In my case, This helped.

curl -LsSf https://astral.sh/uv/install.sh | sh
export PATH="$HOME/.local/bin:$PATH"

genji970 avatar Nov 22 '25 17:11 genji970

@genji970 i think the issue is "sys_platform == 'linux'" line

JasonHonKL avatar Nov 22 '25 18:11 JasonHonKL

@genji970 i think the issue is "sys_platform == 'linux'" line

Yes. Just for the first condition, it worked in my case. So just mentioned.

genji970 avatar Nov 22 '25 18:11 genji970

I think the project is claimed to support linux only: https://microsoft.github.io/agent-lightning/stable/tutorials/installation/

I'm not sure whether mac works and it needs more test; but I'm sure that supporting mac will greatly increase the size of uv.lock. Some platform-dependent packages like flash-attn and pytorch might fail to lock or install.

I would recommend using pip install directly on mac if you insist to using it on Mac; and refrain from using uv.

You can try to rerun uv.lock to see whether it will be a disaster.

ultmaster avatar Nov 23 '25 08:11 ultmaster

I see. However, from my personal understanding, there won’t be a huge difference between Mac and Linux systems, and the UV lock isn’t important as long as the TOML file is the same. I guess this can actually be verified by the UV documentation?

JasonHonKL avatar Nov 23 '25 08:11 JasonHonKL

We need to commit uv.lock file so that we can have stable dependencies on CI.

Also is there a specific reason why you would need a legacy uv version?

I think you are not in a position of needing uv if you don't use uv.lock.

ultmaster avatar Nov 23 '25 09:11 ultmaster