accessibility-insights-web icon indicating copy to clipboard operation
accessibility-insights-web copied to clipboard

ESLint V9 migration

Open v-singhanjal opened this issue 11 months ago • 0 comments

Details

Migrated ESLint version from 8.57.0 to 9.24.9

Motivation

Migrate ESLint to V9

Context

CI failure is unrelated, see #7323.

  1. Removed "// eslint-disable-next-line no-useless-escape" from multiple files as they are unused now
  2. eslint.config.mjs - Added eslint.config.mjs file. It replaces root, base, and e2e .eslintrc.js files.
  3. package.json - Upgraded eslint from 8.57.0 to 9.24.0
  4. packages/report-e2e-tests/tsconfig.json - Updated to include jest.config.js and prettier.config.js.
  5. Updated snapshot files- settings-drop-down & hamburger-menu tests
  6. tsconfig.json - Updated to include JS config files.
  7. linked-frame-messenger.ts - Updated mock window object.
  8. frame-url-finder.test.ts - Changed direct assignment of window.location.

Pull request checklist

  • [ ] Ran yarn fastpass
  • [ ] Added/updated relevant unit test(s) (and ran yarn test)
  • [ ] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • [ ] PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [ ] (UI changes only) Added screenshots/GIFs to description above
  • [ ] (UI changes only) Verified usability with NVDA/JAWS

v-singhanjal avatar Apr 30 '25 09:04 v-singhanjal