accessibility-insights-web icon indicating copy to clipboard operation
accessibility-insights-web copied to clipboard

feat(target-size-automation): adding target size to the needs-review rules

Open JGibson2019 opened this issue 1 year ago • 1 comments
trafficstars

Details

Adding target-size to the needs review rules. This is the pre-PR for Madalyn's PR that enables target-size in assessment and provides the initial visualization and support for the test step

Motivation
Context

The enablement of target-size for general assessment

Pull request checklist

  • [ ] Addresses an existing issue: #0000
  • [X] Ran yarn fastpass
  • [X] Added/updated relevant unit test(s) (and ran yarn test)
  • [X] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • [X] PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [ ] (UI changes only) Added screenshots/GIFs to description above
  • [ ] (UI changes only) Verified usability with NVDA/JAWS

JGibson2019 avatar May 09 '24 19:05 JGibson2019

will update with final wording for the needs review cards and the update the final e2e test. do not review or merge until those are added

JGibson2019 avatar May 10 '24 13:05 JGibson2019