accessibility-insights-web
accessibility-insights-web copied to clipboard
microsoft
User is not told if AI-Web skips unresponsive iframe
Describe the bug
Our extension makes a best-effort attempt to scan child iframes - we send messages to the child frame and wait for a small timeout. If the child frame does not respond by our timeout, we skip the child iframe.
The user should be notified when we skip an iframe. axe-core exposes a rule frame-tested that we can use to detect when an iframe was skipped.
To Reproduce Steps to reproduce the behavior:
- Go to this demo page
- Select either checkbox so that child window message events are disrupted
- Try scanning the page and granting iframe permissions if needed
- Notice that no issues are found in the child iframe (even though the empty input is unnamed)
- Notice there is no indication to the user that the frame was skipped
Expected behavior
axe-core has a rule called frame-tested that we can enable in our scans. By default, results will show up in "needs review" and we can add content to flesh it out.
If we prefer to surface the results elsewhere (a dialog box, a notice banner, etc) that works too.
Context (please complete the following information)
- AI-Web Version & Environment: Version 2.35.0
- Target Page: https://karanbirsingh.github.io/temp-snippets/microsoft/accessibility-insights-web/message-capturing-iframes/same-origin.html
This is a demo target page. We have seen websites in our support channel exhibiting this behavior.
This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!
@ferBonnin By default, this rule would have shown up in needs review. With the banner, would we like to omit frame-tested from needs-review, or is the banner in addition?
Should the banner follow similar design & behavior as the existing banners (screenshot below)?
The existing banners have a call to action for the user. In this case, the user probably can't do much because we aren't giving them any configuration options. They should probably file an issue on our GitHub. Maybe there's a default issue template link we can populate for them and suggest in the banner link?
@karanbirsingh since we cannot assume the user will step into needs review, we would like to omit the rule and instead add the banner. Yes, the banner should follow similar design & behaviour as the existing banners.
