accessibility-insights-web icon indicating copy to clipboard operation
accessibility-insights-web copied to clipboard

Bug: Color samples in issues dialog are overridden in HC modes

Open DaveTryon opened this issue 2 years ago • 1 comments

Describe the bug

Not sure if this is intentional, but filing for completeness. For a color contrast issue, we display colors both as a numeric value and as a color sample. Here's a screenshot of what I mean--notice that the displayed colors and the textual colors stay in sync:

image

Here's the same dialog, using WIn 10's High Contrast Black theme--the textual colors are unchanged from before, but the color samples have been forced to the HC themes. As a result, the textual description and the color sample are now out of sync with each other:

image

To Reproduce Steps to reproduce the behavior:

  1. Go to any page with a contrast issue
  2. Run automated checks
  3. Open the issues dialog for one of the contrast issues
  4. Switch between HC and non-HC modes. The text remains unchanged, but the color samples change

CodePen repro example

Expected behavior

I would expect the color samples to match the textual colors. If we can't do that, perhaps we should remove the color samples in Windows HC modes.

Screenshots

Context (please complete the following information)

  • OS Name & Version: Win 10 21H2
  • AI-Web Version & Environment: 2.34.1 Insider
  • Browser Version: Edge 105.0.1343.27

Are you willing to submit a PR?

Did you search for similar existing issues?

Additional context

DaveTryon avatar Sep 07 '22 17:09 DaveTryon

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

ghost avatar Sep 07 '22 17:09 ghost

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

ghost avatar Nov 01 '22 16:11 ghost

This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for contributing to Accessibility Insights!

ghost avatar Nov 05 '22 18:11 ghost

Confirmed fixed in Canary (2022.11.3.2033)

DaveTryon avatar Nov 08 '22 03:11 DaveTryon