accessibility-insights-web icon indicating copy to clipboard operation
accessibility-insights-web copied to clipboard

Allow disabling notifications

Open traisjames opened this issue 3 years ago • 6 comments

Simple thing. I just want to be able to turn off notifications when I am doing a check. I know I am doing checks and am watching for results. I don't need to be told when they are found.

traisjames avatar Aug 13 '22 03:08 traisjames

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

ghost avatar Aug 15 '22 13:08 ghost

Thanks for the feature request @traisjames! Could you please let us know which OS and browser you are using?

We triaged this with the team and we will be investigating:

  • Is there a way to turn off notifications for a single extension via OS or browser?
  • Are there other things where we rely on the OS notifications to notify users? Leaving this as ready for triage to continue the conversation next week

ferBonnin avatar Aug 15 '22 21:08 ferBonnin

Google Chrome Version 104.0.5112.79 running on OS X 10.15.7

On Aug 15, 2022, at 4:33 PM, ferBonnin @.***> wrote:

Thanks for the feature request @traisjames https://github.com/traisjames! Could you please let us know which OS and browser you are using?

We triaged this with the team and we will be investigating:

Is there a way to turn off notifications for a single extension via OS or browser? Are there other things where we rely on the OS notifications to notify users? Leaving this as ready for triage to continue the conversation next week — Reply to this email directly, view it on GitHub https://github.com/microsoft/accessibility-insights-web/issues/5917#issuecomment-1215872473, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFXM43YHMDZOVNSKCCMWRTVZKZRVANCNFSM56NMMT6Q. You are receiving this because you were mentioned.

traisjames avatar Aug 17 '22 21:08 traisjames

@ferBonnin After investigating, Chrome doesn't seem to have a way to block notifications for an extension, and the functionality for blocking notifications from a site doesn't work with extension URLs.

The places where we use notifications are:

  • After running an Automated Checks or Needs Review scan (from fastpass or ad hoc visualizers)
  • Whenever the tab stops visualizer is enabled
  • When enabling any visualizer with a keyboard shortcut
  • When trying to enable a visualizer via keyboard shortcut on a URL that is not scannable (either if it's a file URL and the extension hasn't been granted permissions, or if the extension doesn't have access for some other reason)

All of these cases go through NotificationCreator, so adding a global switch wouldn't be complicated, but I'm not sure we'd want to disable all of those cases (particularly the unscannable URL messages, since we otherwise don't communicate why the scan didn't run)

pownkel avatar Aug 26 '22 23:08 pownkel

What about doing switches for each reason, because if its something automated yea an alert is nice, but if I manually run a check and am sitting on the page I am checking, I am ok without the notification.

traisjames avatar Aug 27 '22 20:08 traisjames

thanks for the investigation @pownkel! We are marking this as await community interest to correctly prioritize

ferBonnin avatar Aug 29 '22 21:08 ferBonnin

@ferBonnin FYI, we received a customer request in the "Support" section of our Chrome Web Store listing yesterday which is a +1 for this feature:

Allow turning off notifications

This extension has too many notifications. Please let us toggle it off.

dbjorge avatar Nov 09 '22 21:11 dbjorge

Unfortunately, this is out of scope given our current priorities.

Thanks for using Accessibility Insights!

DaveTryon avatar Jul 28 '23 20:07 DaveTryon