accessibility-insights-web icon indicating copy to clipboard operation
accessibility-insights-web copied to clipboard

feat(mv3-part6): Opt into async handler for stores with async work

Open sfoslund opened this issue 3 years ago • 0 comments

Details

Follow up to https://github.com/microsoft/accessibility-insights-web/pull/5877, which allowed us to opt stores into supporting async handlers. These changes to not touch any stores that do not have async work, since by default stores support sync handlers. The stores changed in this file correspond to actions that were converted to async in previous PRs.

Motivation

Feature work.

Context

These changes ensure that any async work in action handlers is properly awaited, which will protect from the manifest v3 service worker timing out when async work is still happening.

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • [x] Ran yarn fastpass
  • [x] Added/updated relevant unit test(s) (and ran yarn test)
  • [x] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • [x] PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

sfoslund avatar Aug 09 '22 19:08 sfoslund