accessibility-insights-web icon indicating copy to clipboard operation
accessibility-insights-web copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Visualizations fail for targets with semicolon character

Open sfoslund opened this issue 3 years ago • 1 comments
trafficstars

Describe the bug

Automated checks visualizations fail on web pages that include the character ;.

To Reproduce Steps to reproduce the behavior:

  1. Go to code pen: https://codepen.io/dbjorge/pen/OJvXaVg
  2. Run fast pass automated checks
  3. See message unable to find frame to highlight button[data-attr="with in target page and no visualization.

Expected behavior

Visualization should be shown on pages with ; character in targets.

Context (please complete the following information)

  • OS Name & Version: Windows 11
  • AI-Web Version & Environment: 2.32.0 prod
  • Browser Version: Chrome 103.0.5060.114
  • Target Page: https://codepen.io/dbjorge/pen/OJvXaVg

Are you willing to submit a PR?

Yes

Did you search for similar existing issues?

Yes

sfoslund avatar Jul 12 '22 15:07 sfoslund

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

ghost avatar Jul 13 '22 20:07 ghost

I can't see the error message, however, the button in the codepen is not failing the Button-name rule also, changing the attr of the button to something without a semicolon makes it such that the frame-title rule fails whether as with the semicolon, no failures are found.

ferBonnin avatar Sep 21 '22 21:09 ferBonnin

the button in the codepen is not failing the Button-name rule

@ferBonnin what build/ version are you reproing that with? I'm seeing the button failing the button-name rule as expected in the current prod.

changing the attr of the button to something without a semicolon makes it such that the frame-title rule fails whether as with the semicolon, no failures are found.

I think this behavior is related to updating the codepen, not to changing the content of the code pen in this specific case. I'm seeing those frame-title failures regardless of how I change the code pen content both in this example and with other code pens.

sfoslund avatar Sep 27 '22 22:09 sfoslund

investigated this with @sfoslund. We found it was an issue with the codepen and couldn't repro when testing html directly.

ferBonnin avatar Sep 28 '22 16:09 ferBonnin