accessibility-insights-web icon indicating copy to clipboard operation
accessibility-insights-web copied to clipboard

Browser extension for Accessibility Insights icon is not visible in high contrast "High Contrast Black" mode

Open sahithikkss-zz opened this issue 3 years ago • 15 comments

Describe the bug

Browser extension for Accessibility Insights icon is not visible in high contrast "High Contrast Black" mode

To Reproduce Steps to reproduce the behavior:

  1. Go to Edge browser with Accessibility Insights installed
  2. Change Windows High contrast settings to "High Contrast Black"
  3. Icon visibility is less and does not meet contrast ratio

Expected behavior

Clear visibility of Accessibility Insights Extension Icon in all high contrast modes

Screenshots

image

image

Context (please complete the following information)

  • OS Name & Version:
  • AI-Web Version & Environment:
  • Browser Version: Edge/Chrome
  • Target Page:

Are you willing to submit a PR?

No

Did you search for similar existing issues?

No

Additional context

N/A

sahithikkss-zz avatar Jul 22 '21 16:07 sahithikkss-zz

I see the issue but I think it needs more investigation to see if we can can programmatically change extension icon when HC mode is on/off

AhmedAbdoOrtiga avatar Jul 23 '21 20:07 AhmedAbdoOrtiga

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

ghost avatar Jul 23 '21 20:07 ghost

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

ghost avatar Jul 23 '21 20:07 ghost

@ferBonnin, our solution in the Windows app was to request new icons that include an internally contrasting border, so that we have correct contrast no matter what the background color happens to be. The same approach might also be viable in the extension.

DaveTryon avatar Jul 26 '21 20:07 DaveTryon

@DaveTryon thanks for sharing! this might be a good option instead of having to change the icons' colors

ferBonnin avatar Jul 26 '21 20:07 ferBonnin

per conversation with @peterdur lets try to make the background of the icon a white circle. Please let us know if a new image from design is needed. the Accessibility insights icon inside a white circle

ferBonnin avatar Jul 26 '21 21:07 ferBonnin

@ferBonnin Looking into the images, we'll need new versions of:

  • https://github.com/microsoft/accessibility-insights-web/blob/main/src/icons/brand/blue/brand-blue-16px.png
  • https://github.com/microsoft/accessibility-insights-web/blob/main/src/icons/brand/blue/brand-blue-48px.png
  • https://github.com/microsoft/accessibility-insights-web/blob/main/src/icons/brand/blue/brand-blue-128px.png

Something to think about: The heart icon in the existing images approaches the edges of the image (the grey box in the image below); to add the circle would require making the heart much smaller. image We may want to consider adding a white border to the heart instead.

peterdur avatar Sep 14 '21 00:09 peterdur

@peterdur got it, let me check with design.

ferBonnin avatar Sep 14 '21 17:09 ferBonnin

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

ghost avatar Sep 14 '21 17:09 ghost

@peterdur, we met with the design team. I am attaching a file with the 3 sizes and an 8px white border. Ok to mark this as ready for work?

new icons (2).zip

ferBonnin avatar Sep 28 '21 21:09 ferBonnin

we met with the design team. I am attaching a file with the 3 sizes and an 8px white border. Ok to mark this as ready for work?

@ferBonnin Looks like we need some tweaks; there's no 16px icon, and the 128px icon is a white heart rather than blue (or is that expected?)

peterdur avatar Sep 28 '21 21:09 peterdur

@ferBonnin Looks like we need some tweaks; there's no 16px icon, and the 128px icon is a white heart rather than blue (or is that expected?)

Ops, my bad! all icons should be blue. I will request a 16px icon, doesn't look like we have it in the Figma yet

ferBonnin avatar Sep 28 '21 21:09 ferBonnin

updated the icons file above

ferBonnin avatar Oct 04 '21 21:10 ferBonnin

@peterdur I think this can now be moved to Ready for work?

ferBonnin avatar Nov 16 '21 16:11 ferBonnin

Holding this for a warm-up project

peterdur avatar May 19 '22 18:05 peterdur

This has been resolved in the Production icon.

ferBonnin avatar Sep 21 '22 21:09 ferBonnin