accessibility-insights-web icon indicating copy to clipboard operation
accessibility-insights-web copied to clipboard

Improve ad-hoc visualizations on cross-origin iframes

Open karanbirsingh opened this issue 3 years ago • 5 comments

Is your feature request related to a problem? Please describe.

Some websites reference cross-origin iframes. Our extension requires additional permissions to run scripts on such pages.

If a user runs an ad-hoc visualization without granting these permissions, the extension silently ignores results in these iframes. My example is headings, but other visualizations like tab stops are similar.

missing headings in an iframe (demo page)

heading inside iframe not highlighted

However, the user is not presented with a permissions banner in the ad-hoc panel. They need to open the details view and run a scan.

after granting permissions:

heading inside iframe is highlighted

Describe the desired outcome

A user reached out to us internally asking why the tool wasn't finding their iframe's heading. It would be good if we can reuse the banner UX, or consider an FAQ / setup question to address it.

Describe alternatives you've considered

We have UX for this for automated checks - when a user attempts either flow, we show a banner:

a banner asking users to give the extension permissions

We could consider something similar.

We have a section in our FAQ that talks about cross-origin iframes, but it assumes the user has seen the banner.

karanbirsingh avatar Jun 10 '21 21:06 karanbirsingh

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

ghost avatar Jun 11 '21 17:06 ghost

as discussed with the team, we will wait until we hear more from users on this edge case scenario. @waabid mentioned he has some ideas on how to tackle this

ferBonnin avatar Jun 25 '21 22:06 ferBonnin

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

ghost avatar Jun 25 '21 22:06 ghost

My idea was to add something like this:

image

This extra text on the bottom would only show if permissions were not granted. I believe we could decide then what this should do: ask for permissions or point to the "learn more" page. The latter might be more appropriate if we feel like the text isn't sufficient and we want to add something longer (that might not fit as nicely and hence, maybe something short for the learn more page).

waabid avatar Jun 28 '21 17:06 waabid

Per conversation with Peter, moving to await community interest to check if this is an issue

ferBonnin avatar Mar 01 '22 00:03 ferBonnin

Unfortunately, this is out of scope given our current priorities.

Thanks for using Accessibility Insights!

DaveTryon avatar Jul 28 '23 20:07 DaveTryon

Hi @DaveTryon I experienced this same issue recently. If you have resolution on how to fix it, e.g as suggested by @waabid , I'd be happy to take it up and raise a PR.

rickynyairo avatar Oct 11 '23 15:10 rickynyairo