accessibility-insights-web icon indicating copy to clipboard operation
accessibility-insights-web copied to clipboard

Color-contrast produces false-positive on elements during transition/animation

Open waabid opened this issue 3 years ago • 4 comments

Describe the bug

Color-contrast produces a failure in automated checks on an element while the DOM may be animating/transitioning around it.

To Reproduce Steps to reproduce the behavior:

Note: these failures are not real failures and only occur randomly and rarely.

  1. Go to https://visualstudio.microsoft.com/
  2. Scroll to the carousel.
  3. Keep scanning until issues are seen (like screenshot below).

Expected behavior

These should not be errors.

Screenshots

image

Context (please complete the following information)

  • OS Name & Version: MacOS Big Sur
  • AI-Web Version & Environment: Version 2.25.0
  • Browser Version: Edge 90.0.818.46
  • Target Page: https://visualstudio.microsoft.com/

Are you willing to submit a PR?

Yes

Did you search for similar existing issues?

Yes

Additional context

waabid avatar Apr 23 '21 22:04 waabid

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

ghost avatar Apr 23 '21 22:04 ghost

per triage conversation, assigning to @waabid

ferBonnin avatar Apr 26 '21 20:04 ferBonnin

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

ghost avatar Apr 26 '21 20:04 ghost

A similar issue was found when there is white text overlaying images with lazyload behavior. Before scrolling down to the images, AI Web would find the color contrast issues. The color contrast issues are not present when scrolling down the page far enough to load the images (no color contrast issues by the time the user can view the images/text). Additionally, the color contrast issues are not present when CSS is disabled for the page.

lisli1 avatar May 20 '21 00:05 lisli1

The service has a bit at packages\scanner-global-library\src\page-navigation-hooks.ts that injects some CSS that disables animations on target pages. I think we have similar in our own e2e tests of ourselves. We might consider applying something similar to target pages.

dbjorge avatar May 22 '23 19:05 dbjorge

After reviewing the full list of issues in our backlog, we have concluded that we will not be addressing this issue.

DaveTryon avatar Jun 29 '23 23:06 DaveTryon