accessibility-insights-service
accessibility-insights-service copied to clipboard
[Feature Request] Axe-core rules should be consistent between service and web
Describe the bug
In the web repo, we use the axe-core rules that are enabled by default (non-experimental) and then disable anything tagged with best-practice. In the service, we keep a list of rules to disable, which may change when axe-core updates. This makes it difficult to consistently run the same rules in web and service.
We should make sure that web and service use a consistent set of rules. One solution is to create an npm package that returns a list of rules, and have both web and service consume that package.
This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!
This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!
The service had combined axe core rules into one places. Therefore any update to axe core/rules will require single place to change either axe core version or rules definition file. This is similar to if we had axe core extended package that should be updated and its version should be updated in service or other consumers. The feature could be postponed.
Update: The service is not yet using the config generator, and when I asked if there are any plans to use it, the answer was no. The service code is at https://github.com/microsoft/accessibility-insights-service/blob/main/packages/scanner-global-library/src/axe-scanner/axe-run-options.ts.