WindowsAppSDK icon indicating copy to clipboard operation
WindowsAppSDK copied to clipboard

C++ VSIX tag exceeds max tag length of 50

Open DefaultRyan opened this issue 3 years ago • 3 comments

Describe the bug

PR #1805 added the tag "WinAppSDK" to the C++ VSIX, but this takes it slightly over the max tag length of 50. We need to shorten slightly, and C++ is slightly redundant with C++/WinRT.

Let's remove one of those.

Steps to reproduce the bug

Running the VSIX publishing pipeline results in an error.

Expected behavior

No response

Screenshots

No response

NuGet package version

No response

Packaging type

No response

Windows version

No response

IDE

No response

Additional context

No response

DefaultRyan avatar Jul 02 '22 02:07 DefaultRyan

SUGGESTION: Drop 'C++/WinRT'

BEFORE: WindowsAppSDK, WinAppSDK, WinUI, XAML, C++, C++/WinRT = 54 chars

AFTER: WindowsAppSDK, WinAppSDK, WinUI, XAML, C++ = 43 chars

That aligns better with the C# VSIX tags WindowsAppSDK, WinAppSDK, WinUI, XAML, C#, Managed (=50 chars)

(I guess you could tack 'Native' onto the C++ string to be consistently redundant... :P How about that 'Managed' keyword? Is that all that meaningful?

DrusTheAxe avatar Jul 02 '22 11:07 DrusTheAxe

Do the tags need whitespace or just comma separator?

<tags>WindowsAppSDK, WinAppSDK, WinUI, XAML, C++</tags>

is it equally valid to say <tags>WindowsAppSDK,WinAppSDK,WinUI,XAML,C++</tags> ?

DrusTheAxe avatar Jul 02 '22 11:07 DrusTheAxe

Looks wrong. Where did you get 50 characters from @DefaultRyan? And why are there commas? 🤔

<Tags> - This optional element lists additional semicolon-delimited text tags that are used for search hints. The Tags element is limited to 100 characters.

https://docs.microsoft.com/visualstudio/extensibility/vsix-extension-schema-2-0-reference?view=vs-2022

riverar avatar Jul 02 '22 18:07 riverar