WindowsAppSDK icon indicating copy to clipboard operation
WindowsAppSDK copied to clipboard

Taskbar is still there in full screen mode entered from maximized window

Open kingcean opened this issue 3 years ago • 7 comments

Describe the bug

The taskbar is not covered if the window was maximized before entering full screen.

Steps to reproduce the bug

  1. Maximize the window.
  2. Enter full screen.

Expected behavior

The taskbar should disappear until the window closes or exits from full screen.

Screenshots

Maximize window ↑ Maximize window

Full screen ↑ Then enter full screen (but you can still see the taskbar)

NuGet package version

1.1.0

Packaging type

Packaged (MSIX)

Windows version

Windows 11 version 21H2 (22000)

IDE

Visual Studio 2022

Additional context

No response

kingcean avatar Jun 05 '22 14:06 kingcean

Hey @kingcean do you have a repro so we can take a look at the APIs that you are using?

marb2000 avatar Jun 06 '22 23:06 marb2000

Yes. You can maximize the window first (by programming or by clicking/tapping the caption button), and then enter full screen to have a look.

// var appWindow = ... The AppWindow instance of MainWindow.
var presenter = appWindow.Presenter as Microsoft.UI.Windowing.OverlappedPresenter;
presenter.Maximize();
appWindow.SetPresenter(Microsoft.UI.Windowing.AppWindowPresenterKind.FullScreen);

kingcean avatar Jun 07 '22 01:06 kingcean

This repros 100% if window is in maximized state before fullscreen presenter is set.

Repro project: was_issue_2577.zip

AppWindow seems to really unreliable and a continuous source of bugs. Would recommend increasing test suite coverage and engineering scrutiny on AppWindow classes.

riverar avatar Jun 07 '22 16:06 riverar

I can repro this with the WinUIEx Sample app. Just run the app, maximize window, then select the "Fullscreen" presenter in the presenter dropdown. My app restores to the non-maximized state when I do this, yet claims to be fullscreen.

dotMorten avatar Jun 07 '22 16:06 dotMorten

Yeah, this one should not have been able to slip through the automated tests. 😞 I've logged a task for the dev team and we'll be adding it to a servicing release as soon as we have a fix.

MSFT dev team tracking: http://task.ms/39908320

rkarman avatar Jun 07 '22 18:06 rkarman

I can still repro this on Windows App SDK 1.1.1.

kingcean avatar Jun 16 '22 09:06 kingcean

Still reproducible with Windows App SDK 1.1.4.

koenvd avatar Sep 21 '22 06:09 koenvd

Thanks! 😊

From: Roberth Karman @.> Sent: Tuesday, November 1, 2022 10:52 AM To: microsoft/WindowsAppSDK @.> Cc: Steve Wright @.>; Assign @.> Subject: Re: [microsoft/WindowsAppSDK] Taskbar is still there in full screen mode entered from maximized window (Issue #2577)

Assigned #2577https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FWindowsAppSDK%2Fissues%2F2577&data=05%7C01%7Cswright%40microsoft.com%7C25a4c1651be74407bfcc08dabc31c341%7C72f988bf86f141af91ab2d7cd011db47%7C0%7C0%7C638029219194454300%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AfrBvknii4pm%2FWbCby8N2hSqq5t9Jj%2Fdf2ix8%2B7f2nY%3D&reserved=0 to @stevewrihttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fstevewri&data=05%7C01%7Cswright%40microsoft.com%7C25a4c1651be74407bfcc08dabc31c341%7C72f988bf86f141af91ab2d7cd011db47%7C0%7C0%7C638029219194454300%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kmqduRzEM%2B2zr%2Biha5J91FTfJxIiQvwkIJ8K8vskoVE%3D&reserved=0.

— Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FWindowsAppSDK%2Fissues%2F2577%23event-7715769233&data=05%7C01%7Cswright%40microsoft.com%7C25a4c1651be74407bfcc08dabc31c341%7C72f988bf86f141af91ab2d7cd011db47%7C0%7C0%7C638029219194454300%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VweWRhdOBxSeegyhz5yIXKR%2BfvWczoWv3tK6Coq68z8%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPVPIIZJJAZDKBR77KR7MYLWGFKDTANCNFSM5X5DVN6Q&data=05%7C01%7Cswright%40microsoft.com%7C25a4c1651be74407bfcc08dabc31c341%7C72f988bf86f141af91ab2d7cd011db47%7C0%7C0%7C638029219194454300%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tQM9ulz%2BjephHFeet7Rtv2tzoFNP%2FQ732QyDXFopmSU%3D&reserved=0. You are receiving this because you were assigned.Message ID: @.@.>>

stevewri avatar Nov 01 '22 18:11 stevewri

Fixed - v1.2. However, if you exit full screen and restore, the window size is not the one before maximizing and entering full screen. For example, set window size to 1000x600 → maximize → enter full screen → exit full screen → restore, then the window size is not 1000x600 anymore but fill the screen.

kingcean avatar Nov 11 '22 04:11 kingcean