WindowsAppSDK icon indicating copy to clipboard operation
WindowsAppSDK copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Making EM RS5+. Limiting the tracking capability to Windows11+.

Open dhoehna opened this issue 2 years ago • 5 comments

I realized that the API used to manipulating environment variables can work down level. The restriction to EM was tracking the changes so they could be reverted when a package was removed.

I split up the changes. IsSupported always returns true. If the developer wants to know if the changes will be tracked, they can call the object method AreChangesTracked.

List of changes.

  1. IsSupported returns true because EM APIs can work downlevel.
  2. Added the object method AreChangesTracked. This can be used to see if the EV changes will be tracked for revertion.
  3. Removed the UWP tests.

dhoehna avatar May 19 '22 20:05 dhoehna

The requirement of an API review flew over my head. I'll be in contact to schedule and API review.

dhoehna avatar May 19 '22 22:05 dhoehna

Started a discussion: https://github.com/microsoft/WindowsAppSDK/issues/2536

dhoehna avatar May 20 '22 16:05 dhoehna

I won't be making any updates to this PR until https://github.com/microsoft/WindowsAppSDK/pull/2544 is merged into main.

dhoehna avatar May 23 '22 18:05 dhoehna

/azp run

dhoehna avatar Jun 13 '22 19:06 dhoehna

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 13 '22 19:06 azure-pipelines[bot]

Closing PRs that appear to have been abandoned.

bpulliam avatar Apr 03 '23 12:04 bpulliam