WindowsAppSDK icon indicating copy to clipboard operation
WindowsAppSDK copied to clipboard

Custom TitleBar is not working in RTL

Open ghost1372 opened this issue 3 years ago • 13 comments

Describe the bug

i used Custom titlebar from here https://docs.microsoft.com/en-us/windows/apps/develop/title-bar?tabs=wasdk#platform-options

now if we change App Language to RTL, Custom Titlebar is not working (Window can not be dragged and Close Button is not work)

Steps to reproduce the bug

1.Create custom titlebar in RTL app

Expected behavior

No response

Screenshots

No response

NuGet package version

1.1.0-preview3

Packaging type

Packaged (MSIX), Unpackaged

Windows version

Windows 11 version 21H2 (22000)

IDE

Visual Studio 2022

Additional context

No response

ghost1372 avatar May 15 '22 14:05 ghost1372

@ghost1372 Can you provide a reproducible example? What language are you targeting?

This works for me. Used 1.1.0-preview1 on 22000 and 25115. image

riverar avatar May 16 '22 18:05 riverar

Hi @riverar please test with 1.1.0-preview3 Animation

App25.zip

ghost1372 avatar May 17 '22 08:05 ghost1372

OK, this is more of a problem with the sample code (SetDragRegionForCustomTitleBar) at https://docs.microsoft.com/en-us/windows/apps/develop/title-bar?tabs=wasdk#interactive-content. Can confirm it's broken and incorrectly assumes LTR layout.

Adding @rkarman @BenJKuhn

riverar avatar May 18 '22 18:05 riverar

We've verified this bug and logged it here http://task.ms/39695482. We will add it as part of v1.2 planning.

mevey avatar May 23 '22 19:05 mevey

Hope it is considered for servicing as it impacts global readiness.

riverar avatar May 23 '22 23:05 riverar

Yes, this we will consider servicing the fix in in-market releases.

mevey avatar May 24 '22 16:05 mevey

@mevey Great news, thanks for closing the loop!

riverar avatar May 24 '22 17:05 riverar

@mevey or @riverar do you think this will fix #2953?

jamers99 avatar Sep 09 '22 17:09 jamers99

@jamers99 The bug described here was ultimately a problem with the sample in the docs, so no don't think any changes here will fix that sadly.

riverar avatar Sep 09 '22 18:09 riverar

@riverar should this be closed then?

jamers99 avatar Sep 09 '22 18:09 jamers99

@jamers99 Doesn't look like the sample was updated yet, so think it needs to remain open. @mevey may have more info.

riverar avatar Sep 09 '22 18:09 riverar

@riverar thanks for the insight, makes sense. Do you have any idea if I should keep #2953 or microsoft/microsoft-ui-xaml#7392? How should I go about getting more priority for it? It's a big deal for our tab based app. Unless we find a workaround, I think it's a stopper.

jamers99 avatar Sep 09 '22 18:09 jamers99

@jamers99 I'd keep both, just to have data on how inattentive Microsoft is in the Microsoft UI XAML repository. I'll take a look at your issue and update you in the other thread.

riverar avatar Sep 09 '22 18:09 riverar

This issue has been resolved in version 1.2 stable

ghost1372 avatar Nov 27 '22 10:11 ghost1372