WindowsAppSDK-Samples icon indicating copy to clipboard operation
WindowsAppSDK-Samples copied to clipboard

PushNotifications sample says to request WNS channel using Azure AppId instead of Azure ObjectId

Open christopher-rtf opened this issue 2 years ago • 1 comments

Both of the following documents say to use the Azure AppId to request a WNS push notification channel:

  • https://github.com/microsoft/WindowsAppSDK-Samples/blob/main/Samples/Notifications/Push/cpp-console-unpackaged/cpp-console-unpackaged.cpp
  • https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/Notifications/Push

However, the Push Notifications quick start says that the Azure AppId should be used for the server-side push notification registration and that the Azure ObjectId should be used to request a WNS push notification channel:

  • https://github.com/MicrosoftDocs/windows-dev-docs/blob/docs/hub/apps/windows-app-sdk/notifications/push-notifications/push-quickstart.md

Which one of these is the correct? We have been successful using the Azure ObjectID to request a channel on the client, but I am a little nervous that this may break in the future as requesting a channel using the Azure AppID seems to return a channel Uri as well.

I didn't want to cross-post this issue to both repos, but perhaps this should also be posted as an issue on https://github.com/MicrosoftDocs?

christopher-rtf avatar Aug 04 '23 18:08 christopher-rtf

Thank you @christopher-rtf! Apologies for the delay. Looks like we didn't update the sample code. The guidance is correct, please continue to use the Azure ObjectId. @loneursid, can you please make a small adjustment to the sample app code to say "Replace this with your own Azure ObjectId" instead of "Replace this with your own Azure AppId"? Thank you!

vaheeshta avatar Feb 09 '24 17:02 vaheeshta