Windows-Machine-Learning icon indicating copy to clipboard operation
Windows-Machine-Learning copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

allow specifying an adapter name also when using DXGI

Open deischi opened this issue 6 years ago • 3 comments

I see no need to use DXCORE to specify an adapter name.

deischi avatar Jul 24 '19 09:07 deischi

CLA assistant check
All CLA requirements met.

msftclas avatar Jul 24 '19 09:07 msftclas

Hi @deischi, thank you for your contribution! It's correct that specifying adapter name shouldn't be constrained to DxCore.

I have a few suggested changes:

  • There is already a conditional to handle if "-GPUAdapterName" flag is used. Can your code to choose adapter be added inside here?: https://github.com/microsoft/Windows-Machine-Learning/blob/ed0b176a8b4a273ae8ce124b507ba833fc30ecb6/Tools/WinMLRunner/src/Run.cpp#L210

  • Within the conditional of (WinMLDeviceKind isn't CPU and adaptername isn't empty). One flow can be like this:

    • Try to use DXGI to enumerate adapters
    • Fall back to using DxCore if DXGI doesn't work / isn't available.
    • #ifdef check for DXCORE_SUPPORTED_BUILD will need to be around the DxCore code.
    • Create Session with chosen adapter.

  • Check for first matching substring for adapter name.

  • Spaces instead of tabs for spacing.

Thanks! Let me know if you have any questions.

ryanlai2 avatar Jul 24 '19 20:07 ryanlai2

I have tried to add my changes as local and small as possible to quickly get a result.

You are right, having the adapter selection only once would be better. Please understand that improving the WinMlRunner is not one of the top priorities, so it will definitely take some time until come to that. Also I have no access to DXCore, any changes I will do related to that will be done blindly.

deischi avatar Jul 25 '19 05:07 deischi