WinUI-Gallery icon indicating copy to clipboard operation
WinUI-Gallery copied to clipboard

Add `RepositionThemeTransition` to sample pages for smoother layout updates

Open Zakariathr22 opened this issue 3 months ago • 4 comments

Description

This PR Updates ItemPage to add RepositionThemeTransition to content pages after navigation, main changes are:

  • Hooked contentFrame.Navigated to detect when the new page is loaded.
  • Added logic to attach a RepositionThemeTransition to the root Panel.

Motivation and Context

Improves visual consistency.

How Has This Been Tested?

Manually verified across affected sample pages to ensure transitions apply correctly without breaking layout.

Screenshots (if appropriate):

Before Before After After

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Zakariathr22 avatar Sep 15 '25 21:09 Zakariathr22

/azp run

Saharsh979 avatar Sep 18 '25 05:09 Saharsh979

The PR description lacks the rationale behind why RepositionThemeTransition is added, which could confuse maintainers unfamiliar with it. Feel free to add more details along with the Before vs After Screenshot to give a visual sense of the improvement you're introducing.

Saharsh979 avatar Sep 18 '25 05:09 Saharsh979

The PR description lacks the rationale behind why RepositionThemeTransition is added, which could confuse maintainers unfamiliar with it. Feel free to add more details along with the Before vs After Screenshot to give a visual sense of the improvement you're introducing.

Done!

Zakariathr22 avatar Sep 18 '25 10:09 Zakariathr22

@marcelwgn Need your opinion on this

Zakariathr22 avatar Oct 12 '25 07:10 Zakariathr22

/azp run

Saharsh979 avatar Dec 17 '25 11:12 Saharsh979