WinUI-Gallery
WinUI-Gallery copied to clipboard
microsoft
Use Selectorbar for Sample Code
related to #1535
Full Code (Xaml/C#)
Single Code (Xaml Only)
Description
Motivation and Context
How Has This Been Tested?
Tested on my Laptop
Screenshots (if appropriate):
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Thank you for creating this PR!
I think porting the SwitchPresenter control over just for this is a bit overkill, this problem can also be solved with a bit of code-behind. Also, given that people also use this app's source code for reference, introducing a new control just for this doesn't seem like the best idea.
I saw that the gallery uses some communitytoolkit Nuget packages. For a simple control, I did not use the community Nuget package, which has a larger size... That's why I copied their codes.
We are in fact using Community Toolkit packages, that is correct. I would argue though, in this case, porting a complete control for something one could do with a few lines of code behind is overkill.
We are in fact using Community Toolkit packages, that is correct. I would argue though, in this case, porting a complete control for something one could do with a few lines of code behind is overkill.
ok, what do you suggest? Changing visibility? Frame?
ok, what do you suggest? Changing visibility? Frame?
I would probably use a ContentPresenter and have that switch the content
@marcelwgn I saw your last message late, I sent 2 commits, First by changing the visibility and lastly the suggestion you gave.
For some reason - for some controls, the content is empty.
hmm... it seems that XamlSource is just a file path, so content will be updated later after reading file.
@Jay-o-Way i reverted last commit (ContentPresenter) now everything is working fine
Does this solve #704?
No. we need to disable horizontal scroll
For me, this pr currently actually does disable horizontal movement when using the scroll wheel hovering this area. 🥳 @karkarl
Does this solve #704?
No. we need to disable horizontal scroll
For me, this pr currently actually does disable horizontal movement when using the scroll wheel hovering this area. 🥳 @karkarl
I'm ok disabling horizontal scroll. It annoys me a lot too :P
Question: I see muxc:Expander is used, but do we still need the muxc part?
One more detail please? Removing this margin/padding would be pretty.
Does this solve #704?
No. we need to disable horizontal scroll
For me, this pr currently actually does disable horizontal movement when using the scroll wheel hovering this area. 🥳 @karkarl
I'm ok disabling horizontal scroll. It annoys me a lot too :P
done
Hold on, I see a little misunderstanding here. The issue in 704 was: When scrolling (vertically) across a page, coming over a code example gives an unwanted horizontal scrolling. This PR already solved that. The last commit makes it impossible to scroll horizontally. Please revert.
Done
I think we'd want to horizontally align the XAML / C# SelectorBar with the XAML?
Done