WinUI-Gallery icon indicating copy to clipboard operation
WinUI-Gallery copied to clipboard

Request: move CopyButton lower

Open Jay-o-Way opened this issue 1 year ago • 6 comments

Issue type

enhancement

Which version of the app?

WinUI 3 Gallery

Description

Currently, the CopyButton is usually displayed on one line, next to the related value. However, for the colors, it's displayed in the top-right corner, while the value is on the bottom. It would be nice if the CopyButton sticks immediately to the right of the value everywhere.

Screenshots

image

Windows version

Windows 11 23H2 (22631)

Additional context

Check validity / status for this message. image

Jay-o-Way avatar May 05 '24 18:05 Jay-o-Way

I can create a PR for this 💪 image

Jay-o-Way avatar May 05 '24 18:05 Jay-o-Way

Understand the reasoning! But we moved it to the top because the brush names tend to be much longer than the titles. As a result, brush names are either clipped or wrapped, both not great.

niels9001 avatar May 06 '24 21:05 niels9001

Is there a reason why the copy buttons don't only show up on hover? That might solve the issue with longer brush names. I remember reading a Microsoft design guideline that discourages it.

karkarl avatar May 16 '24 18:05 karkarl

Is there a reason why the copy buttons don't only show up on hover? That might solve the issue with longer brush names. I remember reading a Microsoft design guideline that discourages it.

That would require adding keyboarding support as well :(

niels9001 avatar May 16 '24 18:05 niels9001

we moved it to the top because the brush names tend to be much longer than the titles. As a result, brush names are either clipped or wrapped, both not great.

That argument is not valid in every case: image

Jay-o-Way avatar May 25 '24 18:05 Jay-o-Way

@karkarl can you confirm if the message is outdated and can be removed?

This brush might not (yet) be available in WinUI

Jay-o-Way avatar Oct 02 '24 14:10 Jay-o-Way