WinUI-Gallery icon indicating copy to clipboard operation
WinUI-Gallery copied to clipboard
verified publisher icon microsoft

Refactor Codebase

Open karkarl opened this issue 2 years ago • 4 comments

Refactor WinUI-Gallery codebase:

### Tasks
- [ ] Remove unused code
- [x] remove outdated ThemeResources
- [ ] Proper xaml formatting
- [x] Proper class name / namespaces
- [x] Accessibility pass
- [x] Clean out unnecessary branches
- [x] Re-name `NewControls*` to `Home`
- [ ] https://github.com/microsoft/WinUI-Gallery/issues/1445
- [ ] https://github.com/microsoft/WinUI-Gallery/issues/1542

karkarl avatar May 03 '23 17:05 karkarl

Spring clean-up 🧹🪣🧽😛

Jay-o-Way avatar May 14 '23 17:05 Jay-o-Way

@niels9001 Would this include - for example - the following? https://github.com/microsoft/WinUI-Gallery/blob/0a300bf69a51cf7684e93d95d89d9375130738f3/WinUIGallery/SettingsPage.xaml#L12-L20

Those numbers are not by the book; the elements (TextBlock) can probably be replaced with more modern implementations via SettingsGroup (Header)

Jay-o-Way avatar May 30 '23 12:05 Jay-o-Way

@Jay-o-Way Yes - the idea is to have WinUI Gallery also be a useful repo to refer to for best coding practices. That includes updating redundant xaml.

karkarl avatar May 30 '23 17:05 karkarl

Also a nit I found:

https://github.com/microsoft/WinUI-Gallery/blob/0a300bf69a51cf7684e93d95d89d9375130738f3/WinUIGallery/SectionPage.xaml#L40

is unneeded - actually conflicting with line 49: Style="{StaticResource TitleTextBlockStyle}"

Is it better to define style with Setters or in-element?

Jay-o-Way avatar May 30 '23 21:05 Jay-o-Way