WinUI-Gallery icon indicating copy to clipboard operation
WinUI-Gallery copied to clipboard

Add control namespaces to sample page header

Open marcelwgn opened this issue 1 year ago • 4 comments

This PR adds the controls/APIs namespace to the top of the controls page: Screenshot of AnimatedIcon page with new subheader displaying the controls namespace

Closes #1023

marcelwgn avatar Jul 24 '22 20:07 marcelwgn

The changes look great to me but I'm unable to load a control page for some reason. The app launches but when I try to click on a control, I get the "combase.pdb not loaded" error message. @chingucoding did you also get that error?

gregwoo-microsoft avatar Jul 25 '22 22:07 gregwoo-microsoft

I am not experiencing these issue @gregwoo-microsoft , that's really strange. If you could get a stack trace, it might be easier for me to see what could cause this.

marcelwgn avatar Jul 26 '22 18:07 marcelwgn

@chingucoding This is what I am getting. Let me know if this helps.

combase.dll!RoFailFastWithErrorContextInternal2(HRESULT hrError, unsigned long cStowedExceptions, _STOWED_EXCEPTION_INFORMATION_V2 * * aStowedExceptionPointers) Line 1471 C++ Microsoft.ui.xaml.dll!7b870d29() Unknown Microsoft.ui.xaml.dll![Frames below may be incorrect and/or missing, no symbols loaded for Microsoft.ui.xaml.dll] Unknown [External Code] WinUIGallery.DesktopWap.dll!AppUIBasics.NavigationRootPage.EnsureNavigationSelection(string id) Line 214 C# WinUIGallery.DesktopWap.dll!AppUIBasics.ItemPage.OnNavigatedTo(Microsoft.UI.Xaml.Navigation.NavigationEventArgs e) Line 191 C# [External Code] WinUIGallery.DesktopWap.dll!AppUIBasics.NavigationRootPage.Navigate(System.Type pageType, object targetPageArguments, Microsoft.UI.Xaml.Media.Animation.NavigationTransitionInfo navigationTransitionInfo) Line 180 C# WinUIGallery.DesktopWap.dll!AppUIBasics.ItemsPageBase.OnItemGridViewItemClick(object sender, Microsoft.UI.Xaml.Controls.ItemClickEventArgs e) Line 71 C# [External Code]

gregwoo-microsoft avatar Jul 27 '22 19:07 gregwoo-microsoft

@gregwoo-microsoft Could you try loading the symbols for Microsoft.UI.Xaml.dll? Maybe that helps tracking it down, looking at the stack trace, it seems that selecting an item is broken but that is not something that should be affected by this PR.

marcelwgn avatar Jul 28 '22 07:07 marcelwgn

@gregwoo-microsoft Is this good to go?

marcelwgn avatar Sep 08 '22 19:09 marcelwgn

Looks awesome! Thank you Marcel :)

gregwoo-microsoft avatar Sep 10 '22 02:09 gregwoo-microsoft