WebTemplateStudio icon indicating copy to clipboard operation
WebTemplateStudio copied to clipboard

Generated app should pass webhint.io/scanner

Open crutkas opened this issue 5 years ago • 4 comments

Was talking to @boyofgreen and he brought up getting 100% on this scanner would be also helpful. We're close but not perfect.

Sample run: https://webhint.io/scanner/7b40c2d7-51ff-46db-a269-411bdebeaf91

crutkas avatar Apr 30 '19 04:04 crutkas

Was taking a look at options available for contribution, and thought I'd add some notes here related to this issue.

From the webhint.io output, I see two types of hints recommended:

  1. Performance - missing cache-control. When I load the app page referenced in webhint.io link, the only call I see missing cache-control is the API call: https://webtstest.azurewebsites.net/api/masterdetail So if wanting to enforce best practices, one option would be to incorporate helm and set no-cache on api calls that way.
  2. Security - headers for powered by, etc. These need to be removed at the level of the server hosting the solution(s). So really hosting issue vs app issue. That said, this seems to be an app service, so to remove I think needs to be web.config settings (see: https://azure.microsoft.com/en-us/blog/removing-standard-server-headers-on-windows-azure-web-sites/). I don't see any info on how the example site is deployed, and also don't see a link to the example site from repo readme anywhere. Is this info that should be added to documentation also?

kmkatsma avatar May 17 '19 00:05 kmkatsma

one way you could contribute is to create a sample project with webTS and then do the adjustments there, we can then add in the physical adjustments to the templates. or if you feel comfortable, just directly alter the templates.

crutkas avatar May 17 '19 15:05 crutkas

We re-ran the scanner on the web app generated but got inconsistent results, and the changes we made caused unexpected results from the scanner.

Here's our run: https://webhint.io/scanner/6a30ba33-e9cd-4ac4-8501-2a14be49969c

jasmingoh avatar May 31 '19 19:05 jasmingoh

Accessibility seems to have had an error I would re run.

SahilTara avatar Jun 01 '19 23:06 SahilTara