Web-Dev-For-Beginners icon indicating copy to clipboard operation
Web-Dev-For-Beginners copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Update README.md

Open captainWaheed opened this issue 2 years ago • 4 comments

I just updated the README file with a PDF preview by embedding it.

captainWaheed avatar Jul 16 '22 16:07 captainWaheed

@captainWaheed PDF embeds does not seem to work on GitHub, did you test it?

sinedied avatar Aug 19 '22 08:08 sinedied

@captainWaheed PDF embeds does not seem to work on GitHub, did you test it?

Yes I tested it with few methods but this one is working well.

captainWaheed avatar Aug 19 '22 09:08 captainWaheed

@captainWaheed I if look at the GitHub preview on your branch, this is what I see: image The preview isn't visible, GitHub seems to block it for PDFs as a security measure.

sinedied avatar Aug 19 '22 12:08 sinedied

@captainWaheed I if look at the GitHub preview on your branch, this is what I see: image The preview isn't visible, GitHub seems to block it for PDFs as a security measure.

Oh, I see! The last time I committed changes this was working fine, anyway I guess you were right. Thanks for the confirmation.

captainWaheed avatar Aug 19 '22 14:08 captainWaheed

This PR has not seen any action for a while! Closing for now, but it can be reopened at a later date.

github-actions[bot] avatar Oct 29 '22 08:10 github-actions[bot]