WSL icon indicating copy to clipboard operation
WSL copied to clipboard

Add a systemd override binfmt-support.service to protect wsl's interop entry

Open OneBlue opened this issue 6 months ago • 2 comments

Summary of the Pull Request

This pull request solves an issue where binfmt-support can override WSL's binfmt interpreter for Windows executables.

PR Checklist

  • [ ] Closes: Link to issue #xxx
  • [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [ ] Tests: Added/updated if needed and all pass
  • [ ] Localization: All end user facing strings can be localized
  • [ ] Dev docs: Added/updated if needed
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Manually validated that the solves the issue when mono is installed

OneBlue avatar May 29 '25 00:05 OneBlue

Should we add a test where we install mono and make sure interop still works?

benhillis avatar May 29 '25 17:05 benhillis

Should we add a test where we install mono and make sure interop still works?

I want to do that, but we've made it so the tests don't try to download packages from the internet since that lead to random failures.

I think the best way to do that would be to have a test artifact with the package somewhere so we can easily install it during the tests, but I'd rather do that in a separate change

OneBlue avatar May 29 '25 17:05 OneBlue

The test failures are caused by a cloudtest change, merging since the test failures are unrelated.

OneBlue avatar May 30 '25 21:05 OneBlue