TypeScript
TypeScript copied to clipboard
microsoft
Fixed crash in `hasVisibleDeclarations` related to binding elements
Starting jobs; this comment will be updated as builds start and complete.
| Command | Status | Results |
|---|---|---|
test top400 |
✅ Started | ✅ Results |
user test this |
✅ Started | ✅ Results |
run dt |
✅ Started | ✅ Results |
perf test this faster |
✅ Started | ❌ Results |
Hey @RyanCavanaugh, the results of running the DT tests are ready.
Everything looks the same!
@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/61352/merge:
Everything looks good!
@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61352/merge:
Everything looks good!
@RyanCavanaugh Looks like the perf test this faster command fails because @electron/[email protected] requires Node.js version >=22.12.0, but the Docker container is running Node.js 20.19.2.
Another example of a PR where it fails: https://github.com/microsoft/TypeScript/pull/61888. Seems to be a general CI issue
Starting jobs; this comment will be updated as builds start and complete.
| Command | Status | Results |
|---|---|---|
perf test this faster |
✅ Started | 👀 Results |
@jakebailey The results of the perf run you requested are in!
Here they are:
tsc
Comparison Report - baseline..pr| Metric | baseline | pr | Delta | Best | Worst | p-value |
|---|---|---|---|---|---|---|
| Compiler-Unions - node (v18.15.0, x64) | ||||||
| Errors | 34 | 34 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 62,370 | 62,370 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 50,386 | 50,386 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 193,500k (± 0.76%) | 195,924k (± 0.75%) | +2,424k (+ 1.25%) | 192,913k | 196,566k | p=0.020 n=6 |
| Parse Time | 1.31s | 1.31s (± 0.39%) | ~ | 1.31s | 1.32s | p=0.174 n=6 |
| Bind Time | 0.73s | 0.73s | ~ | ~ | ~ | p=1.000 n=6 |
| Check Time | 9.70s (± 0.62%) | 9.69s (± 0.47%) | ~ | 9.65s | 9.78s | p=0.936 n=6 |
| Emit Time | 2.75s (± 0.80%) | 2.74s (± 0.55%) | ~ | 2.73s | 2.77s | p=0.618 n=6 |
| Total Time | 14.48s (± 0.53%) | 14.48s (± 0.32%) | ~ | 14.42s | 14.56s | p=0.810 n=6 |
| angular-1 - node (v18.15.0, x64) | ||||||
| Errors | 56 | 56 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 948,750 | 948,750 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 410,846 | 410,846 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 1,224,604k (± 0.01%) | 1,224,644k (± 0.00%) | ~ | 1,224,572k | 1,224,706k | p=0.471 n=6 |
| Parse Time | 6.60s (± 0.50%) | 6.57s (± 0.36%) | ~ | 6.53s | 6.60s | p=0.192 n=6 |
| Bind Time | 1.88s (± 0.43%) | 1.88s (± 0.58%) | ~ | 1.86s | 1.89s | p=0.666 n=6 |
| Check Time | 31.77s (± 0.29%) | 31.89s (± 0.25%) | +0.12s (+ 0.37%) | 31.78s | 32.00s | p=0.043 n=6 |
| Emit Time | 14.89s (± 0.44%) | 14.89s (± 0.68%) | ~ | 14.74s | 15.02s | p=1.000 n=6 |
| Total Time | 55.14s (± 0.22%) | 55.23s (± 0.19%) | ~ | 55.10s | 55.38s | p=0.296 n=6 |
| mui-docs - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 2,509,169 | 2,509,169 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 892,704 | 892,704 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 2,803,926k (± 0.00%) | 2,803,917k (± 0.00%) | ~ | 2,803,863k | 2,803,978k | p=1.000 n=6 |
| Parse Time | 8.86s (± 0.27%) | 8.84s (± 0.36%) | ~ | 8.80s | 8.89s | p=0.146 n=6 |
| Bind Time | 2.23s (± 0.28%) | 2.24s (± 0.61%) | ~ | 2.22s | 2.26s | p=0.388 n=6 |
| Check Time | 84.10s (± 0.23%) | 84.32s (± 0.23%) | ~ | 84.00s | 84.56s | p=0.128 n=6 |
| Emit Time | 0.30s (± 2.11%) | 0.30s | ~ | ~ | ~ | p=1.000 n=6 |
| Total Time | 95.49s (± 0.20%) | 95.69s (± 0.20%) | ~ | 95.38s | 95.88s | p=0.109 n=6 |
| self-build-src - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 1,227,126 | 1,227,127 | +1 (+ 0.00%) | ~ | ~ | p=0.001 n=6 |
| Types | 267,408 | 267,407 | -1 (- 0.00%) | ~ | ~ | p=0.001 n=6 |
| Memory used | 2,545,041k (±11.98%) | 2,362,132k (± 0.02%) | 🟩-182,908k (- 7.19%) | 2,361,620k | 2,362,668k | p=0.020 n=6 |
| Parse Time | 5.25s (± 1.06%) | 5.20s (± 1.12%) | ~ | 5.14s | 5.29s | p=0.173 n=6 |
| Bind Time | 1.79s (± 1.08%) | 1.81s (± 0.81%) | ~ | 1.79s | 1.83s | p=0.084 n=6 |
| Check Time | 35.10s (± 0.67%) | 35.41s (± 0.79%) | ~ | 35.07s | 35.70s | p=0.093 n=6 |
| Emit Time | 2.99s (± 1.35%) | 2.99s (± 0.95%) | ~ | 2.95s | 3.03s | p=1.000 n=6 |
| Total Time | 45.15s (± 0.61%) | 45.42s (± 0.73%) | ~ | 45.02s | 45.79s | p=0.378 n=6 |
| self-build-src-public-api - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 1,227,126 | 1,227,127 | +1 (+ 0.00%) | ~ | ~ | p=0.001 n=6 |
| Types | 267,408 | 267,407 | -1 (- 0.00%) | ~ | ~ | p=0.001 n=6 |
| Memory used | 2,796,184k (±14.27%) | 3,038,920k (± 9.76%) | ~ | 2,432,817k | 3,161,172k | p=0.810 n=6 |
| Parse Time | 6.83s (± 1.52%) | 6.85s (± 0.92%) | ~ | 6.74s | 6.92s | p=0.873 n=6 |
| Bind Time | 2.19s (± 1.87%) | 2.14s (± 1.08%) | -0.05s (- 2.21%) | 2.11s | 2.17s | p=0.025 n=6 |
| Check Time | 42.69s (± 0.81%) | 42.72s (± 0.41%) | ~ | 42.50s | 42.91s | p=0.575 n=6 |
| Emit Time | 3.49s (± 2.67%) | 3.45s (± 1.40%) | ~ | 3.38s | 3.51s | p=0.471 n=6 |
| Total Time | 55.21s (± 0.82%) | 55.17s (± 0.43%) | ~ | 54.84s | 55.44s | p=0.298 n=6 |
| self-compiler - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 262,474 | 262,475 | +1 (+ 0.00%) | ~ | ~ | p=0.001 n=6 |
| Types | 107,135 | 107,134 | -1 (- 0.00%) | ~ | ~ | p=0.001 n=6 |
| Memory used | 441,708k (± 0.02%) | 441,704k (± 0.02%) | ~ | 441,508k | 441,785k | p=0.936 n=6 |
| Parse Time | 3.52s (± 0.73%) | 3.54s (± 0.68%) | ~ | 3.51s | 3.58s | p=0.258 n=6 |
| Bind Time | 1.32s (± 0.62%) | 1.33s (± 1.03%) | ~ | 1.32s | 1.36s | p=0.121 n=6 |
| Check Time | 18.85s (± 0.42%) | 18.85s (± 0.18%) | ~ | 18.80s | 18.88s | p=0.748 n=6 |
| Emit Time | 1.51s (± 0.68%) | 1.53s (± 0.79%) | ~ | 1.51s | 1.54s | p=0.084 n=6 |
| Total Time | 25.21s (± 0.33%) | 25.25s (± 0.21%) | ~ | 25.17s | 25.31s | p=0.199 n=6 |
| ts-pre-modules - node (v18.15.0, x64) | ||||||
| Errors | 71 | 71 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 225,327 | 225,327 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 94,288 | 94,288 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 371,169k (± 0.05%) | 371,138k (± 0.04%) | ~ | 371,021k | 371,434k | p=0.936 n=6 |
| Parse Time | 2.88s (± 0.96%) | 2.89s (± 0.40%) | ~ | 2.87s | 2.90s | p=0.250 n=6 |
| Bind Time | 1.61s (± 1.16%) | 1.60s (± 1.29%) | ~ | 1.58s | 1.64s | p=0.569 n=6 |
| Check Time | 16.35s (± 0.30%) | 16.34s (± 0.34%) | ~ | 16.25s | 16.39s | p=1.000 n=6 |
| Emit Time | 0.00s (±244.70%) | 0.00s | ~ | ~ | ~ | p=0.405 n=6 |
| Total Time | 20.84s (± 0.31%) | 20.84s (± 0.28%) | ~ | 20.72s | 20.88s | p=0.936 n=6 |
| vscode - node (v18.15.0, x64) | ||||||
| Errors | 33 | 33 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 3,479,209 | 3,479,209 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 1,170,466 | 1,170,466 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 3,528,055k (± 0.01%) | 3,528,186k (± 0.00%) | ~ | 3,527,993k | 3,528,449k | p=0.298 n=6 |
| Parse Time | 18.55s (± 0.37%) | 18.53s (± 0.52%) | ~ | 18.43s | 18.67s | p=0.689 n=6 |
| Bind Time | 5.97s (± 0.98%) | 5.96s (± 0.84%) | ~ | 5.89s | 6.04s | p=0.809 n=6 |
| Check Time | 115.77s (± 1.76%) | 114.06s (± 1.35%) | ~ | 113.04s | 117.14s | p=0.128 n=6 |
| Emit Time | 35.99s (± 2.04%) | 36.03s (± 2.17%) | ~ | 35.61s | 37.62s | p=0.936 n=6 |
| Total Time | 176.28s (± 1.42%) | 174.58s (± 1.00%) | ~ | 173.17s | 177.54s | p=0.173 n=6 |
| webpack - node (v18.15.0, x64) | ||||||
| Errors | 2 | 2 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 320,007 | 320,007 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 140,371 | 140,371 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 474,255k (± 0.03%) | 474,283k (± 0.03%) | ~ | 474,117k | 474,520k | p=1.000 n=6 |
| Parse Time | 4.33s (± 0.65%) | 4.34s (± 0.74%) | ~ | 4.28s | 4.36s | p=0.681 n=6 |
| Bind Time | 1.76s (± 1.47%) | 1.78s (± 1.39%) | ~ | 1.74s | 1.81s | p=0.465 n=6 |
| Check Time | 20.74s (± 0.41%) | 20.81s (± 0.53%) | ~ | 20.68s | 20.95s | p=0.575 n=6 |
| Emit Time | 0.00s | 0.00s | ~ | ~ | ~ | p=1.000 n=6 |
| Total Time | 26.84s (± 0.38%) | 26.92s (± 0.45%) | ~ | 26.73s | 27.06s | p=0.199 n=6 |
| xstate-main - node (v18.15.0, x64) | ||||||
| Errors | 30 | 30 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 667,374 | 667,374 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 198,751 | 198,751 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 570,111k (± 0.01%) | 570,135k (± 0.01%) | ~ | 570,058k | 570,284k | p=0.689 n=6 |
| Parse Time | 4.42s (± 0.65%) | 4.43s (± 0.82%) | ~ | 4.38s | 4.47s | p=0.687 n=6 |
| Bind Time | 1.32s (± 0.88%) | 1.33s (± 1.13%) | ~ | 1.31s | 1.35s | p=0.618 n=6 |
| Check Time | 20.46s (± 0.48%) | 20.44s (± 0.29%) | ~ | 20.38s | 20.53s | p=0.575 n=6 |
| Emit Time | 0.00s | 0.00s | ~ | ~ | ~ | p=1.000 n=6 |
| Total Time | 26.20s (± 0.37%) | 26.20s (± 0.38%) | ~ | 26.10s | 26.30s | p=1.000 n=6 |
System info unknown
Hosts
- node (v18.15.0, x64)
Scenarios
- Compiler-Unions - node (v18.15.0, x64)
- angular-1 - node (v18.15.0, x64)
- mui-docs - node (v18.15.0, x64)
- self-build-src - node (v18.15.0, x64)
- self-build-src-public-api - node (v18.15.0, x64)
- self-compiler - node (v18.15.0, x64)
- ts-pre-modules - node (v18.15.0, x64)
- vscode - node (v18.15.0, x64)
- webpack - node (v18.15.0, x64)
- xstate-main - node (v18.15.0, x64)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | pr | 6 |
| Baseline | baseline | 6 |