TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard
verified publisher icon microsoft

Fix the issue where modifying `extraFileExtensions` through `ProjectService.setHostConfiguration` in the plugin has no effect.

Open mlgq opened this issue 10 months ago • 1 comments

If the plugin is enabled before this.updateRootAndOptionsOfNonInferredProject and the project service host configuration is changed through projectService.setHostConfiguration in the plugin, enabling the plugin will result in a recursive call to loadConfiguredProject, then the outer loadConfiguredProject will finally call this.updateRootAndOptionsOfNonInferredProject with the parameters that before the plug-in was enabled.

Fixes #61302

mlgq avatar Feb 27 '25 10:02 mlgq

@microsoft-github-policy-service agree

mlgq avatar Feb 28 '25 10:02 mlgq

Given the short future of language service plugins in this particular architecture going forward, and the risk of breaking other plugins, I don't think we want to mess with this. This code is basically untestable (we have no idea what plugins in the wild are doing) and clearly works well enough for the plugins that are already out there.

RyanCavanaugh avatar Mar 28 '25 20:03 RyanCavanaugh

okay, understand. It can be resolved temporarily through proxy for now.

mlgq avatar Mar 29 '25 21:03 mlgq