TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

Add source mappings for serialized properties with available declaration

Open Andarist opened this issue 1 year ago • 10 comments

fixes https://github.com/microsoft/TypeScript/issues/60004

Andarist avatar Sep 19 '24 10:09 Andarist

Status?

Eigilak avatar May 14 '25 13:05 Eigilak

@Andarist @jakebailey is this progressing?

Jacse avatar Aug 19 '25 14:08 Jacse

sorry for tagging @Andarist, is this pr going to be merged?

mamlzy avatar Sep 09 '25 08:09 mamlzy

Is there any chance for this to be merged soon? This is blocking go-to navigation in monorepos, and degrades DX quite a bit.

prometx11 avatar Nov 18 '25 12:11 prometx11

This needs main merged into it, for one thing.

The other thing I'm wondering is how trivial this is to port over to the Go codebase, just to make sure that this sticks.

jakebailey avatar Nov 19 '25 22:11 jakebailey

Should there be an issue opened in the native repo to track this for the go port? We recently switched to go but would like for this to stick.

dbrxnds avatar Dec 06 '25 15:12 dbrxnds

@jakebailey I synced this with main. I also don't see any reason why this would be hard to port to the Go codebase. I could prepare a porting PR there but I don't know of the top of my head if you already have test infra there that would be able to test it.

Andarist avatar Dec 06 '25 17:12 Andarist

We have declaration map tests and go to def baselining, so theoretically it should all be there.

jakebailey avatar Dec 08 '25 23:12 jakebailey

But, I don't know what the equivalent to projectReferencesSourcemap.ts is in the Go codebase; maybe @sheetalkamat knows.

jakebailey avatar Dec 08 '25 23:12 jakebailey

you should be able to add fourslash test. https://github.com/microsoft/typescript-go/blob/main/internal/fourslash/tests/statedeclarationmaps_test.go

sheetalkamat avatar Dec 08 '25 23:12 sheetalkamat

...

RahimGuerfi avatar Dec 14 '25 21:12 RahimGuerfi