TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

[experiment] trying to short circuit relations in more places

Open jakebailey opened this issue 1 year ago • 3 comments

sorta kinda like #56072

jakebailey avatar Jul 01 '24 00:07 jakebailey

@typescript-bot perf test this faster

jakebailey avatar Jul 01 '24 00:07 jakebailey

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this faster ✅ Started 👀 Results

typescript-bot avatar Jul 01 '24 00:07 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 62,153 62,153 ~ ~ ~ p=1.000 n=6
Types 50,242 50,242 ~ ~ ~ p=1.000 n=6
Memory used 192,211k (± 0.09%) 192,845k (± 0.76%) ~ 192,169k 195,810k p=0.054 n=6
Parse Time 1.31s (± 0.75%) 1.30s (± 0.64%) ~ 1.29s 1.31s p=0.445 n=6
Bind Time 0.71s 0.71s ~ ~ ~ p=1.000 n=6
Check Time 9.45s (± 0.53%) 9.54s (± 0.58%) +0.09s (+ 0.99%) 9.46s 9.61s p=0.016 n=6
Emit Time 2.76s (± 0.79%) 2.76s (± 0.72%) ~ 2.73s 2.79s p=0.738 n=6
Total Time 14.22s (± 0.44%) 14.30s (± 0.46%) ~ 14.18s 14.37s p=0.147 n=6
angular-1 - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 944,114 944,114 ~ ~ ~ p=1.000 n=6
Types 407,050 407,050 ~ ~ ~ p=1.000 n=6
Memory used 1,218,366k (± 0.01%) 1,218,421k (± 0.00%) ~ 1,218,361k 1,218,475k p=0.128 n=6
Parse Time 6.67s (± 0.52%) 6.65s (± 0.62%) ~ 6.59s 6.71s p=0.571 n=6
Bind Time 1.87s (± 0.56%) 1.86s (± 0.44%) ~ 1.85s 1.87s p=0.865 n=6
Check Time 30.67s (± 0.30%) 30.70s (± 0.27%) ~ 30.62s 30.82s p=0.748 n=6
Emit Time 13.56s (± 0.51%) 13.55s (± 0.26%) ~ 13.50s 13.59s p=0.748 n=6
Total Time 52.76s (± 0.15%) 52.77s (± 0.10%) ~ 52.72s 52.87s p=0.810 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,132,924 2,132,924 ~ ~ ~ p=1.000 n=6
Types 926,423 926,423 ~ ~ ~ p=1.000 n=6
Memory used 2,115,145k (± 0.00%) 2,115,234k (± 0.00%) ~ 2,115,123k 2,115,389k p=0.128 n=6
Parse Time 6.65s (± 0.22%) 6.65s (± 0.16%) ~ 6.64s 6.67s p=1.000 n=6
Bind Time 2.34s (± 0.22%) 2.34s (± 0.35%) ~ 2.33s 2.35s p=0.929 n=6
Check Time 70.80s (± 0.47%) 70.74s (± 0.46%) ~ 70.23s 71.11s p=0.748 n=6
Emit Time 0.14s (± 2.95%) 0.14s ~ ~ ~ p=0.405 n=6
Total Time 79.93s (± 0.43%) 79.87s (± 0.41%) ~ 79.37s 80.24s p=0.689 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,225,260 1,225,269 +9 (+ 0.00%) ~ ~ p=0.001 n=6
Types 261,341 261,343 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,340,216k (± 0.05%) 2,340,634k (± 0.04%) ~ 2,339,229k 2,341,803k p=0.471 n=6
Parse Time 5.02s (± 0.51%) 5.00s (± 0.54%) ~ 4.97s 5.05s p=0.226 n=6
Bind Time 1.92s (± 1.01%) 1.91s (± 0.77%) ~ 1.89s 1.93s p=0.625 n=6
Check Time 34.14s (± 0.40%) 34.46s (± 0.47%) +0.32s (+ 0.93%) 34.21s 34.64s p=0.013 n=6
Emit Time 2.60s (± 4.49%) 2.62s (± 5.13%) ~ 2.53s 2.88s p=1.000 n=6
Total Time 43.72s (± 0.52%) 43.99s (± 0.55%) ~ 43.63s 44.31s p=0.093 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,225,260 1,225,269 +9 (+ 0.00%) ~ ~ p=0.001 n=6
Types 261,341 261,343 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,416,055k (± 0.04%) 2,416,576k (± 0.05%) ~ 2,415,233k 2,418,085k p=0.575 n=6
Parse Time 7.72s (± 0.61%) 7.71s (± 1.27%) ~ 7.58s 7.85s p=0.575 n=6
Bind Time 2.49s (± 1.12%) 2.52s (± 0.99%) ~ 2.49s 2.55s p=0.172 n=6
Check Time 50.18s (± 0.20%) 50.88s (± 0.88%) +0.70s (+ 1.39%) 50.32s 51.49s p=0.008 n=6
Emit Time 3.82s (± 2.20%) 3.91s (± 4.19%) ~ 3.73s 4.13s p=0.298 n=6
Total Time 64.23s (± 0.23%) 65.02s (± 1.00%) +0.78s (+ 1.22%) 64.28s 65.93s p=0.020 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 258,194 258,203 +9 (+ 0.00%) ~ ~ p=0.001 n=6
Types 104,737 104,739 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 427,467k (± 0.02%) 427,563k (± 0.01%) +95k (+ 0.02%) 427,497k 427,615k p=0.045 n=6
Parse Time 4.07s (± 0.55%) 4.08s (± 0.61%) ~ 4.05s 4.11s p=0.415 n=6
Bind Time 1.62s (± 1.49%) 1.63s (± 1.69%) ~ 1.58s 1.65s p=0.510 n=6
Check Time 21.97s (± 0.33%) 22.26s (± 0.61%) +0.29s (+ 1.32%) 22.12s 22.49s p=0.005 n=6
Emit Time 1.54s (± 0.68%) 1.55s (± 1.15%) ~ 1.53s 1.58s p=0.805 n=6
Total Time 29.21s (± 0.19%) 29.52s (± 0.39%) +0.32s (+ 1.08%) 29.42s 29.71s p=0.005 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 35 35 ~ ~ ~ p=1.000 n=6
Symbols 224,565 224,565 ~ ~ ~ p=1.000 n=6
Types 93,734 93,734 ~ ~ ~ p=1.000 n=6
Memory used 369,521k (± 0.04%) 369,536k (± 0.03%) ~ 369,405k 369,675k p=0.575 n=6
Parse Time 2.76s (± 0.53%) 2.75s (± 1.43%) ~ 2.69s 2.80s p=0.870 n=6
Bind Time 1.58s (± 1.09%) 1.57s (± 0.62%) ~ 1.56s 1.59s p=0.492 n=6
Check Time 15.43s (± 0.22%) 15.60s (± 0.27%) +0.17s (+ 1.12%) 15.53s 15.64s p=0.005 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 19.77s (± 0.15%) 19.93s (± 0.36%) +0.16s (+ 0.80%) 19.80s 20.02s p=0.008 n=6
vscode - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,879,835 2,879,835 ~ ~ ~ p=1.000 n=6
Types 975,372 975,372 ~ ~ ~ p=1.000 n=6
Memory used 3,042,586k (± 0.00%) 3,042,660k (± 0.00%) ~ 3,042,536k 3,042,760k p=0.173 n=6
Parse Time 13.67s (± 0.24%) 13.67s (± 0.30%) ~ 13.62s 13.72s p=0.808 n=6
Bind Time 4.24s (± 2.01%) 4.20s (± 0.19%) ~ 4.19s 4.21s p=0.682 n=6
Check Time 74.77s (± 2.14%) 74.04s (± 0.90%) ~ 73.59s 75.33s p=0.423 n=6
Emit Time 23.09s (± 7.16%) 23.71s (± 2.92%) ~ 22.54s 24.43s p=0.936 n=6
Total Time 115.76s (± 0.32%) 115.62s (± 0.21%) ~ 115.24s 115.97s p=0.471 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 267,117 267,117 ~ ~ ~ p=1.000 n=6
Types 108,775 108,775 ~ ~ ~ p=1.000 n=6
Memory used 411,647k (± 0.03%) 411,601k (± 0.01%) ~ 411,547k 411,676k p=0.471 n=6
Parse Time 3.83s (± 0.64%) 3.83s (± 0.51%) ~ 3.80s 3.86s p=0.687 n=6
Bind Time 1.70s (± 0.49%) 1.70s (± 0.71%) ~ 1.69s 1.72s p=1.000 n=6
Check Time 16.78s (± 0.32%) 16.77s (± 0.36%) ~ 16.68s 16.85s p=0.808 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 22.30s (± 0.27%) 22.30s (± 0.27%) ~ 22.20s 22.37s p=0.936 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 525,251 525,251 ~ ~ ~ p=1.000 n=6
Types 178,574 178,574 ~ ~ ~ p=1.000 n=6
Memory used 462,947k (± 0.06%) 462,698k (± 0.07%) ~ 462,360k 463,118k p=0.109 n=6
Parse Time 3.16s (± 0.83%) 3.16s (± 0.77%) ~ 3.13s 3.20s p=1.000 n=6
Bind Time 1.17s (± 0.54%) 1.17s ~ ~ ~ p=1.000 n=6
Check Time 17.91s (± 0.24%) 17.98s (± 0.40%) ~ 17.88s 18.08s p=0.065 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 22.24s (± 0.18%) 22.32s (± 0.32%) ~ 22.21s 22.41s p=0.077 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6
Developer Information:

Download Benchmarks

typescript-bot avatar Jul 01 '24 00:07 typescript-bot