TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

Use monocart for coverage reports, enable codecov

Open jakebailey opened this issue 1 year ago • 4 comments

This is an experimental addition to c8, but works really well.

The v8 HTML page it outputs can load checker.ts without batting an eye, and has sub-expression fidelity and can see uncovered elses:

image

image

jakebailey avatar Jun 13 '24 04:06 jakebailey

I'm going to revert the CI and codecov change until we can get faster runners to not double our CI time. The local thing is fine, though, so I'll leave that working. I'll also do a benchmark quick to see how the report collection changes.

jakebailey avatar Jun 18 '24 23:06 jakebailey

The new runner pool is fast enough to give us coverage without slowing down CI.

jakebailey avatar Jun 19 '24 21:06 jakebailey

Marked this PR as ready for review. Now that the CI perf is mitigated, should we just go ahead and enable codecov?

jakebailey avatar Jun 19 '24 22:06 jakebailey

~A caveat is that c8 with monocart takes ~4x longer to run than c8 alone~; reported https://github.com/cenfun/monocart-coverage-reports/issues/47 and the profile is somewhat promising for improving this.

Now just 2x slower.

jakebailey avatar Jun 26 '24 23:06 jakebailey