TypeScript
TypeScript copied to clipboard
move to code actions update and tests
Fixes #https://github.com/microsoft/TypeScript/issues/58387
as discussed in the sync, we added the additional check to implicit
and also mirrored the fixes from move to file
for move to new file
.
a lot of tests were added (if excessive we can delete), and fixes to move to new file
were added but also understand that move to new file
will likely be deprecated anyways eventually.
regarding changing: https://github.com/microsoft/TypeScript/blob/5c21b7fd93cc60b05d560f931fb8bb26d7972f76/tests/cases/fourslash/moveToNewFile_prologueDirectives4.ts#L8
since getApplicableRefactors
defaults to implicit
:
https://github.com/microsoft/TypeScript/blob/5c21b7fd93cc60b05d560f931fb8bb26d7972f76/src/harness/fourslashImpl.ts#L4454
the test was changed to have no refactorings (to match our proposed case).
regarding implicit
vs invoked
:
Check for implicit
to follow our idea for manual requested in vs code
vs. not manually requested in vs code
, but let me know if our logic here makes sense!
cc. @aiday-mar @mjbvz