TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

Allow signature help argument count to be equal to argument index

Open Andarist opened this issue 1 year ago • 4 comments

fixes the issue reported here https://github.com/microsoft/TypeScript/issues/58191#issuecomment-2054196481 a regression from https://github.com/microsoft/TypeScript/pull/56372 , not fixed by https://github.com/microsoft/TypeScript/pull/57637

Andarist avatar Apr 15 '24 20:04 Andarist

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

typescript-bot avatar Apr 15 '24 20:04 typescript-bot

@typescript-bot pack this

jakebailey avatar Apr 19 '24 21:04 jakebailey

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results

typescript-bot avatar Apr 19 '24 21:04 typescript-bot

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161380/artifacts?artifactName=tgz&fileId=BCF59F43A5EC9B506AB89789B11D216B6577E1C070792765F4BBC471CF9C056502&fileName=/typescript-5.5.0-insiders.20240419.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot avatar Apr 19 '24 22:04 typescript-bot