Include source node inferences in string literal completions deeper in arguments

Open Andarist opened this issue 2 years ago • 2 comments

this is an expansion of the approached used by https://github.com/microsoft/TypeScript/pull/54121

Oct 23 '23 09:10 Andarist

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Oct 23 '23 09:10 typescript-bot

@andrewbranch @sandersn is there anything blocking this from being merged? :)

Apr 28 '24 16:04 Andarist

The method and results seem decent. I don't really like the code organization -- although there may be a reason for it that I'm missing.

@sandersn I addressed this by moving the logic closer to services. I agree that the previous shape of the code wasn't the best - thanks for pointing it out 👍

Aug 29 '24 21:08 Andarist