TypeScript
TypeScript copied to clipboard
microsoft
Fix good lints given by eslint-plugin-unicorn
Not final; I'm not totally sure I want to add this dependency (it's kinda big).
Heya @jakebailey, I've started to run the faster perf test suite on this PR at b1d2b242c2e29e47e748ae1fadfbeb181f3f2ebd. You can monitor the build here.
Update: The results are in!
@jakebailey The results of the perf run you requested are in!
Here they are:
tsc
Comparison Report - baseline..pr| Metric | baseline | pr | Delta | Best | Worst | p-value |
|---|---|---|---|---|---|---|
| Angular - node (v18.15.0, x64) | ||||||
| Memory used | 295,640k (± 0.01%) | 295,643k (± 0.01%) | ~ | 295,618k | 295,687k | p=0.873 n=6 |
| Parse Time | 2.67s (± 0.21%) | 2.66s (± 0.19%) | ~ | 2.66s | 2.67s | p=0.640 n=6 |
| Bind Time | 0.84s (± 1.50%) | 0.84s (± 0.97%) | ~ | 0.83s | 0.85s | p=0.558 n=6 |
| Check Time | 8.17s (± 0.24%) | 8.19s (± 0.33%) | ~ | 8.14s | 8.21s | p=0.224 n=6 |
| Emit Time | 7.10s (± 0.29%) | 7.10s (± 0.15%) | ~ | 7.08s | 7.11s | p=0.510 n=6 |
| Total Time | 18.78s (± 0.15%) | 18.78s (± 0.18%) | ~ | 18.73s | 18.81s | p=1.000 n=6 |
| Compiler-Unions - node (v18.15.0, x64) | ||||||
| Memory used | 193,514k (± 1.56%) | 193,527k (± 1.55%) | ~ | 191,545k | 197,432k | p=0.936 n=6 |
| Parse Time | 1.36s (± 0.66%) | 1.36s (± 2.05%) | ~ | 1.31s | 1.39s | p=0.934 n=6 |
| Bind Time | 0.72s (± 0.00%) | 0.72s (± 0.00%) | ~ | 0.72s | 0.72s | p=1.000 n=6 |
| Check Time | 9.33s (± 0.40%) | 9.33s (± 0.19%) | ~ | 9.31s | 9.35s | p=0.807 n=6 |
| Emit Time | 2.62s (± 0.42%) | 2.63s (± 0.32%) | ~ | 2.62s | 2.64s | p=0.652 n=6 |
| Total Time | 14.03s (± 0.34%) | 14.04s (± 0.21%) | ~ | 14.00s | 14.09s | p=1.000 n=6 |
| Monaco - node (v18.15.0, x64) | ||||||
| Memory used | 347,457k (± 0.01%) | 347,468k (± 0.00%) | ~ | 347,459k | 347,476k | p=0.423 n=6 |
| Parse Time | 2.48s (± 0.59%) | 2.48s (± 0.54%) | ~ | 2.46s | 2.50s | p=0.681 n=6 |
| Bind Time | 0.93s (± 0.56%) | 0.92s (± 0.56%) | ~ | 0.92s | 0.93s | p=0.311 n=6 |
| Check Time | 6.95s (± 0.36%) | 6.94s (± 0.36%) | ~ | 6.91s | 6.97s | p=1.000 n=6 |
| Emit Time | 4.05s (± 0.40%) | 4.07s (± 0.37%) | +0.03s (+ 0.66%) | 4.06s | 4.10s | p=0.028 n=6 |
| Total Time | 14.40s (± 0.35%) | 14.43s (± 0.22%) | ~ | 14.39s | 14.48s | p=0.171 n=6 |
| TFS - node (v18.15.0, x64) | ||||||
| Memory used | 302,838k (± 0.00%) | 302,832k (± 0.01%) | ~ | 302,791k | 302,853k | p=0.810 n=6 |
| Parse Time | 2.01s (± 0.96%) | 2.03s (± 0.67%) | ~ | 2.01s | 2.04s | p=0.162 n=6 |
| Bind Time | 1.01s (± 1.02%) | 1.01s (± 1.16%) | ~ | 0.99s | 1.02s | p=0.799 n=6 |
| Check Time | 6.33s (± 0.35%) | 6.32s (± 0.18%) | ~ | 6.30s | 6.33s | p=0.411 n=6 |
| Emit Time | 3.60s (± 0.27%) | 3.59s (± 0.53%) | ~ | 3.56s | 3.61s | p=0.271 n=6 |
| Total Time | 12.95s (± 0.20%) | 12.95s (± 0.18%) | ~ | 12.92s | 12.98s | p=1.000 n=6 |
| material-ui - node (v18.15.0, x64) | ||||||
| Memory used | 511,317k (± 0.01%) | 511,305k (± 0.01%) | ~ | 511,266k | 511,345k | p=0.575 n=6 |
| Parse Time | 2.64s (± 0.74%) | 2.65s (± 0.85%) | ~ | 2.62s | 2.68s | p=1.000 n=6 |
| Bind Time | 0.99s (± 0.99%) | 0.99s (± 0.90%) | ~ | 0.98s | 1.00s | p=0.798 n=6 |
| Check Time | 17.23s (± 0.42%) | 17.25s (± 0.50%) | ~ | 17.15s | 17.38s | p=0.872 n=6 |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | ~ | 0.00s | 0.00s | p=1.000 n=6 |
| Total Time | 20.87s (± 0.39%) | 20.89s (± 0.37%) | ~ | 20.77s | 21.00s | p=0.518 n=6 |
| mui-docs - node (v18.15.0, x64) | ||||||
| Memory used | 1,695,953k (± 0.00%) | 1,695,936k (± 0.00%) | ~ | 1,695,866k | 1,696,000k | p=0.575 n=6 |
| Parse Time | 6.55s (± 0.26%) | 6.55s (± 0.37%) | ~ | 6.52s | 6.59s | p=0.567 n=6 |
| Bind Time | 2.35s (± 0.22%) | 2.28s (± 6.57%) | ~ | 1.98s | 2.36s | p=0.933 n=6 |
| Check Time | 55.27s (± 0.24%) | 55.31s (± 0.47%) | ~ | 55.01s | 55.70s | p=0.936 n=6 |
| Emit Time | 0.16s (± 0.00%) | 0.16s (± 0.00%) | ~ | 0.16s | 0.16s | p=1.000 n=6 |
| Total Time | 64.33s (± 0.21%) | 64.30s (± 0.42%) | ~ | 64.05s | 64.74s | p=0.471 n=6 |
| self-build-src - node (v18.15.0, x64) | ||||||
| Memory used | 2,413,467k (± 0.02%) | 2,413,737k (± 0.02%) | ~ | 2,413,257k | 2,414,345k | p=0.575 n=6 |
| Parse Time | 4.96s (± 1.00%) | 4.93s (± 0.93%) | ~ | 4.89s | 4.99s | p=0.378 n=6 |
| Bind Time | 1.89s (± 0.43%) | 1.90s (± 0.27%) | +0.01s (+ 0.53%) | 1.89s | 1.90s | p=0.022 n=6 |
| Check Time | 33.48s (± 0.31%) | 33.49s (± 0.30%) | ~ | 33.32s | 33.57s | p=0.575 n=6 |
| Emit Time | 2.69s (± 1.92%) | 2.74s (± 1.21%) | ~ | 2.69s | 2.79s | p=0.128 n=6 |
| Total Time | 43.05s (± 0.41%) | 43.07s (± 0.26%) | ~ | 42.88s | 43.19s | p=0.810 n=6 |
| self-compiler - node (v18.15.0, x64) | ||||||
| Memory used | 419,707k (± 0.01%) | 419,670k (± 0.01%) | ~ | 419,653k | 419,711k | p=0.093 n=6 |
| Parse Time | 2.82s (± 2.56%) | 2.67s (± 0.56%) | 🟩-0.16s (- 5.55%) | 2.65s | 2.69s | p=0.010 n=6 |
| Bind Time | 1.10s (± 5.63%) | 1.24s (± 0.79%) | 🔻+0.13s (+12.24%) | 1.23s | 1.25s | p=0.008 n=6 |
| Check Time | 15.11s (± 0.23%) | 15.12s (± 0.37%) | ~ | 15.03s | 15.18s | p=0.687 n=6 |
| Emit Time | 1.16s (± 1.62%) | 1.15s (± 0.00%) | ~ | 1.15s | 1.15s | p=0.655 n=6 |
| Total Time | 20.18s (± 0.16%) | 20.17s (± 0.24%) | ~ | 20.12s | 20.23s | p=0.573 n=6 |
| vscode - node (v18.15.0, x64) | ||||||
| Memory used | 2,807,343k (± 0.00%) | 2,807,300k (± 0.00%) | ~ | 2,807,204k | 2,807,383k | p=0.378 n=6 |
| Parse Time | 10.62s (± 0.29%) | 10.62s (± 0.32%) | ~ | 10.57s | 10.65s | p=1.000 n=6 |
| Bind Time | 3.39s (± 0.31%) | 3.38s (± 0.93%) | ~ | 3.36s | 3.44s | p=0.254 n=6 |
| Check Time | 59.63s (± 0.15%) | 59.71s (± 0.75%) | ~ | 59.14s | 60.28s | p=0.936 n=6 |
| Emit Time | 16.14s (± 0.41%) | 16.13s (± 0.67%) | ~ | 15.96s | 16.22s | p=0.936 n=6 |
| Total Time | 89.77s (± 0.16%) | 89.83s (± 0.44%) | ~ | 89.34s | 90.40s | p=0.810 n=6 |
| webpack - node (v18.15.0, x64) | ||||||
| Memory used | 392,322k (± 0.01%) | 392,434k (± 0.03%) | +112k (+ 0.03%) | 392,327k | 392,657k | p=0.030 n=6 |
| Parse Time | 3.05s (± 0.76%) | 3.05s (± 1.22%) | ~ | 3.01s | 3.10s | p=0.872 n=6 |
| Bind Time | 1.41s (± 0.58%) | 1.40s (± 0.97%) | ~ | 1.38s | 1.42s | p=0.865 n=6 |
| Check Time | 13.96s (± 0.08%) | 13.97s (± 0.30%) | ~ | 13.91s | 14.01s | p=0.377 n=6 |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | ~ | 0.00s | 0.00s | p=1.000 n=6 |
| Total Time | 18.41s (± 0.13%) | 18.43s (± 0.28%) | ~ | 18.35s | 18.50s | p=0.296 n=6 |
| xstate - node (v18.15.0, x64) | ||||||
| Memory used | 513,454k (± 0.02%) | 513,408k (± 0.01%) | ~ | 513,330k | 513,440k | p=0.199 n=6 |
| Parse Time | 3.29s (± 0.32%) | 3.29s (± 0.17%) | ~ | 3.28s | 3.29s | p=1.000 n=6 |
| Bind Time | 1.54s (± 0.35%) | 1.54s (± 0.33%) | ~ | 1.54s | 1.55s | p=0.640 n=6 |
| Check Time | 2.86s (± 0.49%) | 2.85s (± 0.76%) | ~ | 2.82s | 2.88s | p=0.746 n=6 |
| Emit Time | 0.08s (± 0.00%) | 0.08s (± 0.00%) | ~ | 0.08s | 0.08s | p=1.000 n=6 |
| Total Time | 7.77s (± 0.21%) | 7.76s (± 0.23%) | ~ | 7.73s | 7.78s | p=0.745 n=6 |
System info unknown
Hosts
- node (v18.15.0, x64)
Scenarios
- Angular - node (v18.15.0, x64)
- Compiler-Unions - node (v18.15.0, x64)
- Monaco - node (v18.15.0, x64)
- TFS - node (v18.15.0, x64)
- material-ui - node (v18.15.0, x64)
- mui-docs - node (v18.15.0, x64)
- self-build-src - node (v18.15.0, x64)
- self-compiler - node (v18.15.0, x64)
- vscode - node (v18.15.0, x64)
- webpack - node (v18.15.0, x64)
- xstate - node (v18.15.0, x64)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | pr | 6 |
| Baseline | baseline | 6 |