TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard
verified publisher icon microsoft

Remove missing type from tuple type arguments under `exactOptionalPropertyTypes`

Open Andarist opened this issue 2 years ago • 13 comments

fixes https://github.com/microsoft/TypeScript/issues/54302

Andarist avatar Jun 20 '23 20:06 Andarist

@typescript-bot test this @typescript-bot test top100 @typescript-bot user test this @typescript-bot run dt @typescript-bot perf test this faster @typescript-bot pack this

jakebailey avatar Jun 30 '23 17:06 jakebailey

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 1f43c8d1baa88d7cb9a67326971c2656efc006b2. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Jun 30 '23 17:06 typescript-bot

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 1f43c8d1baa88d7cb9a67326971c2656efc006b2. You can monitor the build here.

typescript-bot avatar Jun 30 '23 17:06 typescript-bot

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 1f43c8d1baa88d7cb9a67326971c2656efc006b2. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Jun 30 '23 17:06 typescript-bot

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 1f43c8d1baa88d7cb9a67326971c2656efc006b2. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Jun 30 '23 17:06 typescript-bot

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 1f43c8d1baa88d7cb9a67326971c2656efc006b2. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Jun 30 '23 17:06 typescript-bot

Heya @jakebailey, I've started to run the extended test suite on this PR at 1f43c8d1baa88d7cb9a67326971c2656efc006b2. You can monitor the build here.

typescript-bot avatar Jun 30 '23 17:06 typescript-bot

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155762/artifacts?artifactName=tgz&fileId=0F1688874932DAB1C886AE27B93E66A560200FFA41E8495C6C25360F089A781A02&fileName=/typescript-5.2.0-insiders.20230630.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot avatar Jun 30 '23 17:06 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54718

Metric main 54718 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 366,137k (± 0.00%) 366,157k (± 0.01%) ~ 366,129k 366,197k p=0.128 n=6
Parse Time 3.58s (± 0.21%) 3.60s (± 0.32%) +0.02s (+ 0.47%) 3.59s 3.62s p=0.015 n=6
Bind Time 1.18s (± 0.64%) 1.18s (± 0.00%) ~ 1.18s 1.18s p=0.598 n=6
Check Time 9.67s (± 0.57%) 9.67s (± 0.37%) ~ 9.61s 9.71s p=0.520 n=6
Emit Time 8.00s (± 0.48%) 7.99s (± 0.61%) ~ 7.92s 8.05s p=0.747 n=6
Total Time 22.43s (± 0.27%) 22.44s (± 0.29%) ~ 22.36s 22.52s p=0.872 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,891k (± 0.03%) 193,373k (± 0.69%) ~ 192,728k 196,091k p=0.575 n=6
Parse Time 1.58s (± 1.63%) 1.59s (± 0.76%) ~ 1.58s 1.61s p=0.622 n=6
Bind Time 0.82s (± 0.77%) 0.82s (± 1.09%) ~ 0.81s 0.83s p=1.000 n=6
Check Time 10.15s (± 0.41%) 10.11s (± 0.65%) ~ 10.01s 10.18s p=0.332 n=6
Emit Time 3.02s (± 0.86%) 3.04s (± 1.33%) ~ 2.98s 3.09s p=0.416 n=6
Total Time 15.57s (± 0.34%) 15.56s (± 0.75%) ~ 15.44s 15.71s p=1.000 n=6
Monaco - node (v16.17.1, x64)
Memory used 346,115k (± 0.01%) 346,125k (± 0.01%) ~ 346,088k 346,148k p=0.471 n=6
Parse Time 2.73s (± 0.79%) 2.74s (± 0.67%) ~ 2.72s 2.76s p=0.681 n=6
Bind Time 1.08s (± 0.77%) 1.08s (± 1.08%) ~ 1.07s 1.10s p=0.555 n=6
Check Time 8.01s (± 0.58%) 7.98s (± 0.38%) ~ 7.93s 8.02s p=0.227 n=6
Emit Time 4.51s (± 1.39%) 4.48s (± 0.64%) ~ 4.45s 4.53s p=0.226 n=6
Total Time 16.34s (± 0.71%) 16.28s (± 0.33%) ~ 16.24s 16.38s p=0.422 n=6
TFS - node (v16.17.1, x64)
Memory used 300,218k (± 0.00%) 300,206k (± 0.01%) ~ 300,175k 300,234k p=0.470 n=6
Parse Time 2.16s (± 0.56%) 2.17s (± 0.75%) ~ 2.15s 2.19s p=0.288 n=6
Bind Time 1.23s (± 0.85%) 1.24s (± 0.98%) ~ 1.22s 1.25s p=0.868 n=6
Check Time 7.32s (± 0.24%) 7.33s (± 0.45%) ~ 7.29s 7.38s p=0.332 n=6
Emit Time 4.35s (± 0.66%) 4.31s (± 0.46%) ~ 4.29s 4.33s p=0.062 n=6
Total Time 15.07s (± 0.33%) 15.06s (± 0.39%) ~ 14.99s 15.14s p=0.809 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,659k (± 0.01%) 481,681k (± 0.02%) ~ 481,612k 481,830k p=0.810 n=6
Parse Time 3.26s (± 0.36%) 3.26s (± 0.60%) ~ 3.24s 3.30s p=0.868 n=6
Bind Time 0.95s (± 0.57%) 0.95s (± 0.43%) ~ 0.94s 0.95s p=0.054 n=6
Check Time 18.39s (± 0.61%) 18.45s (± 0.87%) ~ 18.19s 18.61s p=0.423 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.61s (± 0.50%) 22.66s (± 0.75%) ~ 22.40s 22.82s p=0.471 n=6
xstate - node (v16.17.1, x64)
Memory used 561,157k (± 0.01%) 561,162k (± 0.02%) ~ 561,060k 561,362k p=1.000 n=6
Parse Time 4.01s (± 0.32%) 4.01s (± 0.33%) ~ 3.99s 4.03s p=1.000 n=6
Bind Time 1.74s (± 1.03%) 1.73s (± 0.47%) ~ 1.72s 1.74s p=0.208 n=6
Check Time 3.06s (± 0.45%) 3.05s (± 0.53%) ~ 3.04s 3.08s p=0.279 n=6
Emit Time 0.09s (± 5.53%) 0.09s (± 5.53%) ~ 0.09s 0.10s p=1.000 n=6
Total Time 8.91s (± 0.31%) 8.88s (± 0.29%) ~ 8.85s 8.91s p=0.123 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 54718 6
Baseline main 6
Developer Information:

Download Benchmark

typescript-bot avatar Jun 30 '23 17:06 typescript-bot

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/54718/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"
  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

  • [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54718/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot avatar Jun 30 '23 17:06 typescript-bot

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/54718/merge:

Everything looks good!

typescript-bot avatar Jun 30 '23 18:06 typescript-bot

Hey @jakebailey, the results of running the DT tests are ready. Everything looks the same! You can check the log here.

typescript-bot avatar Jun 30 '23 19:06 typescript-bot

I managed to clean some things further. Personally, I like the changes - some bits feel simpler to me now. Let me know what do you think.

Andarist avatar Sep 03 '23 08:09 Andarist