TypeScript Add nested call and new expressions as potential intra expression inference sites

Sometimes nested generic functions are skipped during inference in the first pass: https://github.dev/microsoft/TypeScript/blob/04d4580f4eedc036b014ef4329cffe9979da3af9/src/compiler/checker.ts#L33619-L33634

However, those calls are resolved from within checkExpressionWithContextualType and by the time we have a chance to call addIntraExpressionInferenceSite they are already resolved. So it, imho, makes sense to actually use them as intra expression inference sites.

fixes https://github.com/microsoft/TypeScript/issues/54184 fixes https://github.com/microsoft/TypeScript/issues/52114 fixes https://github.com/microsoft/TypeScript/issues/53776

May 08 '23 14:05 Andarist

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

May 08 '23 14:05 typescript-bot

@typescript-bot test this @typescript-bot run dt @typescript-bot test top100 @typescript-bot perf test this

May 24 '23 17:05 weswigham

Heya @weswigham, I've started to run the perf test suite on this PR at bcb0da5dc4eb43369b47e20d48929c82fac52aaf. You can monitor the build here.

Update: The results are in!

May 24 '23 17:05 typescript-bot

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at bcb0da5dc4eb43369b47e20d48929c82fac52aaf. You can monitor the build here.

Update: The results are in!

May 24 '23 17:05 typescript-bot

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at bcb0da5dc4eb43369b47e20d48929c82fac52aaf. You can monitor the build here.

Update: The results are in!

May 24 '23 17:05 typescript-bot

Heya @weswigham, I've started to run the extended test suite on this PR at bcb0da5dc4eb43369b47e20d48929c82fac52aaf. You can monitor the build here.

May 24 '23 17:05 typescript-bot

Heya @weswigham, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

May 24 '23 17:05 typescript-bot

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/54183/merge:

Everything looks good!

May 24 '23 19:05 typescript-bot

Hey @weswigham, the results of running the DT tests are ready. Everything looks the same! You can check the log here.

May 24 '23 19:05 typescript-bot

only change I think I'd want is a deprecated isContextSensitive in the public API (which can just call the new function), so this isn't a hard API break.

is this relevant for a function that is annotated with /** @internal */?

May 24 '23 19:05 Andarist

@weswigham The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54183

_Metric	_main	₅₄₁₈₃	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{365,796k (± 0.01%)}	_{365,968k (± 0.00%)}	_{+172k (+ 0.05%)}	_365,947k	_365,988k	_{p=0.005 n=6}
_{Parse Time}	_{3.43s (± 0.57%)}	_{3.41s (± 0.70%)}	_~	_3.37s	_3.43s	_{p=0.286 n=6}
_{Bind Time}	_{1.11s (± 0.73%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.929 n=6}
_{Check Time}	_{8.74s (± 0.30%)}	_{8.74s (± 0.33%)}	_~	_8.70s	_8.78s	_{p=0.629 n=6}
_{Emit Time}	_{7.44s (± 0.24%)}	_{7.43s (± 0.45%)}	_~	_7.38s	_7.47s	_{p=0.934 n=6}
_{Total Time}	_{20.73s (± 0.21%)}	_{20.69s (± 0.29%)}	_~	_20.61s	_20.76s	_{p=0.336 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{193,058k (± 1.50%)}	_{192,000k (± 1.24%)}	_~	_190,998k	_196,871k	_{p=0.066 n=6}
_{Parse Time}	_{1.50s (± 1.40%)}	_{1.50s (± 1.15%)}	_~	_1.47s	_1.52s	_{p=0.807 n=6}
_{Bind Time}	_{0.77s (± 0.00%)}	_{0.77s (± 0.00%)}	_~	_0.77s	_0.77s	_{p=1.000 n=6}
_{Check Time}	_{9.49s (± 0.42%)}	_{9.63s (± 0.44%)}	_{+0.14s (+ 1.47%)}	_9.59s	_9.69s	_{p=0.005 n=6}
_{Emit Time}	_{2.73s (± 0.64%)}	_{2.75s (± 0.84%)}	_~	_2.72s	_2.78s	_{p=0.225 n=6}
_{Total Time}	_{14.50s (± 0.42%)}	_{14.65s (± 0.26%)}	_{+0.15s (+ 1.03%)}	_14.59s	_14.70s	_{p=0.006 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,604k (± 0.01%)}	_{346,562k (± 0.00%)}	_{-42k (- 0.01%)}	_346,550k	_346,576k	_{p=0.013 n=6}
_{Parse Time}	_{2.60s (± 1.41%)}	_{2.58s (± 1.26%)}	_~	_2.54s	_2.63s	_{p=0.464 n=6}
_{Bind Time}	_{1.00s (± 0.81%)}	_{1.01s (± 0.83%)}	_~	_1.00s	_1.02s	_{p=0.673 n=6}
_{Check Time}	_{7.14s (± 0.43%)}	_{7.18s (± 0.26%)}	_~	_7.16s	_7.21s	_{p=0.086 n=6}
_{Emit Time}	_{4.25s (± 0.33%)}	_{4.26s (± 1.02%)}	_~	_4.21s	_4.32s	_{p=0.808 n=6}
_{Total Time}	_{14.99s (± 0.20%)}	_{15.02s (± 0.49%)}	_~	_14.93s	_15.13s	_{p=0.630 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,604k (± 0.00%)}	_{300,763k (± 0.01%)}	_{+159k (+ 0.05%)}	_300,735k	_300,794k	_{p=0.005 n=6}
_{Parse Time}	_{2.06s (± 1.12%)}	_{2.06s (± 1.05%)}	_~	_2.02s	_2.08s	_{p=0.788 n=6}
_{Bind Time}	_{1.14s (± 0.73%)}	_{1.14s (± 0.86%)}	_~	_1.12s	_1.15s	_{p=0.340 n=6}
_{Check Time}	_{6.62s (± 0.74%)}	_{6.63s (± 0.66%)}	_~	_6.56s	_6.69s	_{p=0.872 n=6}
_{Emit Time}	_{3.87s (± 0.93%)}	_{3.88s (± 0.53%)}	_~	_3.85s	_3.91s	_{p=0.421 n=6}
_{Total Time}	_{13.70s (± 0.40%)}	_{13.72s (± 0.40%)}	_~	_13.65s	_13.78s	_{p=0.376 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{481,752k (± 0.01%)}	_{482,344k (± 0.01%)}	_{+592k (+ 0.12%)}	_482,285k	_482,377k	_{p=0.005 n=6}
_{Parse Time}	_{3.10s (± 0.44%)}	_{3.12s (± 0.72%)}	_~	_3.10s	_3.16s	_{p=0.101 n=6}
_{Bind Time}	_{0.92s (± 1.66%)}	_{0.91s (± 0.56%)}	_~	_0.91s	_0.92s	_{p=1.000 n=6}
_{Check Time}	_{16.78s (± 0.41%)}	_{16.95s (± 0.56%)}	_{+0.17s (+ 1.02%)}	_16.83s	_17.07s	_{p=0.010 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.80s (± 0.39%)}	_{20.99s (± 0.47%)}	_{+0.19s (+ 0.89%)}	_20.85s	_21.12s	_{p=0.013 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{563,021k (± 0.02%)}	_{562,733k (± 0.02%)}	_{-289k (- 0.05%)}	_562,621k	_562,918k	_{p=0.008 n=6}
_{Parse Time}	_{3.82s (± 0.46%)}	_{3.85s (± 0.67%)}	_~	_3.81s	_3.87s	_{p=0.106 n=6}
_{Bind Time}	_{1.63s (± 0.63%)}	_{1.63s (± 0.34%)}	_~	_1.62s	_1.63s	_{p=0.663 n=6}
_{Check Time}	_{2.82s (± 0.77%)}	_{2.82s (± 0.85%)}	_~	_2.80s	_2.86s	_{p=0.936 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.35s (± 0.40%)}	_{8.37s (± 0.58%)}	_~	_8.32s	_8.44s	_{p=0.520 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,269k (± 0.00%)}	_{365,327k (± 0.01%)}	_~	_365,247k	_365,377k	_{p=0.066 n=6}
_{Parse Time}	_{3.58s (± 0.73%)}	_{3.54s (± 0.55%)}	_{-0.04s (- 1.07%)}	_3.52s	_3.57s	_{p=0.030 n=6}
_{Bind Time}	_{1.19s (± 0.69%)}	_{1.17s (± 0.44%)}	_{-0.01s (- 1.12%)}	_1.17s	_1.18s	_{p=0.014 n=6}
_{Check Time}	_{9.61s (± 0.31%)}	_{9.58s (± 0.39%)}	_~	_9.53s	_9.63s	_{p=0.199 n=6}
_{Emit Time}	_{7.99s (± 0.82%)}	_{7.92s (± 0.58%)}	_{-0.07s (- 0.94%)}	_7.87s	_8.00s	_{p=0.044 n=6}
_{Total Time}	_{22.36s (± 0.21%)}	_{22.21s (± 0.42%)}	_{-0.16s (- 0.69%)}	_22.10s	_22.37s	_{p=0.016 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,883k (± 0.03%)}	_{193,224k (± 0.53%)}	_~	_192,742k	_195,332k	_{p=0.230 n=6}
_{Parse Time}	_{1.59s (± 0.76%)}	_{1.59s (± 1.52%)}	_~	_1.55s	_1.62s	_{p=0.744 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.282 n=6}
_{Check Time}	_{10.25s (± 0.53%)}	_{10.31s (± 0.29%)}	_~	_10.26s	_10.34s	_{p=0.053 n=6}
_{Emit Time}	_{3.00s (± 0.70%)}	_{3.05s (± 1.46%)}	_{+0.05s (+ 1.72%)}	_3.01s	_3.13s	_{p=0.030 n=6}
_{Total Time}	_{15.67s (± 0.40%)}	_{15.78s (± 0.35%)}	_{+0.12s (+ 0.73%)}	_15.68s	_15.83s	_{p=0.020 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,874k (± 0.00%)}	_{345,862k (± 0.00%)}	_~	_345,854k	_345,870k	_{p=0.297 n=6}
_{Parse Time}	_{2.73s (± 0.38%)}	_{2.72s (± 0.28%)}	_{-0.01s (- 0.49%)}	_2.71s	_2.73s	_{p=0.046 n=6}
_{Bind Time}	_{1.09s (± 0.75%)}	_{1.09s (± 0.00%)}	_~	_1.09s	_1.09s	_{p=0.290 n=6}
_{Check Time}	_{7.83s (± 0.33%)}	_{7.90s (± 0.37%)}	_{+0.07s (+ 0.89%)}	_7.86s	_7.94s	_{p=0.008 n=6}
_{Emit Time}	_{4.46s (± 1.15%)}	_{4.50s (± 0.81%)}	_~	_4.45s	_4.54s	_{p=0.198 n=6}
_{Total Time}	_{16.11s (± 0.45%)}	_{16.21s (± 0.36%)}	_{+0.10s (+ 0.64%)}	_16.14s	_16.29s	_{p=0.037 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,938k (± 0.01%)}	_{300,109k (± 0.00%)}	_{+171k (+ 0.06%)}	_300,097k	_300,131k	_{p=0.005 n=6}
_{Parse Time}	_{2.16s (± 0.48%)}	_{2.16s (± 0.59%)}	_~	_2.14s	_2.17s	_{p=0.868 n=6}
_{Bind Time}	_{1.24s (± 0.99%)}	_{1.24s (± 0.61%)}	_~	_1.23s	_1.25s	_{p=0.388 n=6}
_{Check Time}	_{7.26s (± 0.46%)}	_{7.32s (± 0.37%)}	_{+0.05s (+ 0.71%)}	_7.28s	_7.35s	_{p=0.020 n=6}
_{Emit Time}	_{4.33s (± 0.66%)}	_{4.40s (± 0.44%)}	_{+0.07s (+ 1.54%)}	_4.38s	_4.43s	_{p=0.005 n=6}
_{Total Time}	_{15.00s (± 0.40%)}	_{15.11s (± 0.20%)}	_{+0.12s (+ 0.78%)}	_15.06s	_15.15s	_{p=0.005 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{480,973k (± 0.01%)}	_{481,627k (± 0.01%)}	_{+653k (+ 0.14%)}	_481,560k	_481,705k	_{p=0.005 n=6}
_{Parse Time}	_{3.28s (± 1.34%)}	_{3.24s (± 0.28%)}	_~	_3.23s	_3.25s	_{p=0.061 n=6}
_{Bind Time}	_{0.95s (± 1.59%)}	_{0.94s (± 0.55%)}	_~	_0.93s	_0.94s	_{p=0.242 n=6}
_{Check Time}	_{18.03s (± 1.20%)}	_{17.95s (± 0.79%)}	_~	_17.78s	_18.17s	_{p=0.575 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.25s (± 0.99%)}	_{22.13s (± 0.66%)}	_~	_21.95s	_22.36s	_{p=0.336 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,656k (± 0.01%)}	_{560,513k (± 0.03%)}	_~	_560,321k	_560,822k	_{p=0.066 n=6}
_{Parse Time}	_{4.00s (± 0.41%)}	_{4.00s (± 0.21%)}	_~	_3.99s	_4.01s	_{p=0.731 n=6}
_{Bind Time}	_{1.77s (± 0.50%)}	_{1.76s (± 0.36%)}	_~	_1.75s	_1.77s	_{p=0.070 n=6}
_{Check Time}	_{3.06s (± 0.56%)}	_{3.06s (± 0.68%)}	_~	_3.03s	_3.09s	_{p=0.809 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.92s (± 0.36%)}	_{8.92s (± 0.28%)}	_~	_8.87s	_8.94s	_{p=0.746 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{359,205k (± 0.01%)}	_{359,413k (± 0.00%)}	_{+208k (+ 0.06%)}	_359,385k	_359,435k	_{p=0.005 n=6}
_{Parse Time}	_{3.68s (± 0.63%)}	_{3.67s (± 0.28%)}	_~	_3.65s	_3.68s	_{p=0.220 n=6}
_{Bind Time}	_{1.22s (± 0.42%)}	_{1.22s (± 0.42%)}	_~	_1.21s	_1.22s	_{p=1.000 n=6}
_{Check Time}	_{10.01s (± 0.79%)}	_{10.05s (± 0.49%)}	_~	_9.99s	_10.11s	_{p=0.336 n=6}
_{Emit Time}	_{8.33s (± 0.94%)}	_{8.30s (± 0.87%)}	_~	_8.23s	_8.40s	_{p=0.574 n=6}
_{Total Time}	_{23.24s (± 0.68%)}	_{23.23s (± 0.46%)}	_~	_23.12s	_23.40s	_{p=0.810 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{188,287k (± 0.01%)}	_{188,145k (± 0.01%)}	_{-143k (- 0.08%)}	_188,114k	_188,164k	_{p=0.005 n=6}
_{Parse Time}	_{1.62s (± 0.72%)}	_{1.61s (± 1.11%)}	_~	_1.59s	_1.64s	_{p=0.192 n=6}
_{Bind Time}	_{0.85s (± 0.74%)}	_{0.85s (± 0.89%)}	_~	_0.84s	_0.86s	_{p=0.718 n=6}
_{Check Time}	_{10.30s (± 0.70%)}	_{10.42s (± 0.64%)}	_{+0.11s (+ 1.08%)}	_10.34s	_10.53s	_{p=0.036 n=6}
_{Emit Time}	_{3.13s (± 0.90%)}	_{3.16s (± 0.87%)}	_~	_3.13s	_3.21s	_{p=0.192 n=6}
_{Total Time}	_{15.91s (± 0.54%)}	_{16.04s (± 0.39%)}	_{+0.12s (+ 0.76%)}	_15.93s	_16.11s	_{p=0.019 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{341,023k (± 0.00%)}	_{340,935k (± 0.00%)}	_{-88k (- 0.03%)}	_340,914k	_340,954k	_{p=0.005 n=6}
_{Parse Time}	_{2.82s (± 0.72%)}	_{2.79s (± 0.37%)}	_{-0.03s (- 0.95%)}	_2.78s	_2.81s	_{p=0.014 n=6}
_{Bind Time}	_{1.11s (± 0.80%)}	_{1.11s (± 0.57%)}	_~	_1.10s	_1.12s	_{p=1.000 n=6}
_{Check Time}	_{8.15s (± 0.59%)}	_{8.18s (± 0.36%)}	_~	_8.15s	_8.23s	_{p=0.146 n=6}
_{Emit Time}	_{4.67s (± 1.09%)}	_{4.73s (± 0.80%)}	_~	_4.70s	_4.80s	_{p=0.052 n=6}
_{Total Time}	_{16.75s (± 0.51%)}	_{16.82s (± 0.32%)}	_~	_16.75s	_16.90s	_{p=0.108 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{295,139k (± 0.00%)}	_{295,288k (± 0.00%)}	_{+149k (+ 0.05%)}	_295,273k	_295,305k	_{p=0.005 n=6}
_{Parse Time}	_{2.41s (± 0.61%)}	_{2.40s (± 0.61%)}	_~	_2.39s	_2.42s	_{p=0.408 n=6}
_{Bind Time}	_{1.06s (± 0.38%)}	_{1.07s (± 0.38%)}	_{+0.01s (+ 0.63%)}	_1.06s	_1.07s	_{p=0.034 n=6}
_{Check Time}	_{7.59s (± 0.34%)}	_{7.59s (± 0.55%)}	_~	_7.55s	_7.66s	_{p=1.000 n=6}
_{Emit Time}	_{4.30s (± 0.55%)}	_{4.34s (± 0.82%)}	_{+0.04s (+ 0.97%)}	_4.31s	_4.41s	_{p=0.036 n=6}
_{Total Time}	_{15.36s (± 0.28%)}	_{15.40s (± 0.31%)}	_~	_15.33s	_15.45s	_{p=0.109 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{476,562k (± 0.01%)}	_{477,199k (± 0.01%)}	_{+637k (+ 0.13%)}	_477,164k	_477,247k	_{p=0.005 n=6}
_{Parse Time}	_{3.33s (± 0.45%)}	_{3.32s (± 0.52%)}	_~	_3.30s	_3.35s	_{p=0.191 n=6}
_{Bind Time}	_{1.01s (± 0.81%)}	_{1.00s (± 0.75%)}	_~	_0.99s	_1.01s	_{p=0.383 n=6}
_{Check Time}	_{18.74s (± 0.70%)}	_{18.77s (± 0.63%)}	_~	_18.65s	_18.97s	_{p=0.630 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.08s (± 0.60%)}	_{23.09s (± 0.59%)}	_~	_22.97s	_23.34s	_{p=1.000 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{549,594k (± 0.00%)}	_{549,362k (± 0.00%)}	_{-232k (- 0.04%)}	_549,345k	_549,376k	_{p=0.005 n=6}
_{Parse Time}	_{4.29s (± 0.96%)}	_{4.22s (± 0.43%)}	_{-0.07s (- 1.67%)}	_4.19s	_4.24s	_{p=0.005 n=6}
_{Bind Time}	_{1.65s (± 3.72%)}	_{1.66s (± 2.01%)}	_~	_1.59s	_1.68s	_{p=0.412 n=6}
_{Check Time}	_{3.17s (± 0.78%)}	_{3.17s (± 0.52%)}	_~	_3.16s	_3.20s	_{p=0.936 n=6}
_{Emit Time}	_{0.09s (± 5.53%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=0.174 n=6}
_{Total Time}	_{9.21s (± 0.39%)}	_{9.14s (± 0.47%)}	_{-0.07s (- 0.72%)}	_9.06s	_9.19s	_{p=0.012 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₁₈₃	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..54183

_Metric	_main	₅₄₁₈₃	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,542ms (± 0.52%)}	_{2,546ms (± 0.81%)}	_~	_2,528ms	_2,583ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{5,557ms (± 0.81%)}	_{5,638ms (± 1.39%)}	_~	_5,491ms	_5,706ms	_{p=0.066 n=6}
_{Req 3 - references}	_{337ms (± 1.59%)}	_{341ms (± 0.73%)}	_~	_336ms	_343ms	_{p=0.127 n=6}
_{Req 4 - navto}	_{290ms (± 1.21%)}	_{284ms (± 1.00%)}	_{-5ms (- 1.84%)}	_283ms	_290ms	_{p=0.030 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 1.05%)}	_{83ms (± 5.12%)}	_~	_74ms	_85ms	_{p=0.114 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,664ms (± 0.60%)}	_{2,638ms (± 0.69%)}	_~	_2,602ms	_2,655ms	_{p=0.054 n=6}
_{Req 2 - geterr}	_{4,295ms (± 0.37%)}	_{4,353ms (± 0.35%)}	_{+58ms (+ 1.35%)}	_4,337ms	_4,371ms	_{p=0.005 n=6}
_{Req 3 - references}	_{350ms (± 0.28%)}	_{349ms (± 0.23%)}	_~	_348ms	_350ms	_{p=0.065 n=6}
_{Req 4 - navto}	_{292ms (± 0.64%)}	_{290ms (± 0.18%)}	_~	_290ms	_291ms	_{p=0.211 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{64ms (± 5.55%)}	_{62ms (± 0.66%)}	_~	_62ms	_63ms	_{p=0.248 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,082ms (± 0.88%)}	_{3,075ms (± 0.52%)}	_~	_3,044ms	_3,090ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{1,559ms (± 0.68%)}	_{1,587ms (± 1.38%)}	_{+28ms (+ 1.81%)}	_1,555ms	_1,622ms	_{p=0.037 n=6}
_{Req 3 - references}	_{115ms (± 2.12%)}	_{108ms (± 1.36%)}	_{🟩-7ms (- 5.82%)}	_106ms	_110ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{360ms (± 0.58%)}	_{363ms (± 0.32%)}	_{+4ms (+ 1.02%)}	_362ms	_365ms	_{p=0.018 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{376ms (± 2.24%)}	_{378ms (± 1.28%)}	_~	_372ms	_385ms	_{p=0.520 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,653ms (± 0.76%)}	_{2,673ms (± 0.63%)}	_~	_2,644ms	_2,692ms	_{p=0.077 n=6}
_{Req 2 - geterr}	_{6,041ms (± 0.38%)}	_{6,135ms (± 0.50%)}	_{+94ms (+ 1.55%)}	_6,093ms	_6,180ms	_{p=0.005 n=6}
_{Req 3 - references}	_{351ms (± 0.69%)}	_{353ms (± 0.53%)}	_~	_350ms	_355ms	_{p=0.368 n=6}
_{Req 4 - navto}	_{292ms (± 1.34%)}	_{283ms (± 0.98%)}	_{-9ms (- 2.97%)}	_278ms	_286ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{93ms (± 0.59%)}	_{85ms (± 6.27%)}	_{🟩-7ms (- 7.93%)}	_81ms	_92ms	_{p=0.015 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,836ms (± 0.44%)}	_{2,828ms (± 0.27%)}	_~	_2,818ms	_2,840ms	_{p=0.199 n=6}
_{Req 2 - geterr}	_{4,631ms (± 0.43%)}	_{4,694ms (± 0.11%)}	_{+63ms (+ 1.35%)}	_4,688ms	_4,702ms	_{p=0.005 n=6}
_{Req 3 - references}	_{367ms (± 0.57%)}	_{363ms (± 0.46%)}	_{-4ms (- 0.95%)}	_361ms	_365ms	_{p=0.015 n=6}
_{Req 4 - navto}	_{285ms (± 1.14%)}	_{285ms (± 1.03%)}	_~	_282ms	_289ms	_{p=0.871 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{67ms (± 0.77%)}	_{67ms (± 1.12%)}	_~	_66ms	_68ms	_{p=0.784 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,228ms (± 0.48%)}	_{3,210ms (± 0.49%)}	_~	_3,192ms	_3,233ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{1,755ms (± 1.08%)}	_{1,744ms (± 0.48%)}	_~	_1,733ms	_1,752ms	_{p=0.173 n=6}
_{Req 3 - references}	_{129ms (± 8.26%)}	_{123ms (± 0.99%)}	_~	_121ms	_124ms	_{p=0.371 n=6}
_{Req 4 - navto}	_{342ms (± 0.47%)}	_{343ms (± 0.31%)}	_~	_341ms	_344ms	_{p=0.508 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{410ms (± 1.69%)}	_{403ms (± 0.66%)}	_~	_398ms	_405ms	_{p=0.124 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,806ms (± 0.55%)}	_{2,785ms (± 0.32%)}	_{-21ms (- 0.76%)}	_2,772ms	_2,795ms	_{p=0.020 n=6}
_{Req 2 - geterr}	_{6,181ms (± 0.46%)}	_{6,346ms (± 0.55%)}	_{+164ms (+ 2.66%)}	_6,301ms	_6,399ms	_{p=0.005 n=6}
_{Req 3 - references}	_{363ms (± 0.62%)}	_{368ms (± 1.49%)}	_{+5ms (+ 1.47%)}	_363ms	_378ms	_{p=0.034 n=6}
_{Req 4 - navto}	_{291ms (± 0.81%)}	_{291ms (± 0.47%)}	_~	_289ms	_293ms	_{p=0.618 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{99ms (± 4.25%)}	_{101ms (± 4.85%)}	_~	_92ms	_105ms	_{p=0.366 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,975ms (± 1.09%)}	_{2,967ms (± 0.45%)}	_~	_2,945ms	_2,983ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{4,527ms (± 0.85%)}	_{4,577ms (± 0.30%)}	_{+50ms (+ 1.10%)}	_4,557ms	_4,590ms	_{p=0.031 n=6}
_{Req 3 - references}	_{377ms (± 1.22%)}	_{378ms (± 0.99%)}	_~	_374ms	_383ms	_{p=0.629 n=6}
_{Req 4 - navto}	_{299ms (± 0.30%)}	_{297ms (± 0.65%)}	_~	_295ms	_300ms	_{p=0.061 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{76ms (± 0.83%)}	_{76ms (± 0.54%)}	_~	_76ms	_77ms	_{p=0.673 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,503ms (± 1.32%)}	_{3,480ms (± 1.13%)}	_~	_3,430ms	_3,534ms	_{p=0.298 n=6}
_{Req 2 - geterr}	_{1,845ms (± 0.71%)}	_{1,845ms (± 0.55%)}	_~	_1,831ms	_1,857ms	_{p=0.688 n=6}
_{Req 3 - references}	_{154ms (± 5.49%)}	_{154ms (± 6.10%)}	_~	_137ms	_162ms	_{p=0.936 n=6}
_{Req 4 - navto}	_{395ms (± 1.13%)}	_{395ms (± 1.68%)}	_~	_387ms	_407ms	_{p=0.677 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{430ms (± 0.89%)}	_{432ms (± 2.20%)}	_~	_413ms	_439ms	_{p=0.223 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₁₈₃	₆
_Baseline	_main	₆

Startup

Comparison Report - main..54183

_Metric	_main	₅₄₁₈₃	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.97ms (± 0.18%)}	_{141.50ms (± 0.23%)}	_{-0.46ms (- 0.33%)}	_140.84ms	_151.65ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{220.97ms (± 0.22%)}	_{220.58ms (± 0.19%)}	_{-0.39ms (- 0.18%)}	_219.59ms	_227.99ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{223.64ms (± 0.36%)}	_{222.62ms (± 0.30%)}	_{-1.02ms (- 0.46%)}	_220.84ms	_234.65ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{206.57ms (± 0.37%)}	_{204.89ms (± 0.31%)}	_{-1.68ms (- 0.82%)}	_202.90ms	_209.99ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₁₈₃	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

May 24 '23 23:05 typescript-bot

@typescript-bot perf test public

Jan 16 '24 18:01 weswigham

Heya @weswigham, I've started to run the public perf test suite on this PR at bfdaa860b7c8c516f15f8dbe2eb0d6bdffdf8a92. You can monitor the build here.

Update: The results are in!

Jan 16 '24 18:01 typescript-bot

@weswigham The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{mui-docs - node (v20.5.1, x64)}
_{Memory used}	_{1,730,098k (± 0.00%)}	_{1,730,081k (± 0.00%)}	_~	_1,730,041k	_1,730,110k	_{p=0.298 n=6}
_{Parse Time}	_{6.79s (± 0.22%)}	_{6.80s (± 0.44%)}	_~	_6.75s	_6.84s	_{p=0.511 n=6}
_{Bind Time}	_{2.42s (± 1.75%)}	_{2.39s (± 1.42%)}	_~	_2.33s	_2.42s	_{p=0.226 n=6}
_{Check Time}	_{52.41s (± 0.47%)}	_{52.20s (± 0.45%)}	_~	_51.97s	_52.53s	_{p=0.199 n=6}
_{Emit Time}	_{0.15s (± 0.00%)}	_{0.15s (± 2.69%)}	_~	_0.15s	_0.16s	_{p=0.405 n=6}
_{Total Time}	_{61.77s (± 0.46%)}	_{61.53s (± 0.39%)}	_~	_61.29s	_61.84s	_{p=0.199 n=6}
_{self-build-src - node (v20.5.1, x64)}
_{Memory used}	_{2,602,454k (± 2.30%)}	_{2,717,879k (± 8.18%)}	_~	_2,576,888k	_3,072,191k	_{p=0.810 n=6}
_{Parse Time}	_{5.05s (± 1.06%)}	_{5.06s (± 0.41%)}	_~	_5.04s	_5.09s	_{p=1.000 n=6}
_{Bind Time}	_{1.96s (± 0.42%)}	_{1.96s (± 1.18%)}	_~	_1.92s	_1.99s	_{p=0.282 n=6}
_{Check Time}	_{32.27s (± 0.54%)}	_{32.18s (± 0.28%)}	_~	_32.04s	_32.27s	_{p=0.688 n=6}
_{Emit Time}	_{2.76s (± 3.49%)}	_{2.75s (± 1.33%)}	_~	_2.71s	_2.79s	_{p=0.688 n=6}
_{Total Time}	_{42.07s (± 0.54%)}	_{41.96s (± 0.26%)}	_~	_41.77s	_42.10s	_{p=0.575 n=6}
_{self-compiler - node (v20.5.1, x64)}
_{Memory used}	_{419,318k (± 0.01%)}	_{419,377k (± 0.02%)}	_~	_419,307k	_419,495k	_{p=0.093 n=6}
_{Parse Time}	_{2.89s (± 0.74%)}	_{2.88s (± 0.52%)}	_~	_2.87s	_2.90s	_{p=0.564 n=6}
_{Bind Time}	_{1.13s (± 0.46%)}	_{1.13s (± 0.48%)}	_~	_1.13s	_1.14s	_{p=0.640 n=6}
_{Check Time}	_{14.15s (± 0.29%)}	_{14.16s (± 0.59%)}	_~	_14.02s	_14.24s	_{p=0.630 n=6}
_{Emit Time}	_{1.03s (± 0.73%)}	_{1.03s (± 0.87%)}	_~	_1.02s	_1.04s	_{p=0.798 n=6}
_{Total Time}	_{19.20s (± 0.20%)}	_{19.21s (± 0.43%)}	_~	_19.08s	_19.31s	_{p=0.686 n=6}
_{vscode - node (v20.5.1, x64)}
_{Memory used}	_{2,841,130k (± 0.00%)}	_{2,841,091k (± 0.00%)}	_~	_2,841,040k	_2,841,154k	_{p=0.575 n=6}
_{Parse Time}	_{10.78s (± 0.14%)}	_{10.79s (± 0.48%)}	_~	_10.74s	_10.89s	_{p=0.464 n=6}
_{Bind Time}	_{3.46s (± 0.62%)}	_{3.44s (± 0.45%)}	_~	_3.43s	_3.47s	_{p=0.162 n=6}
_{Check Time}	_{56.59s (± 0.20%)}	_{56.82s (± 0.51%)}	_~	_56.51s	_57.19s	_{p=0.173 n=6}
_{Emit Time}	_{16.30s (± 0.43%)}	_{16.23s (± 0.28%)}	_~	_16.15s	_16.26s	_{p=0.126 n=6}
_{Total Time}	_{87.12s (± 0.16%)}	_{87.28s (± 0.33%)}	_~	_86.95s	_87.66s	_{p=0.471 n=6}
_{webpack - node (v20.5.1, x64)}
_{Memory used}	_{395,259k (± 0.01%)}	_{395,243k (± 0.00%)}	_~	_395,215k	_395,256k	_{p=0.297 n=6}
_{Parse Time}	_{3.33s (± 0.73%)}	_{3.32s (± 0.38%)}	_~	_3.30s	_3.34s	_{p=0.340 n=6}
_{Bind Time}	_{1.44s (± 0.76%)}	_{1.45s (± 0.75%)}	_~	_1.44s	_1.47s	_{p=0.111 n=6}
_{Check Time}	_{12.95s (± 0.14%)}	_{12.92s (± 0.25%)}	_~	_12.89s	_12.97s	_{p=0.089 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{17.73s (± 0.22%)}	_{17.69s (± 0.20%)}	_~	_17.65s	_17.75s	_{p=0.172 n=6}

System info unknown

Hosts

node (v20.5.1, x64)

Scenarios

mui-docs - node (v20.5.1, x64)
self-build-src - node (v20.5.1, x64)
self-compiler - node (v20.5.1, x64)
vscode - node (v20.5.1, x64)
webpack - node (v20.5.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Jan 16 '24 20:01 typescript-bot

@typescript-bot run dt @typescript-bot test top100 @typescript-bot user test this @typescript-bot pack this

Jan 16 '24 20:01 weswigham

Heya @weswigham, I've started to run the diff-based user code test suite on this PR at bfdaa860b7c8c516f15f8dbe2eb0d6bdffdf8a92. You can monitor the build here.

Update: The results are in!

Jan 16 '24 20:01 typescript-bot

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at bfdaa860b7c8c516f15f8dbe2eb0d6bdffdf8a92. You can monitor the build here.

Update: The results are in!

Jan 16 '24 20:01 typescript-bot

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at bfdaa860b7c8c516f15f8dbe2eb0d6bdffdf8a92. You can monitor the build here.

Update: The results are in!

Jan 16 '24 20:01 typescript-bot

Heya @weswigham, I've started to run the tarball bundle task on this PR at bfdaa860b7c8c516f15f8dbe2eb0d6bdffdf8a92. You can monitor the build here.

Jan 16 '24 20:01 typescript-bot

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159519/artifacts?artifactName=tgz&fileId=7F84D60014C1780986A6B011145D297D63F303F6B66D0CDEEFFE133053CD579602&fileName=/typescript-5.4.0-insiders.20240116.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

Jan 16 '24 20:01 typescript-bot

@weswigham Here are the results of running the user test suite comparing main and refs/pull/54183/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

Jan 16 '24 20:01 typescript-bot

Hey @weswigham, the results of running the DT tests are ready. Everything looks the same! You can check the log here.

Jan 16 '24 21:01 typescript-bot

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/54183/merge:

Something interesting changed - please have a look.

Details

chakra-ui/chakra-ui

4 of 28 projects failed to build with the old tsc and were ignored

packages/components/tsconfig.build.json

error TS5056: Cannot write file '/mnt/ts_downloads/chakra-ui/packages/components/dist/types/menu/menu.stories.d.ts' because it would be overwritten by multiple input files.
- Project Scope

Jan 16 '24 21:01 typescript-bot

@typescript-bot test top800

Mar 19 '24 22:03 DanielRosenwasser

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top800`	✅ Started	👀 Results

Mar 19 '24 22:03 typescript-bot

@typescript-bot perf test this

Mar 19 '24 22:03 DanielRosenwasser

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

Mar 19 '24 22:03 typescript-bot

@DanielRosenwasser The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,738k (± 0.01%)}	_{295,764k (± 0.01%)}	_~	_295,727k	_295,795k	_{p=0.173 n=6}
_{Parse Time}	_{2.66s (± 0.51%)}	_{2.66s (± 0.24%)}	_~	_2.65s	_2.67s	_{p=1.000 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 0.62%)}	_~	_0.82s	_0.83s	_{p=0.595 n=6}
_{Check Time}	_{8.21s (± 0.36%)}	_{8.23s (± 0.24%)}	_~	_8.20s	_8.26s	_{p=0.224 n=6}
_{Emit Time}	_{7.12s (± 0.77%)}	_{7.11s (± 0.37%)}	_~	_7.08s	_7.15s	_{p=1.000 n=6}
_{Total Time}	_{18.82s (± 0.42%)}	_{18.83s (± 0.21%)}	_~	_18.78s	_18.87s	_{p=0.418 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,631k (± 0.73%)}	_{193,281k (± 0.97%)}	_~	_191,979k	_195,714k	_{p=0.230 n=6}
_{Parse Time}	_{1.36s (± 0.30%)}	_{1.36s (± 0.98%)}	_~	_1.35s	_1.38s	_{p=0.546 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.51s (± 0.67%)}	_{9.57s (± 0.42%)}	_~	_9.51s	_9.62s	_{p=0.108 n=6}
_{Emit Time}	_{2.66s (± 0.31%)}	_{2.65s (± 0.67%)}	_~	_2.63s	_2.68s	_{p=0.402 n=6}
_{Total Time}	_{14.24s (± 0.46%)}	_{14.30s (± 0.32%)}	_~	_14.24s	_14.37s	_{p=0.127 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,370k (± 0.01%)}	_{347,380k (± 0.01%)}	_~	_347,355k	_347,424k	_{p=0.575 n=6}
_{Parse Time}	_{2.48s (± 0.30%)}	_{2.47s (± 0.30%)}	_~	_2.46s	_2.48s	_{p=0.062 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.595 n=6}
_{Check Time}	_{7.03s (± 0.24%)}	_{7.05s (± 0.59%)}	_~	_7.00s	_7.12s	_{p=0.293 n=6}
_{Emit Time}	_{4.07s (± 0.46%)}	_{4.06s (± 0.57%)}	_~	_4.02s	_4.09s	_{p=0.683 n=6}
_{Total Time}	_{14.50s (± 0.19%)}	_{14.51s (± 0.41%)}	_~	_14.45s	_14.61s	_{p=0.807 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,722k (± 0.01%)}	_{302,746k (± 0.01%)}	_~	_302,692k	_302,783k	_{p=0.172 n=6}
_{Parse Time}	_{2.01s (± 1.24%)}	_{2.01s (± 1.01%)}	_~	_1.99s	_2.04s	_{p=0.935 n=6}
_{Bind Time}	_{1.00s (± 1.50%)}	_{1.00s (± 0.81%)}	_~	_0.99s	_1.01s	_{p=0.738 n=6}
_{Check Time}	_{6.30s (± 0.10%)}	_{6.32s (± 0.27%)}	_{+0.02s (+ 0.29%)}	_6.30s	_6.35s	_{p=0.024 n=6}
_{Emit Time}	_{3.60s (± 0.48%)}	_{3.62s (± 0.41%)}	_{+0.02s (+ 0.65%)}	_3.60s	_3.64s	_{p=0.043 n=6}
_{Total Time}	_{12.91s (± 0.17%)}	_{12.95s (± 0.20%)}	_{+0.04s (+ 0.30%)}	_12.91s	_12.98s	_{p=0.044 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{509,919k (± 0.00%)}	_{509,891k (± 0.00%)}	_{-28k (- 0.01%)}	_509,862k	_509,928k	_{p=0.030 n=6}
_{Parse Time}	_{2.65s (± 0.62%)}	_{2.65s (± 0.37%)}	_~	_2.64s	_2.66s	_{p=0.406 n=6}
_{Bind Time}	_{0.99s (± 1.18%)}	_{0.99s (± 0.83%)}	_~	_0.98s	_1.00s	_{p=0.498 n=6}
_{Check Time}	_{17.25s (± 0.17%)}	_{17.29s (± 0.21%)}	_~	_17.23s	_17.33s	_{p=0.124 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.90s (± 0.13%)}	_{20.93s (± 0.14%)}	_~	_20.87s	_20.95s	_{p=0.259 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,718,914k (± 0.00%)}	_{1,718,978k (± 0.00%)}	_{+65k (+ 0.00%)}	_1,718,918k	_1,719,016k	_{p=0.031 n=6}
_{Parse Time}	_{6.52s (± 0.23%)}	_{6.54s (± 0.46%)}	_~	_6.52s	_6.59s	_{p=0.531 n=6}
_{Bind Time}	_{2.37s (± 0.44%)}	_{2.35s (± 0.51%)}	_~	_2.34s	_2.37s	_{p=0.138 n=6}
_{Check Time}	_{56.14s (± 0.33%)}	_{56.09s (± 0.41%)}	_~	_55.84s	_56.43s	_{p=0.630 n=6}
_{Emit Time}	_{0.13s (± 0.00%)}	_{0.13s (± 3.10%)}	_~	_0.13s	_0.14s	_{p=0.405 n=6}
_{Total Time}	_{65.17s (± 0.29%)}	_{65.12s (± 0.34%)}	_~	_64.88s	_65.44s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,395,466k (± 0.02%)}	_{2,395,502k (± 0.03%)}	_~	_2,394,334k	_2,396,030k	_{p=0.689 n=6}
_{Parse Time}	_{5.02s (± 1.01%)}	_{4.98s (± 1.33%)}	_~	_4.88s	_5.07s	_{p=0.297 n=6}
_{Bind Time}	_{1.91s (± 1.53%)}	_{1.90s (± 0.84%)}	_~	_1.88s	_1.92s	_{p=0.871 n=6}
_{Check Time}	_{33.53s (± 0.30%)}	_{33.69s (± 0.27%)}	_{+0.16s (+ 0.47%)}	_33.53s	_33.80s	_{p=0.031 n=6}
_{Emit Time}	_{2.71s (± 0.98%)}	_{2.73s (± 1.66%)}	_~	_2.67s	_2.78s	_{p=0.376 n=6}
_{Total Time}	_{43.18s (± 0.19%)}	_{43.31s (± 0.35%)}	_~	_43.02s	_43.43s	_{p=0.066 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,062k (± 0.01%)}	_{416,162k (± 0.01%)}	_{+101k (+ 0.02%)}	_416,109k	_416,204k	_{p=0.005 n=6}
_{Parse Time}	_{2.82s (± 0.87%)}	_{2.82s (± 1.65%)}	_~	_2.76s	_2.89s	_{p=0.870 n=6}
_{Bind Time}	_{1.07s (± 0.84%)}	_{1.07s (± 0.76%)}	_~	_1.06s	_1.08s	_{p=0.550 n=6}
_{Check Time}	_{15.31s (± 0.34%)}	_{15.29s (± 0.24%)}	_~	_15.22s	_15.32s	_{p=0.687 n=6}
_{Emit Time}	_{1.14s (± 1.06%)}	_{1.15s (± 1.42%)}	_~	_1.13s	_1.17s	_{p=0.805 n=6}
_{Total Time}	_{20.34s (± 0.28%)}	_{20.32s (± 0.16%)}	_~	_20.28s	_20.36s	_{p=0.746 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,884,060k (± 0.01%)}	_{2,884,136k (± 0.00%)}	_~	_2,884,099k	_2,884,209k	_{p=0.575 n=6}
_{Parse Time}	_{10.83s (± 0.44%)}	_{10.80s (± 0.28%)}	_~	_10.78s	_10.85s	_{p=0.506 n=6}
_{Bind Time}	_{3.46s (± 0.37%)}	_{3.46s (± 0.34%)}	_~	_3.44s	_3.47s	_{p=1.000 n=6}
_{Check Time}	_{61.61s (± 0.81%)}	_{61.29s (± 0.38%)}	_~	_60.88s	_61.54s	_{p=0.378 n=6}
_{Emit Time}	_{17.59s (± 9.70%)}	_{16.48s (± 0.57%)}	_~	_16.36s	_16.61s	_{p=0.375 n=6}
_{Total Time}	_{93.48s (± 2.36%)}	_{92.02s (± 0.32%)}	_~	_91.46s	_92.35s	_{p=0.423 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,072k (± 0.00%)}	_{408,133k (± 0.01%)}	_~	_408,048k	_408,192k	_{p=0.128 n=6}
_{Parse Time}	_{3.23s (± 0.34%)}	_{3.23s (± 0.64%)}	_~	_3.19s	_3.25s	_{p=0.742 n=6}
_{Bind Time}	_{1.38s (± 0.54%)}	_{1.38s (± 0.76%)}	_~	_1.36s	_1.39s	_{p=0.273 n=6}
_{Check Time}	_{14.30s (± 0.17%)}	_{14.29s (± 0.42%)}	_~	_14.19s	_14.36s	_{p=0.809 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.91s (± 0.18%)}	_{18.89s (± 0.39%)}	_~	_18.75s	_18.95s	_{p=1.000 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,100k (± 0.01%)}	_{513,094k (± 0.02%)}	_~	_512,979k	_513,184k	_{p=1.000 n=6}
_{Parse Time}	_{3.28s (± 0.36%)}	_{3.27s (± 0.27%)}	_~	_3.26s	_3.28s	_{p=0.214 n=6}
_{Bind Time}	_{1.54s (± 0.33%)}	_{1.54s (± 0.35%)}	_~	_1.54s	_1.55s	_{p=0.640 n=6}
_{Check Time}	_{2.85s (± 0.26%)}	_{2.86s (± 0.53%)}	_~	_2.84s	_2.88s	_{p=0.797 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 5.69%)}	_~	_0.07s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.75s (± 0.20%)}	_{7.75s (± 0.27%)}	_~	_7.72s	_7.77s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,337ms (± 0.71%)}	_{2,350ms (± 0.81%)}	_~	_2,327ms	_2,374ms	_{p=0.199 n=6}
_{Req 2 - geterr}	_{5,796ms (± 0.55%)}	_{5,773ms (± 0.43%)}	_~	_5,730ms	_5,804ms	_{p=0.128 n=6}
_{Req 3 - references}	_{325ms (± 1.13%)}	_{324ms (± 0.17%)}	_~	_323ms	_324ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{273ms (± 0.20%)}	_{273ms (± 0.19%)}	_~	_272ms	_273ms	_{p=0.640 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{94ms (± 0.55%)}	_{95ms (± 0.54%)}	_~	_94ms	_95ms	_{p=0.311 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,501ms (± 0.86%)}	_{2,488ms (± 0.66%)}	_~	_2,463ms	_2,513ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{4,269ms (± 0.33%)}	_{4,260ms (± 0.24%)}	_~	_4,241ms	_4,271ms	_{p=0.378 n=6}
_{Req 3 - references}	_{332ms (± 0.16%)}	_{332ms (± 0.17%)}	_~	_331ms	_332ms	_{p=0.640 n=6}
_{Req 4 - navto}	_{284ms (± 0.37%)}	_{284ms (± 0.58%)}	_~	_282ms	_286ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 0.52%)}	_{78ms (± 0.66%)}	_~	_78ms	_79ms	_{p=0.114 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,618ms (± 0.17%)}	_{2,624ms (± 0.40%)}	_~	_2,611ms	_2,642ms	_{p=0.196 n=6}
_{Req 2 - geterr}	_{1,716ms (± 1.99%)}	_{1,724ms (± 1.96%)}	_~	_1,667ms	_1,763ms	_{p=0.575 n=6}
_{Req 3 - references}	_{113ms (± 9.36%)}	_{104ms (± 0.78%)}	_~	_104ms	_106ms	_{p=0.422 n=6}
_{Req 4 - navto}	_{372ms (± 1.03%)}	_{370ms (± 0.63%)}	_~	_366ms	_373ms	_{p=0.325 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{308ms (± 1.19%)}	_{308ms (± 2.34%)}	_~	_298ms	_316ms	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.76ms (± 0.18%)}	_{153.76ms (± 0.18%)}	_~	_152.67ms	_157.93ms	_{p=0.997 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.40ms (± 0.85%)}	_{228.71ms (± 0.15%)}	_{-0.69ms (- 0.30%)}	_227.19ms	_233.22ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{222.51ms (± 0.17%)}	_{222.59ms (± 0.16%)}	_{+0.07ms (+ 0.03%)}	_221.16ms	_229.36ms	_{p=0.015 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{222.01ms (± 0.18%)}	_{221.90ms (± 0.15%)}	_{-0.12ms (- 0.05%)}	_220.38ms	_225.39ms	_{p=0.009 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Mar 19 '24 23:03 typescript-bot

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/54183/merge:

Something interesting changed - please have a look.

Details

Infisical/infisical

2 of 3 projects failed to build with the old tsc and were ignored

backend/tsconfig.json

Mar 20 '24 00:03 typescript-bot

Extracted repro (still depending on 3rd party libs) from the reported failure above: TS playground

EDIT: Somewhat reduced repro of the above: TS playground

Mar 20 '24 23:03 Andarist