microsoft
fix(53933): Confusing rules around function parameter names in a type
@typescript-bot test this @typescript-bot test top100 @typescript-bot user test this @typescript-bot run dt @typescript-bot perf test this faster
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 39f04bf99722881bec27b2750b00933cd53a3239. You can monitor the build here.
Update: The results are in!
Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 39f04bf99722881bec27b2750b00933cd53a3239. You can monitor the build here.
Update: The results are in!
Heya @jakebailey, I've started to run the extended test suite on this PR at 39f04bf99722881bec27b2750b00933cd53a3239. You can monitor the build here.
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 39f04bf99722881bec27b2750b00933cd53a3239. You can monitor the build here.
Update: The results are in!
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 39f04bf99722881bec27b2750b00933cd53a3239. You can monitor the build here.
Update: The results are in!
@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53946/merge:
There were infrastructure failures potentially unrelated to your change:
- 1 instance of "Package install failed"
Otherwise...
Everything looks good!
@jakebailey The results of the perf run you requested are in!
Here they are:
Comparison Report - main..53946
| Metric | main | 53946 | Delta | Best | Worst | p-value |
|---|---|---|---|---|---|---|
| Angular - node (v16.17.1, x64) | ||||||
| Memory used | 365,182k (± 0.01%) | 365,196k (± 0.00%) | ~ | 365,165k | 365,213k | p=0.149 n=6 |
| Parse Time | 3.54s (± 0.46%) | 3.54s (± 0.50%) | ~ | 3.52s | 3.57s | p=0.408 n=6 |
| Bind Time | 1.18s (± 0.47%) | 1.18s (± 0.44%) | ~ | 1.17s | 1.18s | p=0.640 n=6 |
| Check Time | 9.50s (± 0.25%) | 9.53s (± 0.46%) | ~ | 9.49s | 9.61s | p=0.164 n=6 |
| Emit Time | 7.88s (± 0.44%) | 7.91s (± 0.71%) | ~ | 7.85s | 7.98s | p=0.294 n=6 |
| Total Time | 22.08s (± 0.22%) | 22.16s (± 0.35%) | ~ | 22.07s | 22.24s | p=0.107 n=6 |
| Compiler-Unions - node (v16.17.1, x64) | ||||||
| Memory used | 192,664k (± 0.03%) | 192,653k (± 0.02%) | ~ | 192,617k | 192,727k | p=0.689 n=6 |
| Parse Time | 1.58s (± 1.35%) | 1.60s (± 0.47%) | ~ | 1.59s | 1.61s | p=0.112 n=6 |
| Bind Time | 0.82s (± 0.63%) | 0.82s (± 0.63%) | ~ | 0.82s | 0.83s | p=1.000 n=6 |
| Check Time | 10.26s (± 0.62%) | 10.23s (± 0.42%) | ~ | 10.18s | 10.30s | p=0.295 n=6 |
| Emit Time | 2.99s (± 0.40%) | 2.98s (± 0.39%) | ~ | 2.96s | 2.99s | p=0.084 n=6 |
| Total Time | 15.66s (± 0.52%) | 15.64s (± 0.28%) | ~ | 15.59s | 15.69s | p=0.376 n=6 |
| Monaco - node (v16.17.1, x64) | ||||||
| Memory used | 345,766k (± 0.01%) | 345,766k (± 0.00%) | ~ | 345,749k | 345,777k | p=1.000 n=6 |
| Parse Time | 2.71s (± 0.64%) | 2.73s (± 0.49%) | ~ | 2.71s | 2.75s | p=0.162 n=6 |
| Bind Time | 1.09s (± 0.75%) | 1.08s (± 0.50%) | ~ | 1.08s | 1.09s | p=0.859 n=6 |
| Check Time | 7.82s (± 0.65%) | 7.83s (± 0.19%) | ~ | 7.81s | 7.85s | p=0.226 n=6 |
| Emit Time | 4.44s (± 1.01%) | 4.42s (± 0.47%) | ~ | 4.40s | 4.45s | p=0.809 n=6 |
| Total Time | 16.05s (± 0.51%) | 16.07s (± 0.17%) | ~ | 16.03s | 16.11s | p=0.145 n=6 |
| TFS - node (v16.17.1, x64) | ||||||
| Memory used | 300,062k (± 0.01%) | 300,067k (± 0.01%) | ~ | 300,038k | 300,103k | p=0.810 n=6 |
| Parse Time | 2.16s (± 0.38%) | 2.15s (± 0.48%) | ~ | 2.14s | 2.17s | p=0.546 n=6 |
| Bind Time | 1.24s (± 0.61%) | 1.23s (± 0.61%) | ~ | 1.22s | 1.24s | p=0.195 n=6 |
| Check Time | 7.19s (± 0.55%) | 7.21s (± 0.46%) | ~ | 7.17s | 7.24s | p=0.373 n=6 |
| Emit Time | 4.36s (± 0.95%) | 4.34s (± 0.65%) | ~ | 4.30s | 4.37s | p=0.260 n=6 |
| Total Time | 14.95s (± 0.52%) | 14.93s (± 0.39%) | ~ | 14.85s | 15.01s | p=0.688 n=6 |
| material-ui - node (v16.17.1, x64) | ||||||
| Memory used | 481,548k (± 0.01%) | 481,567k (± 0.01%) | ~ | 481,511k | 481,654k | p=1.000 n=6 |
| Parse Time | 3.24s (± 0.17%) | 3.23s (± 0.50%) | ~ | 3.21s | 3.26s | p=0.663 n=6 |
| Bind Time | 0.94s (± 0.67%) | 0.94s (± 0.67%) | ~ | 0.93s | 0.95s | p=1.000 n=6 |
| Check Time | 17.81s (± 0.53%) | 17.86s (± 0.64%) | ~ | 17.73s | 18.02s | p=0.471 n=6 |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | ~ | 0.00s | 0.00s | p=1.000 n=6 |
| Total Time | 21.98s (± 0.45%) | 22.03s (± 0.46%) | ~ | 21.93s | 22.17s | p=0.423 n=6 |
| xstate - node (v16.17.1, x64) | ||||||
| Memory used | 560,639k (± 0.01%) | 560,594k (± 0.02%) | ~ | 560,507k | 560,740k | p=0.575 n=6 |
| Parse Time | 3.99s (± 0.20%) | 3.99s (± 0.44%) | ~ | 3.96s | 4.01s | p=0.935 n=6 |
| Bind Time | 1.77s (± 0.29%) | 1.77s (± 0.36%) | ~ | 1.76s | 1.78s | p=0.386 n=6 |
| Check Time | 3.02s (± 0.53%) | 3.03s (± 0.35%) | ~ | 3.01s | 3.04s | p=0.459 n=6 |
| Emit Time | 0.09s (± 0.00%) | 0.09s (± 0.00%) | ~ | 0.09s | 0.09s | p=1.000 n=6 |
| Total Time | 8.87s (± 0.22%) | 8.87s (± 0.24%) | ~ | 8.85s | 8.90s | p=0.808 n=6 |
| Machine Name | ts-ci-ubuntu |
|---|---|
| Platform | linux 5.4.0-135-generic |
| Architecture | x64 |
| Available Memory | 16 GB |
| Available Memory | 15 GB |
| CPUs | 4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz |
- node (v16.17.1, x64)
- Angular - node (v16.17.1, x64)
- Compiler-Unions - node (v16.17.1, x64)
- Monaco - node (v16.17.1, x64)
- TFS - node (v16.17.1, x64)
- material-ui - node (v16.17.1, x64)
- xstate - node (v16.17.1, x64)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | 53946 | 6 |
| Baseline | main | 6 |
Developer Information:
Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details. You can check the log here.
@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53946/merge:
Everything looks good!
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 39f04bf99722881bec27b2750b00933cd53a3239. You can monitor the build here.
Update: The results are in!
Hey @jakebailey, the results of running the DT tests are ready. Everything looks the same! You can check the log here.