TypeScript Use iterators to avoid calculating all properties of UnionOrIntersectionType

For #51188

Profiling gave me this big chunk:

getPropertiesOfUnionOrIntersectionType is the biggest chunk. What I noticed was that getReducedType didn't actually need all of the properties; all it wants to know is whether or not some property satisfies isNeverReducedProperty.

By fiddling with the code a bit, we can convert getPropertiesOfUnionOrIntersectionType into an iterator, allowing callers to stop calculating properties early if that benefits them. And, it turns out that most callers of getPropertiesOfUnionOrIntersectionType (all but one!) indeed don't actually care about every property, only whichever one matches some predicate.

After, the same code looks like:

hyperfine, for this test case:

Benchmark 1: main
  Time (mean ± σ):     19.403 s ±  0.300 s    [User: 16.662 s, System: 2.735 s]
  Range (min … max):   18.933 s … 19.988 s    20 runs
 
Benchmark 2: new
  Time (mean ± σ):     13.450 s ±  0.074 s    [User: 11.974 s, System: 1.470 s]
  Range (min … max):   13.341 s … 13.612 s    20 runs
 
Summary
  'new' ran
    1.44 ± 0.02 times faster than 'main'

aka 44% faster aka 1.44x faster aka 31% less time.

Mar 19 '23 05:03 jakebailey

@typescript-bot perf test this

Mar 19 '23 05:03 jakebailey

Heya @jakebailey, I've started to run the perf test suite on this PR at c53294b9fdad43274a4d12b99288fbe0d69d6fac. You can monitor the build here.

Update: The results are in!

Mar 19 '23 05:03 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53346

_Metric	_main	₅₃₃₄₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{361,557k (± 0.01%)}	_{361,616k (± 0.01%)}	_{+59k (+ 0.02%)}	_361,563k	_361,643k	_{p=0.016 n=6}
_{Parse Time}	_{3.37s (± 0.35%)}	_{3.39s (± 0.48%)}	_{+0.02s (+ 0.64%)}	_3.37s	_3.41s	_{p=0.042 n=6}
_{Bind Time}	_{1.12s (± 0.49%)}	_{1.12s (± 1.08%)}	_~	_1.11s	_1.14s	_{p=0.855 n=6}
_{Check Time}	_{8.70s (± 0.37%)}	_{8.73s (± 0.60%)}	_~	_8.66s	_8.78s	_{p=0.375 n=6}
_{Emit Time}	_{7.42s (± 0.93%)}	_{7.45s (± 0.84%)}	_~	_7.39s	_7.56s	_{p=0.230 n=6}
_{Total Time}	_{20.60s (± 0.47%)}	_{20.68s (± 0.48%)}	_~	_20.56s	_20.82s	_{p=0.149 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{192,647k (± 1.50%)}	_{185,819k (± 1.56%)}	_{🟩-6,829k (- 3.54%)}	_183,879k	_189,673k	_{p=0.005 n=6}
_{Parse Time}	_{1.49s (± 0.89%)}	_{1.50s (± 1.24%)}	_~	_1.48s	_1.53s	_{p=0.931 n=6}
_{Bind Time}	_{0.77s (± 0.53%)}	_{0.77s (± 0.53%)}	_~	_0.76s	_0.77s	_{p=0.218 n=6}
_{Check Time}	_{9.36s (± 0.79%)}	_{9.34s (± 0.80%)}	_~	_9.21s	_9.42s	_{p=0.873 n=6}
_{Emit Time}	_{2.72s (± 0.79%)}	_{2.74s (± 0.68%)}	_~	_2.73s	_2.78s	_{p=0.052 n=6}
_{Total Time}	_{14.34s (± 0.55%)}	_{14.36s (± 0.63%)}	_~	_14.21s	_14.44s	_{p=0.689 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,121k (± 0.01%)}	_{346,141k (± 0.01%)}	_~	_346,108k	_346,176k	_{p=0.378 n=6}
_{Parse Time}	_{2.58s (± 1.33%)}	_{2.58s (± 1.12%)}	_~	_2.54s	_2.63s	_{p=1.000 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{1.01s (± 0.63%)}	_{+0.01s (+ 1.17%)}	_1.00s	_1.02s	_{p=0.031 n=6}
_{Check Time}	_{6.97s (± 0.44%)}	_{7.00s (± 0.31%)}	_~	_6.97s	_7.02s	_{p=0.088 n=6}
_{Emit Time}	_{4.24s (± 0.38%)}	_{4.26s (± 0.94%)}	_~	_4.20s	_4.30s	_{p=0.332 n=6}
_{Total Time}	_{14.79s (± 0.32%)}	_{14.84s (± 0.42%)}	_~	_14.78s	_14.94s	_{p=0.090 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,454k (± 0.01%)}	_{300,440k (± 0.01%)}	_~	_300,407k	_300,483k	_{p=0.423 n=6}
_{Parse Time}	_{2.06s (± 0.95%)}	_{2.06s (± 0.94%)}	_~	_2.03s	_2.08s	_{p=1.000 n=6}
_{Bind Time}	_{1.13s (± 0.46%)}	_{1.14s (± 0.96%)}	_~	_1.12s	_1.15s	_{p=0.149 n=6}
_{Check Time}	_{6.47s (± 0.29%)}	_{6.50s (± 0.25%)}	_{+0.03s (+ 0.46%)}	_6.48s	_6.52s	_{p=0.023 n=6}
_{Emit Time}	_{3.86s (± 0.63%)}	_{3.85s (± 0.97%)}	_~	_3.81s	_3.91s	_{p=0.808 n=6}
_{Total Time}	_{13.52s (± 0.36%)}	_{13.55s (± 0.18%)}	_~	_13.52s	_13.58s	_{p=0.259 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{478,171k (± 0.01%)}	_{478,428k (± 0.01%)}	_{+258k (+ 0.05%)}	_478,394k	_478,491k	_{p=0.005 n=6}
_{Parse Time}	_{2.98s (± 3.24%)}	_{3.03s (± 2.39%)}	_~	_2.94s	_3.09s	_{p=0.332 n=6}
_{Bind Time}	_{1.00s (± 7.39%)}	_{0.95s (± 8.14%)}	_~	_0.89s	_1.07s	_{p=0.253 n=6}
_{Check Time}	_{17.05s (± 0.70%)}	_{17.14s (± 0.48%)}	_~	_17.07s	_17.28s	_{p=0.173 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.03s (± 0.53%)}	_{21.13s (± 0.44%)}	_~	_21.04s	_21.29s	_{p=0.172 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{553,195k (± 0.01%)}	_{553,218k (± 0.02%)}	_~	_553,073k	_553,335k	_{p=0.810 n=6}
_{Parse Time}	_{3.75s (± 0.34%)}	_{3.76s (± 0.62%)}	_~	_3.73s	_3.80s	_{p=0.278 n=6}
_{Bind Time}	_{1.69s (± 0.71%)}	_{1.69s (± 0.53%)}	_~	_1.68s	_1.70s	_{p=0.676 n=6}
_{Check Time}	_{2.78s (± 0.85%)}	_{2.88s (± 1.31%)}	_{+0.10s (+ 3.72%)}	_2.84s	_2.93s	_{p=0.005 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{8.31s (± 0.35%)}	_{8.42s (± 0.42%)}	_{+0.11s (+ 1.28%)}	_8.38s	_8.47s	_{p=0.005 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{360,896k (± 0.01%)}	_{360,965k (± 0.00%)}	_{+70k (+ 0.02%)}	_360,940k	_360,988k	_{p=0.005 n=6}
_{Parse Time}	_{3.52s (± 0.69%)}	_{3.52s (± 0.64%)}	_~	_3.50s	_3.55s	_{p=1.000 n=6}
_{Bind Time}	_{1.18s (± 0.69%)}	_{1.19s (± 0.68%)}	_~	_1.18s	_1.20s	_{p=0.077 n=6}
_{Check Time}	_{9.46s (± 0.52%)}	_{9.49s (± 0.32%)}	_~	_9.44s	_9.53s	_{p=0.141 n=6}
_{Emit Time}	_{7.93s (± 0.68%)}	_{7.88s (± 0.44%)}	_~	_7.84s	_7.93s	_{p=0.172 n=6}
_{Total Time}	_{22.10s (± 0.38%)}	_{22.10s (± 0.24%)}	_~	_22.04s	_22.18s	_{p=0.810 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,531k (± 0.04%)}	_{186,690k (± 0.90%)}	_{🟩-5,842k (- 3.03%)}	_185,564k	_188,994k	_{p=0.005 n=6}
_{Parse Time}	_{1.57s (± 1.64%)}	_{1.58s (± 1.48%)}	_~	_1.54s	_1.61s	_{p=0.618 n=6}
_{Bind Time}	_{0.82s (± 0.77%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.201 n=6}
_{Check Time}	_{10.08s (± 0.62%)}	_{10.04s (± 0.66%)}	_~	_9.96s	_10.12s	_{p=0.199 n=6}
_{Emit Time}	_{2.99s (± 0.63%)}	_{2.99s (± 0.35%)}	_~	_2.98s	_3.01s	_{p=0.744 n=6}
_{Total Time}	_{15.47s (± 0.30%)}	_{15.44s (± 0.58%)}	_~	_15.33s	_15.54s	_{p=0.687 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,434k (± 0.01%)}	_{345,448k (± 0.00%)}	_~	_345,431k	_345,461k	_{p=0.128 n=6}
_{Parse Time}	_{2.72s (± 0.36%)}	_{2.73s (± 0.50%)}	_~	_2.71s	_2.75s	_{p=0.138 n=6}
_{Bind Time}	_{1.09s (± 0.50%)}	_{1.09s (± 0.00%)}	_~	_1.09s	_1.09s	_{p=0.071 n=6}
_{Check Time}	_{7.66s (± 0.32%)}	_{7.71s (± 0.59%)}	_{+0.05s (+ 0.67%)}	_7.68s	_7.80s	_{p=0.024 n=6}
_{Emit Time}	_{4.42s (± 0.57%)}	_{4.46s (± 1.15%)}	_~	_4.38s	_4.53s	_{p=0.171 n=6}
_{Total Time}	_{15.89s (± 0.19%)}	_{16.00s (± 0.51%)}	_{+0.11s (+ 0.67%)}	_15.93s	_16.12s	_{p=0.006 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,792k (± 0.01%)}	_{299,792k (± 0.01%)}	_~	_299,751k	_299,824k	_{p=0.936 n=6}
_{Parse Time}	_{2.17s (± 0.48%)}	_{2.18s (± 0.84%)}	_~	_2.16s	_2.20s	_{p=0.249 n=6}
_{Bind Time}	_{1.24s (± 0.88%)}	_{1.24s (± 0.88%)}	_~	_1.22s	_1.25s	_{p=1.000 n=6}
_{Check Time}	_{7.17s (± 0.57%)}	_{7.16s (± 0.63%)}	_~	_7.11s	_7.22s	_{p=0.748 n=6}
_{Emit Time}	_{4.31s (± 0.70%)}	_{4.35s (± 0.70%)}	_{+0.04s (+ 1.04%)}	_4.31s	_4.39s	_{p=0.035 n=6}
_{Total Time}	_{14.88s (± 0.33%)}	_{14.93s (± 0.42%)}	_~	_14.86s	_15.03s	_{p=0.148 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{477,460k (± 0.02%)}	_{477,732k (± 0.01%)}	_{+271k (+ 0.06%)}	_477,648k	_477,769k	_{p=0.005 n=6}
_{Parse Time}	_{3.21s (± 0.36%)}	_{3.21s (± 0.91%)}	_~	_3.17s	_3.24s	_{p=0.513 n=6}
_{Bind Time}	_{0.95s (± 0.54%)}	_{0.95s (± 0.57%)}	_~	_0.95s	_0.96s	_{p=0.640 n=6}
_{Check Time}	_{17.96s (± 0.49%)}	_{18.18s (± 0.65%)}	_{+0.23s (+ 1.26%)}	_18.08s	_18.41s	_{p=0.005 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.12s (± 0.45%)}	_{22.35s (± 0.56%)}	_{+0.23s (+ 1.03%)}	_22.24s	_22.59s	_{p=0.008 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,802k (± 0.02%)}	_{550,846k (± 0.02%)}	_~	_550,728k	_550,927k	_{p=0.298 n=6}
_{Parse Time}	_{3.94s (± 0.35%)}	_{3.96s (± 0.68%)}	_~	_3.93s	_4.01s	_{p=0.088 n=6}
_{Bind Time}	_{1.80s (± 0.30%)}	_{1.79s (± 0.50%)}	_~	_1.78s	_1.80s	_{p=0.341 n=6}
_{Check Time}	_{3.03s (± 0.39%)}	_{3.10s (± 0.58%)}	_{+0.07s (+ 2.25%)}	_3.08s	_3.13s	_{p=0.005 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.86s (± 0.27%)}	_{8.94s (± 0.39%)}	_{+0.08s (+ 0.96%)}	_8.90s	_9.00s	_{p=0.006 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{354,718k (± 0.01%)}	_{354,742k (± 0.01%)}	_~	_354,697k	_354,773k	_{p=0.230 n=6}
_{Parse Time}	_{3.58s (± 0.55%)}	_{3.60s (± 0.71%)}	_~	_3.56s	_3.63s	_{p=0.169 n=6}
_{Bind Time}	_{1.23s (± 0.45%)}	_{1.23s (± 0.66%)}	_~	_1.22s	_1.24s	_{p=0.088 n=6}
_{Check Time}	_{9.70s (± 0.46%)}	_{9.74s (± 0.36%)}	_~	_9.70s	_9.80s	_{p=0.171 n=6}
_{Emit Time}	_{8.34s (± 0.90%)}	_{8.37s (± 0.94%)}	_~	_8.24s	_8.48s	_{p=0.689 n=6}
_{Total Time}	_{22.83s (± 0.49%)}	_{22.93s (± 0.32%)}	_~	_22.84s	_23.05s	_{p=0.172 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{187,762k (± 0.01%)}	_{180,820k (± 0.02%)}	_{🟩-6,943k (- 3.70%)}	_180,781k	_180,864k	_{p=0.005 n=6}
_{Parse Time}	_{1.60s (± 0.73%)}	_{1.60s (± 0.51%)}	_~	_1.59s	_1.61s	_{p=0.738 n=6}
_{Bind Time}	_{0.84s (± 0.65%)}	_{0.85s (± 0.48%)}	_~	_0.84s	_0.85s	_{p=0.282 n=6}
_{Check Time}	_{10.16s (± 0.53%)}	_{10.09s (± 0.49%)}	_~	_10.02s	_10.16s	_{p=0.054 n=6}
_{Emit Time}	_{3.13s (± 1.03%)}	_{3.12s (± 1.59%)}	_~	_3.03s	_3.16s	_{p=0.810 n=6}
_{Total Time}	_{15.73s (± 0.41%)}	_{15.66s (± 0.50%)}	_~	_15.57s	_15.76s	_{p=0.126 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{340,407k (± 0.00%)}	_{340,410k (± 0.01%)}	_~	_340,355k	_340,449k	_{p=0.748 n=6}
_{Parse Time}	_{2.84s (± 0.75%)}	_{2.84s (± 0.52%)}	_~	_2.82s	_2.86s	_{p=0.869 n=6}
_{Bind Time}	_{1.10s (± 1.06%)}	_{1.11s (± 0.47%)}	_~	_1.10s	_1.11s	_{p=0.191 n=6}
_{Check Time}	_{8.04s (± 0.30%)}	_{8.04s (± 0.33%)}	_~	_7.99s	_8.07s	_{p=0.871 n=6}
_{Emit Time}	_{4.68s (± 0.63%)}	_{4.70s (± 0.63%)}	_~	_4.67s	_4.74s	_{p=0.294 n=6}
_{Total Time}	_{16.65s (± 0.21%)}	_{16.68s (± 0.23%)}	_~	_16.64s	_16.73s	_{p=0.169 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,862k (± 0.00%)}	_{294,871k (± 0.00%)}	_{+9k (+ 0.00%)}	_294,856k	_294,877k	_{p=0.045 n=6}
_{Parse Time}	_{2.40s (± 0.34%)}	_{2.40s (± 0.94%)}	_~	_2.37s	_2.42s	_{p=0.415 n=6}
_{Bind Time}	_{1.07s (± 0.48%)}	_{1.07s (± 0.51%)}	_~	_1.06s	_1.07s	_{p=0.640 n=6}
_{Check Time}	_{7.46s (± 0.60%)}	_{7.47s (± 0.65%)}	_~	_7.41s	_7.54s	_{p=0.747 n=6}
_{Emit Time}	_{4.29s (± 1.08%)}	_{4.29s (± 0.81%)}	_~	_4.24s	_4.34s	_{p=0.569 n=6}
_{Total Time}	_{15.21s (± 0.41%)}	_{15.23s (± 0.52%)}	_~	_15.13s	_15.34s	_{p=0.468 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{472,968k (± 0.01%)}	_{473,254k (± 0.00%)}	_{+286k (+ 0.06%)}	_473,230k	_473,281k	_{p=0.005 n=6}
_{Parse Time}	_{3.33s (± 0.29%)}	_{3.35s (± 0.41%)}	_~	_3.33s	_3.37s	_{p=0.054 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.01s (± 0.51%)}	_~	_1.00s	_1.01s	_{p=0.112 n=6}
_{Check Time}	_{18.97s (± 0.46%)}	_{19.17s (± 0.66%)}	_{+0.20s (+ 1.06%)}	_19.03s	_19.36s	_{p=0.020 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.30s (± 0.41%)}	_{23.52s (± 0.60%)}	_{+0.22s (+ 0.93%)}	_23.36s	_23.73s	_{p=0.020 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{539,282k (± 0.01%)}	_{539,319k (± 0.00%)}	_~	_539,297k	_539,358k	_{p=0.054 n=6}
_{Parse Time}	_{4.22s (± 0.36%)}	_{4.26s (± 0.42%)}	_{+0.04s (+ 0.87%)}	_4.23s	_4.28s	_{p=0.014 n=6}
_{Bind Time}	_{1.68s (± 0.49%)}	_{1.68s (± 0.73%)}	_~	_1.66s	_1.69s	_{p=1.000 n=6}
_{Check Time}	_{3.19s (± 0.68%)}	_{3.25s (± 0.83%)}	_{+0.06s (+ 1.72%)}	_3.21s	_3.29s	_{p=0.010 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.10s (± 4.15%)}	_{+0.01s (+ 9.26%)}	_0.09s	_0.10s	_{p=0.007 n=6}
_{Total Time}	_{9.18s (± 0.23%)}	_{9.28s (± 0.57%)}	_{+0.10s (+ 1.03%)}	_9.23s	_9.37s	_{p=0.005 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₄₆	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..53346

_Metric	_main	₅₃₃₄₆	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,381ms (± 0.52%)}	_{2,392ms (± 0.71%)}	_~	_2,373ms	_2,411ms	_{p=0.230 n=6}
_{Req 2 - geterr}	_{5,340ms (± 0.54%)}	_{5,382ms (± 0.63%)}	_~	_5,334ms	_5,426ms	_{p=0.066 n=6}
_{Req 3 - references}	_{338ms (± 1.43%)}	_{338ms (± 0.83%)}	_~	_332ms	_340ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{279ms (± 0.27%)}	_{280ms (± 0.58%)}	_~	_278ms	_282ms	_{p=0.117 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 6.30%)}	_{83ms (± 0.76%)}	_~	_82ms	_84ms	_{p=0.157 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,510ms (± 1.07%)}	_{2,517ms (± 0.89%)}	_~	_2,492ms	_2,544ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{4,012ms (± 0.58%)}	_{4,012ms (± 0.68%)}	_~	_3,979ms	_4,045ms	_{p=0.936 n=6}
_{Req 3 - references}	_{349ms (± 1.03%)}	_{349ms (± 0.97%)}	_~	_343ms	_353ms	_{p=0.936 n=6}
_{Req 4 - navto}	_{290ms (± 1.01%)}	_{294ms (± 1.03%)}	_~	_289ms	_298ms	_{p=0.102 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 6.67%)}	_{83ms (± 3.96%)}	_~	_79ms	_87ms	_{p=0.225 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,025ms (± 0.89%)}	_{3,021ms (± 0.43%)}	_~	_3,009ms	_3,038ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{1,624ms (± 1.04%)}	_{1,645ms (± 0.87%)}	_~	_1,628ms	_1,662ms	_{p=0.128 n=6}
_{Req 3 - references}	_{108ms (± 1.98%)}	_{108ms (± 1.65%)}	_~	_105ms	_110ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{359ms (± 1.22%)}	_{359ms (± 2.26%)}	_~	_354ms	_375ms	_{p=0.369 n=6}
_{Req 5 - completionInfo count}	_{2,861 (± 0.00%)}	_{2,861 (± 0.00%)}	_~	_2,861	_2,861	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{382ms (± 1.51%)}	_{374ms (± 1.68%)}	_{-8ms (- 2.01%)}	_362ms	_379ms	_{p=0.036 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,507ms (± 0.63%)}	_{2,508ms (± 0.91%)}	_~	_2,474ms	_2,542ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{5,749ms (± 0.70%)}	_{5,791ms (± 0.76%)}	_~	_5,726ms	_5,836ms	_{p=0.149 n=6}
_{Req 3 - references}	_{348ms (± 0.85%)}	_{345ms (± 0.41%)}	_~	_343ms	_347ms	_{p=0.142 n=6}
_{Req 4 - navto}	_{279ms (± 1.05%)}	_{278ms (± 0.53%)}	_~	_277ms	_281ms	_{p=0.453 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{74ms (± 1.11%)}	_{73ms (± 1.11%)}	_~	_72ms	_74ms	_{p=0.389 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,702ms (± 1.36%)}	_{2,703ms (± 1.45%)}	_~	_2,669ms	_2,766ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{4,376ms (± 0.25%)}	_{4,374ms (± 0.26%)}	_~	_4,359ms	_4,390ms	_{p=0.936 n=6}
_{Req 3 - references}	_{359ms (± 0.43%)}	_{360ms (± 1.43%)}	_~	_352ms	_368ms	_{p=0.622 n=6}
_{Req 4 - navto}	_{289ms (± 0.51%)}	_{291ms (± 0.73%)}	_~	_289ms	_294ms	_{p=0.099 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 6.49%)}	_{73ms (± 6.91%)}	_~	_67ms	_80ms	_{p=1.000 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,160ms (± 0.30%)}	_{3,167ms (± 0.25%)}	_~	_3,161ms	_3,182ms	_{p=0.336 n=6}
_{Req 2 - geterr}	_{1,763ms (± 0.77%)}	_{1,796ms (± 0.47%)}	_{+33ms (+ 1.88%)}	_1,785ms	_1,806ms	_{p=0.005 n=6}
_{Req 3 - references}	_{117ms (± 1.08%)}	_{117ms (± 1.37%)}	_~	_114ms	_118ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{342ms (± 0.40%)}	_{341ms (± 0.44%)}	_~	_339ms	_343ms	_{p=0.190 n=6}
_{Req 5 - completionInfo count}	_{2,861 (± 0.00%)}	_{2,861 (± 0.00%)}	_~	_2,861	_2,861	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{404ms (± 5.37%)}	_{391ms (± 1.67%)}	_~	_380ms	_397ms	_{p=0.229 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,584ms (± 0.58%)}	_{2,589ms (± 0.73%)}	_~	_2,564ms	_2,615ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{6,127ms (± 0.33%)}	_{6,161ms (± 0.91%)}	_~	_6,099ms	_6,238ms	_{p=0.471 n=6}
_{Req 3 - references}	_{366ms (± 1.45%)}	_{365ms (± 0.66%)}	_~	_362ms	_369ms	_{p=0.872 n=6}
_{Req 4 - navto}	_{276ms (± 1.01%)}	_{277ms (± 1.13%)}	_~	_275ms	_283ms	_{p=0.652 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{102ms (± 0.96%)}	_{101ms (± 2.75%)}	_~	_96ms	_104ms	_{p=0.868 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,808ms (± 0.34%)}	_{2,810ms (± 0.51%)}	_~	_2,786ms	_2,829ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{4,460ms (± 0.39%)}	_{4,542ms (± 2.74%)}	_~	_4,430ms	_4,707ms	_{p=0.298 n=6}
_{Req 3 - references}	_{421ms (± 4.79%)}	_{410ms (± 7.39%)}	_~	_369ms	_433ms	_{p=0.374 n=6}
_{Req 4 - navto}	_{289ms (± 0.99%)}	_{290ms (± 0.65%)}	_~	_287ms	_292ms	_{p=0.624 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 5.27%)}	_{84ms (± 9.10%)}	_~	_74ms	_92ms	_{p=0.849 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,443ms (± 0.35%)}	_{3,456ms (± 0.53%)}	_~	_3,428ms	_3,477ms	_{p=0.229 n=6}
_{Req 2 - geterr}	_{1,857ms (± 0.61%)}	_{1,871ms (± 0.85%)}	_{+14ms (+ 0.73%)}	_1,840ms	_1,884ms	_{p=0.045 n=6}
_{Req 3 - references}	_{126ms (± 2.00%)}	_{125ms (± 0.82%)}	_~	_124ms	_127ms	_{p=0.503 n=6}
_{Req 4 - navto}	_{371ms (± 0.36%)}	_{370ms (± 0.28%)}	_~	_368ms	_371ms	_{p=0.098 n=6}
_{Req 5 - completionInfo count}	_{2,861 (± 0.00%)}	_{2,861 (± 0.00%)}	_~	_2,861	_2,861	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{412ms (± 1.42%)}	_{410ms (± 0.98%)}	_~	_407ms	_416ms	_{p=0.375 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₄₆	₆
_Baseline	_main	₆

Startup

Comparison Report - main..53346

_Metric	_main	₅₃₃₄₆	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.19ms (± 0.18%)}	_{141.82ms (± 0.21%)}	_{+0.62ms (+ 0.44%)}	_141.06ms	_145.67ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{226.11ms (± 0.18%)}	_{227.22ms (± 0.19%)}	_{+1.11ms (+ 0.49%)}	_226.20ms	_234.19ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{227.89ms (± 0.15%)}	_{229.05ms (± 0.17%)}	_{+1.17ms (+ 0.51%)}	_227.97ms	_234.32ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{208.82ms (± 0.15%)}	_{209.64ms (± 0.18%)}	_{+0.82ms (+ 0.39%)}	_208.71ms	_216.39ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₄₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Mar 19 '23 06:03 typescript-bot

@typescript-bot perf test this faster

Mar 19 '23 16:03 jakebailey

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 8a6ba6dbe85ac4d3e9e1e196b981dc8c6790d169. You can monitor the build here.

Mar 19 '23 16:03 typescript-bot

@typescript-bot perf test this faster

Mar 19 '23 17:03 jakebailey

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at b8d36647f2166c32f16fd8d0730e04db2f29a947. You can monitor the build here.

Update: The results are in!

Mar 19 '23 17:03 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53346

_Metric	_main	₅₃₃₄₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,130k (± 0.01%)}	_{361,113k (± 0.01%)}	_~	_361,069k	_361,155k	_{p=0.336 n=6}
_{Parse Time}	_{3.54s (± 0.64%)}	_{3.56s (± 0.41%)}	_~	_3.54s	_3.58s	_{p=0.120 n=6}
_{Bind Time}	_{1.18s (± 0.46%)}	_{1.19s (± 0.98%)}	_~	_1.18s	_1.21s	_{p=0.342 n=6}
_{Check Time}	_{9.50s (± 0.57%)}	_{9.56s (± 0.57%)}	_~	_9.49s	_9.62s	_{p=0.091 n=6}
_{Emit Time}	_{7.94s (± 0.74%)}	_{8.00s (± 0.63%)}	_~	_7.92s	_8.05s	_{p=0.170 n=6}
_{Total Time}	_{22.16s (± 0.40%)}	_{22.31s (± 0.45%)}	_{+0.15s (+ 0.66%)}	_22.16s	_22.41s	_{p=0.045 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,596k (± 0.02%)}	_{186,371k (± 0.74%)}	_{🟩-6,225k (- 3.23%)}	_185,763k	_189,172k	_{p=0.005 n=6}
_{Parse Time}	_{1.56s (± 1.62%)}	_{1.58s (± 1.13%)}	_~	_1.55s	_1.60s	_{p=0.191 n=6}
_{Bind Time}	_{0.82s (± 0.92%)}	_{0.83s (± 0.49%)}	_{+0.01s (+ 1.22%)}	_0.82s	_0.83s	_{p=0.029 n=6}
_{Check Time}	_{10.08s (± 0.63%)}	_{10.06s (± 0.40%)}	_~	_9.99s	_10.10s	_{p=0.572 n=6}
_{Emit Time}	_{2.97s (± 0.72%)}	_{2.99s (± 1.46%)}	_~	_2.96s	_3.07s	_{p=0.570 n=6}
_{Total Time}	_{15.43s (± 0.56%)}	_{15.45s (± 0.13%)}	_~	_15.42s	_15.47s	_{p=0.518 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,520k (± 0.00%)}	_{345,578k (± 0.01%)}	_{+58k (+ 0.02%)}	_345,546k	_345,605k	_{p=0.005 n=6}
_{Parse Time}	_{2.73s (± 0.36%)}	_{2.75s (± 0.30%)}	_{+0.02s (+ 0.67%)}	_2.74s	_2.76s	_{p=0.008 n=6}
_{Bind Time}	_{1.09s (± 0.96%)}	_{1.09s (± 0.58%)}	_~	_1.08s	_1.10s	_{p=0.388 n=6}
_{Check Time}	_{7.67s (± 0.59%)}	_{7.75s (± 0.48%)}	_{+0.08s (+ 1.00%)}	_7.69s	_7.79s	_{p=0.020 n=6}
_{Emit Time}	_{4.44s (± 0.48%)}	_{4.47s (± 0.59%)}	_~	_4.44s	_4.50s	_{p=0.062 n=6}
_{Total Time}	_{15.93s (± 0.37%)}	_{16.06s (± 0.30%)}	_{+0.13s (+ 0.82%)}	_16.02s	_16.14s	_{p=0.005 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,823k (± 0.01%)}	_{299,815k (± 0.01%)}	_~	_299,777k	_299,853k	_{p=0.688 n=6}
_{Parse Time}	_{2.17s (± 0.45%)}	_{2.19s (± 0.48%)}	_{+0.02s (+ 0.77%)}	_2.17s	_2.20s	_{p=0.024 n=6}
_{Bind Time}	_{1.24s (± 0.79%)}	_{1.25s (± 0.94%)}	_~	_1.23s	_1.26s	_{p=0.157 n=6}
_{Check Time}	_{7.17s (± 0.43%)}	_{7.19s (± 0.39%)}	_~	_7.15s	_7.22s	_{p=0.331 n=6}
_{Emit Time}	_{4.36s (± 0.81%)}	_{4.36s (± 1.22%)}	_~	_4.30s	_4.45s	_{p=0.809 n=6}
_{Total Time}	_{14.93s (± 0.30%)}	_{14.98s (± 0.57%)}	_~	_14.89s	_15.11s	_{p=0.376 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{477,491k (± 0.01%)}	_0k	_~	_0k	_0k	_{p=1.000 n=6+0}
_{Parse Time}	_{3.22s (± 0.80%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Bind Time}	_{0.96s (± 0.57%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Check Time}	_{18.06s (± 0.47%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Emit Time}	_{0.00s (± 0.00%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Total Time}	_{22.23s (± 0.32%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,687k (± 0.01%)}	_{550,781k (± 0.02%)}	_~	_550,625k	_550,906k	_{p=0.173 n=6}
_{Parse Time}	_{3.94s (± 0.26%)}	_{3.96s (± 0.44%)}	_~	_3.95s	_3.99s	_{p=0.064 n=6}
_{Bind Time}	_{1.79s (± 0.65%)}	_{1.80s (± 0.76%)}	_~	_1.78s	_1.82s	_{p=0.117 n=6}
_{Check Time}	_{3.03s (± 0.94%)}	_{3.13s (± 1.23%)}	_{+0.10s (+ 3.30%)}	_3.08s	_3.19s	_{p=0.005 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.86s (± 0.29%)}	_{9.00s (± 0.59%)}	_{+0.14s (+ 1.64%)}	_8.92s	_9.07s	_{p=0.005 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₄₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Mar 19 '23 17:03 typescript-bot

My latest version, while clearer, turns out to be worse than the previous iteration, so I guess I'll have to revert it. Really weird.

Mar 19 '23 17:03 jakebailey

@typescript-bot perf test this faster

Mar 19 '23 17:03 jakebailey

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 21ccbb928af8e69fab48d04b5c164657231a4c31. You can monitor the build here.

Update: The results are in!

Mar 19 '23 17:03 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53346

_Metric	_main	₅₃₃₄₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,043k (± 0.01%)}	_{361,100k (± 0.01%)}	_{+57k (+ 0.02%)}	_361,076k	_361,139k	_{p=0.005 n=6}
_{Parse Time}	_{3.53s (± 0.87%)}	_{3.50s (± 0.55%)}	_~	_3.47s	_3.53s	_{p=0.071 n=6}
_{Bind Time}	_{1.18s (± 0.46%)}	_{1.18s (± 0.46%)}	_~	_1.18s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{9.48s (± 0.49%)}	_{9.51s (± 0.60%)}	_~	_9.47s	_9.62s	_{p=0.332 n=6}
_{Emit Time}	_{7.93s (± 0.82%)}	_{7.96s (± 1.30%)}	_~	_7.90s	_8.17s	_{p=0.688 n=6}
_{Total Time}	_{22.13s (± 0.53%)}	_{22.16s (± 0.76%)}	_~	_22.06s	_22.50s	_{p=0.687 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,558k (± 0.02%)}	_{185,691k (± 0.02%)}	_{🟩-6,867k (- 3.57%)}	_185,644k	_185,767k	_{p=0.005 n=6}
_{Parse Time}	_{1.59s (± 0.86%)}	_{1.56s (± 1.22%)}	_{-0.03s (- 2.09%)}	_1.53s	_1.58s	_{p=0.012 n=6}
_{Bind Time}	_{0.82s (± 0.63%)}	_{0.82s (± 1.00%)}	_~	_0.81s	_0.83s	_{p=0.140 n=6}
_{Check Time}	_{10.15s (± 0.87%)}	_{9.97s (± 0.37%)}	_{-0.18s (- 1.76%)}	_9.92s	_10.02s	_{p=0.005 n=6}
_{Emit Time}	_{3.00s (± 0.25%)}	_{3.00s (± 1.14%)}	_~	_2.97s	_3.05s	_{p=0.418 n=6}
_{Total Time}	_{15.56s (± 0.51%)}	_{15.35s (± 0.43%)}	_{-0.22s (- 1.39%)}	_15.26s	_15.44s	_{p=0.005 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,570k (± 0.01%)}	_{345,577k (± 0.00%)}	_~	_345,560k	_345,591k	_{p=0.471 n=6}
_{Parse Time}	_{2.73s (± 0.60%)}	_{2.72s (± 0.28%)}	_~	_2.71s	_2.73s	_{p=0.216 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 1.71%)}	_~	_1.08s	_1.13s	_{p=0.666 n=6}
_{Check Time}	_{7.70s (± 0.41%)}	_{7.71s (± 0.46%)}	_~	_7.68s	_7.77s	_{p=0.872 n=6}
_{Emit Time}	_{4.46s (± 0.49%)}	_{4.44s (± 0.69%)}	_~	_4.41s	_4.49s	_{p=0.226 n=6}
_{Total Time}	_{15.98s (± 0.35%)}	_{15.96s (± 0.33%)}	_~	_15.91s	_16.04s	_{p=0.630 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,817k (± 0.01%)}	_{299,821k (± 0.01%)}	_~	_299,771k	_299,860k	_{p=0.810 n=6}
_{Parse Time}	_{2.17s (± 0.54%)}	_{2.17s (± 0.48%)}	_~	_2.15s	_2.18s	_{p=0.406 n=6}
_{Bind Time}	_{1.24s (± 0.97%)}	_{1.25s (± 0.65%)}	_~	_1.24s	_1.26s	_{p=0.677 n=6}
_{Check Time}	_{7.17s (± 0.54%)}	_{7.16s (± 0.65%)}	_~	_7.09s	_7.21s	_{p=0.684 n=6}
_{Emit Time}	_{4.34s (± 0.63%)}	_{4.33s (± 0.34%)}	_~	_4.31s	_4.35s	_{p=0.250 n=6}
_{Total Time}	_{14.93s (± 0.24%)}	_{14.90s (± 0.40%)}	_~	_14.82s	_14.97s	_{p=0.421 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,408k (± 0.01%)}	_0k	_~	_0k	_0k	_{p=1.000 n=6+0}
_{Parse Time}	_{3.21s (± 0.61%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Bind Time}	_{0.95s (± 0.43%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Check Time}	_{17.91s (± 0.86%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Emit Time}	_{0.00s (± 0.00%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Total Time}	_{22.08s (± 0.62%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,624k (± 0.02%)}	_{550,798k (± 0.03%)}	_{+175k (+ 0.03%)}	_550,613k	_551,006k	_{p=0.031 n=6}
_{Parse Time}	_{3.95s (± 0.16%)}	_{3.94s (± 0.25%)}	_~	_3.93s	_3.95s	_{p=0.103 n=6}
_{Bind Time}	_{1.80s (± 0.29%)}	_{1.79s (± 0.93%)}	_~	_1.76s	_1.81s	_{p=0.437 n=6}
_{Check Time}	_{3.04s (± 0.34%)}	_{3.12s (± 0.59%)}	_{+0.08s (+ 2.80%)}	_3.10s	_3.14s	_{p=0.005 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.88s (± 0.17%)}	_{8.95s (± 0.13%)}	_{+0.08s (+ 0.84%)}	_8.94s	_8.97s	_{p=0.005 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₄₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Mar 19 '23 19:03 typescript-bot

@typescript-bot test this @typescript-bot test top100 @typescript-bot user test this @typescript-bot run dt @typescript-bot perf test this faster

Mar 19 '23 19:03 jakebailey

Heya @jakebailey, I've started to run the extended test suite on this PR at 21ccbb928af8e69fab48d04b5c164657231a4c31. You can monitor the build here.

Mar 19 '23 19:03 typescript-bot

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 21ccbb928af8e69fab48d04b5c164657231a4c31. You can monitor the build here.

Update: The results are in!

Mar 19 '23 19:03 typescript-bot

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 21ccbb928af8e69fab48d04b5c164657231a4c31. You can monitor the build here.

Update: The results are in!

Mar 19 '23 19:03 typescript-bot

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 21ccbb928af8e69fab48d04b5c164657231a4c31. You can monitor the build here.

Update: The results are in!

Mar 19 '23 19:03 typescript-bot

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 21ccbb928af8e69fab48d04b5c164657231a4c31. You can monitor the build here.

Update: The results are in!

Mar 19 '23 19:03 typescript-bot

That being said, this may be DOA because it does seem to slow down xstate and upstream mui a little bit. Not sure.

Mar 19 '23 19:03 jakebailey

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53346/merge:

Everything looks good!

Mar 19 '23 19:03 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53346

_Metric	_main	₅₃₃₄₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,043k (± 0.01%)}	_{361,125k (± 0.01%)}	_{+82k (+ 0.02%)}	_361,078k	_361,158k	_{p=0.005 n=6}
_{Parse Time}	_{3.53s (± 0.87%)}	_{3.52s (± 0.43%)}	_~	_3.51s	_3.55s	_{p=1.000 n=6}
_{Bind Time}	_{1.18s (± 0.46%)}	_{1.18s (± 0.46%)}	_~	_1.18s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{9.48s (± 0.49%)}	_{9.52s (± 0.26%)}	_~	_9.49s	_9.55s	_{p=0.126 n=6}
_{Emit Time}	_{7.93s (± 0.82%)}	_{7.95s (± 0.87%)}	_~	_7.87s	_8.06s	_{p=0.520 n=6}
_{Total Time}	_{22.13s (± 0.53%)}	_{22.18s (± 0.46%)}	_~	_22.06s	_22.33s	_{p=0.470 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,558k (± 0.02%)}	_{185,698k (± 0.02%)}	_{🟩-6,860k (- 3.56%)}	_185,658k	_185,770k	_{p=0.005 n=6}
_{Parse Time}	_{1.59s (± 0.86%)}	_{1.58s (± 0.69%)}	_~	_1.57s	_1.59s	_{p=0.090 n=6}
_{Bind Time}	_{0.82s (± 0.63%)}	_{0.82s (± 0.77%)}	_~	_0.81s	_0.83s	_{p=0.386 n=6}
_{Check Time}	_{10.15s (± 0.87%)}	_{10.01s (± 0.78%)}	_{-0.14s (- 1.38%)}	_9.87s	_10.07s	_{p=0.043 n=6}
_{Emit Time}	_{3.00s (± 0.25%)}	_{2.98s (± 0.99%)}	_~	_2.94s	_3.02s	_{p=0.141 n=6}
_{Total Time}	_{15.56s (± 0.51%)}	_{15.38s (± 0.56%)}	_{-0.18s (- 1.17%)}	_15.22s	_15.46s	_{p=0.005 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,570k (± 0.01%)}	_{345,578k (± 0.00%)}	_~	_345,557k	_345,591k	_{p=0.378 n=6}
_{Parse Time}	_{2.73s (± 0.60%)}	_{2.73s (± 0.57%)}	_~	_2.72s	_2.76s	_{p=0.742 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 0.69%)}	_~	_1.08s	_1.10s	_{p=0.241 n=6}
_{Check Time}	_{7.70s (± 0.41%)}	_{7.71s (± 0.43%)}	_~	_7.67s	_7.76s	_{p=0.518 n=6}
_{Emit Time}	_{4.46s (± 0.49%)}	_{4.44s (± 0.37%)}	_~	_4.42s	_4.46s	_{p=0.466 n=6}
_{Total Time}	_{15.98s (± 0.35%)}	_{15.97s (± 0.27%)}	_~	_15.92s	_16.03s	_{p=0.936 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,817k (± 0.01%)}	_{299,833k (± 0.01%)}	_~	_299,786k	_299,875k	_{p=0.378 n=6}
_{Parse Time}	_{2.17s (± 0.54%)}	_{2.17s (± 0.71%)}	_~	_2.16s	_2.19s	_{p=0.666 n=6}
_{Bind Time}	_{1.24s (± 0.97%)}	_{1.24s (± 0.97%)}	_~	_1.23s	_1.26s	_{p=1.000 n=6}
_{Check Time}	_{7.17s (± 0.54%)}	_{7.14s (± 0.82%)}	_~	_7.07s	_7.21s	_{p=0.373 n=6}
_{Emit Time}	_{4.34s (± 0.63%)}	_{4.32s (± 0.97%)}	_~	_4.28s	_4.39s	_{p=0.226 n=6}
_{Total Time}	_{14.93s (± 0.24%)}	_{14.87s (± 0.75%)}	_~	_14.75s	_15.03s	_{p=0.423 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,408k (± 0.01%)}	_0k	_~	_0k	_0k	_{p=1.000 n=6+0}
_{Parse Time}	_{3.21s (± 0.61%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Bind Time}	_{0.95s (± 0.43%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Check Time}	_{17.91s (± 0.86%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Emit Time}	_{0.00s (± 0.00%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{Total Time}	_{22.08s (± 0.62%)}	_0.00s	_~	_0.00s	_0.00s	_{p=1.000 n=6+0}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,624k (± 0.02%)}	_{550,767k (± 0.03%)}	_~	_550,568k	_550,982k	_{p=0.128 n=6}
_{Parse Time}	_{3.95s (± 0.16%)}	_{3.95s (± 0.41%)}	_~	_3.93s	_3.97s	_{p=0.935 n=6}
_{Bind Time}	_{1.80s (± 0.29%)}	_{1.79s (± 0.30%)}	_~	_1.79s	_1.80s	_{p=0.640 n=6}
_{Check Time}	_{3.04s (± 0.34%)}	_{3.13s (± 1.12%)}	_{+0.09s (+ 2.91%)}	_3.06s	_3.15s	_{p=0.005 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.88s (± 0.17%)}	_{8.97s (± 0.46%)}	_{+0.09s (+ 1.01%)}	_8.90s	_9.02s	_{p=0.004 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₄₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Mar 19 '23 20:03 typescript-bot

material-ui (the perf test) actually fails to compile in the above, uh oh.

Mar 19 '23 20:03 jakebailey

>> TypeError: Generator is already running
>>     at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
>>     at iteratePropertiesOfUnionOrIntersectionType (/home/setup/vsts-agent/_work/9/s/built/local/tsc.js:53449:16)
>>     at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
>>     at someIterator (/home/setup/vsts-agent/_work/9/s/built/local/tsc.js:396:14)

eek! This implies that getPropertiesOfUnionOrIntersectionType depended on getPropertiesOfUnionOrIntersectionType for the same type. How was this working before?

Mar 19 '23 20:03 jakebailey

Hey @jakebailey, the results of running the DT tests are ready. There were interesting changes:

Branch only errors:

Package: react-native/v0.70 Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native/v0.66 Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-google-signin Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-htmlview Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-modalbox Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-sortable-list Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-table-component Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-primitives Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native/v0.69 Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native/v0.65 Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-ad-manager Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-modals Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-popup-dialog Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-qrcode Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native/v0.68 Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native/v0.64 Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-charts-wrapper Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-material-ripple Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-snap-carousel Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native/v0.67 Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native/v0.63 Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-settings-list Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

Package: react-native-signature-capture Error:

TypeError: Generator is already running
    at iteratePropertiesOfUnionOrIntersectionTypeWorker.next (<anonymous>)
    at iteratePropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55856:18)
    at iteratePropertiesOfUnionOrIntersectionType.next (<anonymous>)
    at getPropertiesOfUnionOrIntersectionType (/home/vsts/work/1/s/built/local/typescript.js:55835:20)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:63)
    at forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType (/home/vsts/work/1/s/built/local/typescript.js:55623:26)
    at resolveMappedTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55650:9)
    at resolveStructuredTypeMembers (/home/vsts/work/1/s/built/local/typescript.js:55804:13)
    at getPropertiesOfObjectType (/home/vsts/work/1/s/built/local/typescript.js:55820:16)
    at getPropertiesOfType (/home/vsts/work/1/s/built/local/typescript.js:55887:110)

You can check the log here.

Mar 19 '23 21:03 typescript-bot

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53346/merge:

Everything looks good!

Mar 19 '23 21:03 typescript-bot

@typescript-bot perf test this faster @typescript-bot run dt

Mar 20 '23 02:03 jakebailey

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at e6be1d47f5a307af0a480142f4e4cd1326799e63. You can monitor the build here.

Update: The results are in!

Mar 20 '23 02:03 typescript-bot

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at e6be1d47f5a307af0a480142f4e4cd1326799e63. You can monitor the build here.

Update: The results are in!

Mar 20 '23 02:03 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53346

_Metric	_main	₅₃₃₄₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,043k (± 0.01%)}	_{361,132k (± 0.01%)}	_{+89k (+ 0.02%)}	_361,094k	_361,155k	_{p=0.005 n=6}
_{Parse Time}	_{3.53s (± 0.87%)}	_{3.51s (± 0.47%)}	_~	_3.49s	_3.52s	_{p=0.167 n=6}
_{Bind Time}	_{1.18s (± 0.46%)}	_{1.18s (± 0.76%)}	_~	_1.17s	_1.19s	_{p=0.341 n=6}
_{Check Time}	_{9.48s (± 0.49%)}	_{9.52s (± 0.27%)}	_~	_9.48s	_9.55s	_{p=0.108 n=6}
_{Emit Time}	_{7.93s (± 0.82%)}	_{7.96s (± 0.73%)}	_~	_7.87s	_8.03s	_{p=0.470 n=6}
_{Total Time}	_{22.13s (± 0.53%)}	_{22.16s (± 0.34%)}	_~	_22.05s	_22.25s	_{p=0.573 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,558k (± 0.02%)}	_{186,258k (± 0.74%)}	_{🟩-6,300k (- 3.27%)}	_185,642k	_189,077k	_{p=0.005 n=6}
_{Parse Time}	_{1.59s (± 0.86%)}	_{1.59s (± 0.51%)}	_~	_1.58s	_1.60s	_{p=0.282 n=6}
_{Bind Time}	_{0.82s (± 0.63%)}	_{0.81s (± 0.63%)}	_{-0.01s (- 1.21%)}	_0.81s	_0.82s	_{p=0.018 n=6}
_{Check Time}	_{10.15s (± 0.87%)}	_{9.94s (± 0.56%)}	_{-0.21s (- 2.07%)}	_9.88s	_10.02s	_{p=0.005 n=6}
_{Emit Time}	_{3.00s (± 0.25%)}	_{2.98s (± 0.78%)}	_{-0.02s (- 0.78%)}	_2.95s	_3.00s	_{p=0.045 n=6}
_{Total Time}	_{15.56s (± 0.51%)}	_{15.32s (± 0.41%)}	_{-0.25s (- 1.60%)}	_15.25s	_15.40s	_{p=0.005 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,570k (± 0.01%)}	_{345,589k (± 0.01%)}	_~	_345,566k	_345,613k	_{p=0.128 n=6}
_{Parse Time}	_{2.73s (± 0.60%)}	_{2.72s (± 0.50%)}	_~	_2.70s	_2.74s	_{p=0.328 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 0.00%)}	_~	_1.09s	_1.09s	_{p=0.174 n=6}
_{Check Time}	_{7.70s (± 0.41%)}	_{7.70s (± 0.52%)}	_~	_7.65s	_7.75s	_{p=0.872 n=6}
_{Emit Time}	_{4.46s (± 0.49%)}	_{4.43s (± 0.71%)}	_~	_4.41s	_4.49s	_{p=0.145 n=6}
_{Total Time}	_{15.98s (± 0.35%)}	_{15.95s (± 0.32%)}	_~	_15.87s	_16.00s	_{p=0.295 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,817k (± 0.01%)}	_{299,818k (± 0.01%)}	_~	_299,765k	_299,880k	_{p=0.936 n=6}
_{Parse Time}	_{2.17s (± 0.54%)}	_{2.16s (± 0.35%)}	_~	_2.15s	_2.17s	_{p=0.150 n=6}
_{Bind Time}	_{1.24s (± 0.97%)}	_{1.24s (± 0.85%)}	_~	_1.22s	_1.25s	_{p=0.282 n=6}
_{Check Time}	_{7.17s (± 0.54%)}	_{7.16s (± 0.45%)}	_~	_7.12s	_7.20s	_{p=0.747 n=6}
_{Emit Time}	_{4.34s (± 0.63%)}	_{4.33s (± 0.69%)}	_~	_4.29s	_4.36s	_{p=1.000 n=6}
_{Total Time}	_{14.93s (± 0.24%)}	_{14.89s (± 0.29%)}	_~	_14.84s	_14.95s	_{p=0.173 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,408k (± 0.01%)}	_{476,715k (± 0.01%)}	_{+307k (+ 0.06%)}	_476,653k	_476,774k	_{p=0.005 n=6}
_{Parse Time}	_{3.21s (± 0.61%)}	_{3.23s (± 0.54%)}	_~	_3.20s	_3.25s	_{p=0.243 n=6}
_{Bind Time}	_{0.95s (± 0.43%)}	_{0.95s (± 0.43%)}	_~	_0.95s	_0.96s	_{p=1.000 n=6}
_{Check Time}	_{17.91s (± 0.86%)}	_{18.04s (± 0.26%)}	_~	_18.00s	_18.11s	_{p=0.065 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.08s (± 0.62%)}	_{22.23s (± 0.24%)}	_~	_22.16s	_22.31s	_{p=0.065 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,624k (± 0.02%)}	_{550,735k (± 0.02%)}	_~	_550,634k	_550,963k	_{p=0.128 n=6}
_{Parse Time}	_{3.95s (± 0.16%)}	_{3.94s (± 0.35%)}	_~	_3.92s	_3.96s	_{p=0.073 n=6}
_{Bind Time}	_{1.80s (± 0.29%)}	_{1.79s (± 0.76%)}	_~	_1.77s	_1.81s	_{p=0.794 n=6}
_{Check Time}	_{3.04s (± 0.34%)}	_{3.12s (± 0.45%)}	_{+0.08s (+ 2.74%)}	_3.10s	_3.14s	_{p=0.005 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 4.45%)}	_~	_0.09s	_0.10s	_{p=0.405 n=6}
_{Total Time}	_{8.88s (± 0.17%)}	_{8.94s (± 0.36%)}	_{+0.07s (+ 0.75%)}	_8.89s	_8.98s	_{p=0.008 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₄₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Mar 20 '23 02:03 typescript-bot

Hey @jakebailey, the results of running the DT tests are ready. Everything looks the same! You can check the log here.

Mar 20 '23 04:03 typescript-bot