TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Revert structuredTypeRelatedTo change and fix isUnitLikeType

Open ahejlsberg opened this issue 2 years ago • 15 comments

Fixes #51009. Fixes #51041.

Ref: https://github.com/microsoft/TypeScript/pull/50735

ahejlsberg avatar Oct 05 '22 20:10 ahejlsberg

@typescript-bot test this @typescript-bot user test this inline @typescript-bot run dt @typescript-bot perf test faster @typescript-bot test top100

ahejlsberg avatar Oct 05 '22 20:10 ahejlsberg

Heya @ahejlsberg, I've started to run the extended test suite on this PR at e363198a94e86ee11ac059b53d2e2a697bafd699. You can monitor the build here.

typescript-bot avatar Oct 05 '22 20:10 typescript-bot

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at e363198a94e86ee11ac059b53d2e2a697bafd699. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Oct 05 '22 20:10 typescript-bot

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at e363198a94e86ee11ac059b53d2e2a697bafd699. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Oct 05 '22 20:10 typescript-bot

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at e363198a94e86ee11ac059b53d2e2a697bafd699. You can monitor the build here.

typescript-bot avatar Oct 05 '22 20:10 typescript-bot

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at e363198a94e86ee11ac059b53d2e2a697bafd699. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Oct 05 '22 20:10 typescript-bot

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/51076/merge:

Something interesting changed - please have a look.

Details

puppeteer

tsconfig.base.json

  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/commitlint.config.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/docker/test/smoke-test.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/block-images.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/cross-browser.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/custom-event.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/detect-sniff.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/oopif.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/pdf.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/proxy.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/screenshot-fullpage.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/screenshot.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/examples/search.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/cjs/puppeteer/compat.d.ts' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/cjs/puppeteer/compat.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/cjs/third_party/mitt/index.d.ts' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/cjs/third_party/mitt/index.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/esm/puppeteer/compat.d.ts' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/esm/puppeteer/compat.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/esm/third_party/mitt/index.d.ts' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/lib/esm/third_party/mitt/index.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer-core/rollup.third_party.config.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/puppeteer/install.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/testserver/lib/index.d.ts' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/packages/testserver/lib/index.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/es6/es6import.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/es6/es6module.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/es6/es6pathimport.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/frames/script.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/initiator.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/injectedfile.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/input/mouse-helper.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/jscoverage/script1.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/jscoverage/script2.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/modernizr.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/serviceworkers/empty/sw.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/serviceworkers/extension/background.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/serviceworkers/fetch/sw.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/simple-extension/content-script.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/simple-extension/index.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/assets/worker/worker.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/fixtures/closeme.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/test/fixtures/dumpio.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/bisect.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/check_availability.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/generate-matrix.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/get_deprecated_version_range.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/interface.d.ts' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/interface.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/main.d.ts' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/main.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/reporter.d.ts' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/reporter.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/test.d.ts' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/test.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/types.d.ts' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/types.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/utils.d.ts' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/mochaRunner/lib/utils.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/utils/remove_version_suffix.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/versions.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/website/archive.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/website/babel.config.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/website/docusaurus.config.js' because it would overwrite input file.
  • [MISSING] error TS5055: Cannot write file '/mnt/ts_downloads/puppeteer/website/static/sw.js' because it would overwrite input file.

typescript-bot avatar Oct 05 '22 21:10 typescript-bot

Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot avatar Oct 05 '22 21:10 typescript-bot

@ahejlsberg The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51076

Metric main 51076 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 346,862k (± 0.01%) 346,890k (± 0.01%) +28k (+ 0.01%) 346,832k 346,977k
Parse Time 2.08s (± 0.81%) 2.12s (± 0.95%) +0.04s (+ 1.92%) 2.07s 2.15s
Bind Time 0.80s (± 0.43%) 0.79s (± 0.75%) -0.00s (- 0.38%) 0.78s 0.81s
Check Time 5.95s (± 0.49%) 5.95s (± 0.56%) +0.00s (+ 0.07%) 5.91s 6.06s
Emit Time 6.26s (± 0.60%) 6.24s (± 0.63%) -0.02s (- 0.32%) 6.17s 6.35s
Total Time 15.08s (± 0.37%) 15.10s (± 0.28%) +0.02s (+ 0.15%) 15.01s 15.19s
Compiler-Unions - node (v14.15.1, x64)
Memory used 190,198k (± 0.01%) 190,166k (± 0.01%) -32k (- 0.02%) 190,103k 190,218k
Parse Time 0.86s (± 0.69%) 0.86s (± 1.05%) +0.01s (+ 0.58%) 0.84s 0.88s
Bind Time 0.49s (± 0.70%) 0.49s (± 0.77%) -0.00s (- 0.41%) 0.48s 0.49s
Check Time 6.72s (± 0.58%) 6.74s (± 0.45%) +0.01s (+ 0.22%) 6.69s 6.82s
Emit Time 2.40s (± 0.62%) 2.39s (± 0.39%) -0.02s (- 0.62%) 2.37s 2.41s
Total Time 10.47s (± 0.44%) 10.47s (± 0.34%) +0.00s (+ 0.04%) 10.42s 10.56s
Monaco - node (v14.15.1, x64)
Memory used 326,591k (± 0.01%) 326,583k (± 0.01%) -8k (- 0.00%) 326,519k 326,626k
Parse Time 1.59s (± 0.70%) 1.58s (± 0.41%) -0.00s (- 0.19%) 1.57s 1.59s
Bind Time 0.73s (± 0.89%) 0.73s (± 0.61%) +0.00s (+ 0.55%) 0.72s 0.74s
Check Time 5.74s (± 0.55%) 5.75s (± 0.51%) +0.02s (+ 0.26%) 5.70s 5.82s
Emit Time 3.38s (± 0.89%) 3.36s (± 0.63%) -0.02s (- 0.62%) 3.31s 3.40s
Total Time 11.43s (± 0.48%) 11.43s (± 0.37%) -0.00s (- 0.03%) 11.35s 11.54s
TFS - node (v14.15.1, x64)
Memory used 289,716k (± 0.01%) 289,704k (± 0.00%) -12k (- 0.00%) 289,677k 289,735k
Parse Time 1.30s (± 0.77%) 1.30s (± 0.63%) -0.00s (- 0.23%) 1.28s 1.31s
Bind Time 0.79s (± 1.45%) 0.79s (± 0.43%) 0.00s ( 0.00%) 0.79s 0.80s
Check Time 5.40s (± 0.54%) 5.40s (± 0.50%) -0.00s (- 0.02%) 5.33s 5.46s
Emit Time 3.61s (± 0.40%) 3.60s (± 0.73%) -0.01s (- 0.28%) 3.55s 3.67s
Total Time 11.10s (± 0.41%) 11.09s (± 0.33%) -0.01s (- 0.08%) 11.02s 11.16s
material-ui - node (v14.15.1, x64)
Memory used 435,481k (± 0.07%) 435,673k (± 0.01%) +192k (+ 0.04%) 435,609k 435,727k
Parse Time 1.89s (± 0.47%) 1.88s (± 0.84%) -0.01s (- 0.27%) 1.86s 1.93s
Bind Time 0.58s (± 1.02%) 0.58s (± 0.58%) -0.00s (- 0.34%) 0.58s 0.59s
Check Time 12.93s (± 0.84%) 12.91s (± 0.66%) -0.02s (- 0.13%) 12.75s 13.11s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.40s (± 0.70%) 15.37s (± 0.60%) -0.03s (- 0.17%) 15.19s 15.55s
xstate - node (v14.15.1, x64)
Memory used 544,085k (± 0.00%) 544,074k (± 0.00%) -11k (- 0.00%) 544,022k 544,123k
Parse Time 2.61s (± 0.31%) 2.62s (± 0.37%) +0.01s (+ 0.42%) 2.60s 2.64s
Bind Time 0.98s (± 0.96%) 0.97s (± 0.62%) -0.01s (- 1.13%) 0.95s 0.98s
Check Time 1.52s (± 0.51%) 1.51s (± 0.45%) -0.01s (- 0.39%) 1.50s 1.53s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.19s (± 0.25%) 5.18s (± 0.27%) -0.01s (- 0.17%) 5.15s 5.20s
Angular - node (v10.16.3, x64)
Memory used 371,315k (± 0.02%) 371,366k (± 0.03%) +51k (+ 0.01%) 371,238k 371,681k
Parse Time 2.09s (± 0.55%) 2.09s (± 0.84%) -0.01s (- 0.29%) 2.06s 2.14s
Bind Time 0.78s (± 0.83%) 0.79s (± 1.18%) +0.01s (+ 0.77%) 0.77s 0.82s
Check Time 6.30s (± 0.42%) 6.29s (± 0.45%) -0.01s (- 0.10%) 6.25s 6.38s
Emit Time 6.09s (± 0.49%) 6.06s (± 0.65%) -0.02s (- 0.39%) 6.00s 6.15s
Total Time 15.26s (± 0.32%) 15.23s (± 0.46%) -0.03s (- 0.22%) 15.12s 15.39s
Compiler-Unions - node (v10.16.3, x64)
Memory used 206,323k (± 0.04%) 206,340k (± 0.03%) +17k (+ 0.01%) 206,129k 206,456k
Parse Time 0.84s (± 0.95%) 0.84s (± 0.87%) -0.00s (- 0.48%) 0.82s 0.85s
Bind Time 0.47s (± 1.00%) 0.47s (± 1.00%) +0.00s (+ 0.00%) 0.46s 0.48s
Check Time 8.47s (± 0.49%) 8.45s (± 0.59%) -0.02s (- 0.22%) 8.30s 8.55s
Emit Time 2.47s (± 1.90%) 2.47s (± 1.27%) -0.00s (- 0.08%) 2.38s 2.53s
Total Time 12.25s (± 0.60%) 12.23s (± 0.43%) -0.02s (- 0.20%) 12.11s 12.33s
Monaco - node (v10.16.3, x64)
Memory used 344,850k (± 0.02%) 344,829k (± 0.02%) -22k (- 0.01%) 344,704k 344,958k
Parse Time 1.61s (± 0.51%) 1.60s (± 0.81%) -0.00s (- 0.06%) 1.56s 1.63s
Bind Time 0.70s (± 0.57%) 0.71s (± 1.26%) +0.01s (+ 0.71%) 0.70s 0.74s
Check Time 6.23s (± 0.51%) 6.21s (± 0.65%) -0.02s (- 0.37%) 6.12s 6.30s
Emit Time 3.25s (± 0.71%) 3.25s (± 1.35%) -0.00s (- 0.15%) 3.17s 3.39s
Total Time 11.79s (± 0.38%) 11.76s (± 0.47%) -0.02s (- 0.17%) 11.64s 11.88s
TFS - node (v10.16.3, x64)
Memory used 306,092k (± 0.03%) 306,067k (± 0.02%) -25k (- 0.01%) 305,914k 306,264k
Parse Time 1.29s (± 0.54%) 1.30s (± 0.81%) +0.01s (+ 0.46%) 1.27s 1.32s
Bind Time 0.67s (± 0.60%) 0.68s (± 0.54%) +0.00s (+ 0.75%) 0.67s 0.68s
Check Time 5.52s (± 0.58%) 5.50s (± 0.58%) -0.02s (- 0.33%) 5.43s 5.57s
Emit Time 3.43s (± 1.06%) 3.43s (± 1.51%) -0.00s (- 0.12%) 3.32s 3.53s
Total Time 10.91s (± 0.56%) 10.89s (± 0.51%) -0.02s (- 0.16%) 10.76s 11.01s
material-ui - node (v10.16.3, x64)
Memory used 458,135k (± 0.01%) 458,166k (± 0.02%) +30k (+ 0.01%) 458,010k 458,405k
Parse Time 1.82s (± 0.88%) 1.84s (± 0.72%) +0.01s (+ 0.82%) 1.81s 1.87s
Bind Time 0.58s (± 2.06%) 0.57s (± 1.89%) -0.01s (- 1.56%) 0.55s 0.59s
Check Time 15.69s (± 0.94%) 15.54s (± 0.50%) -0.15s (- 0.96%) 15.39s 15.74s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.09s (± 0.84%) 17.95s (± 0.44%) -0.14s (- 0.79%) 17.79s 18.14s
xstate - node (v10.16.3, x64)
Memory used 581,111k (± 0.01%) 581,032k (± 0.01%) -78k (- 0.01%) 580,896k 581,186k
Parse Time 2.61s (± 0.52%) 2.60s (± 0.29%) -0.01s (- 0.23%) 2.59s 2.62s
Bind Time 0.90s (± 0.62%) 0.90s (± 0.78%) -0.00s (- 0.33%) 0.89s 0.92s
Check Time 1.60s (± 0.42%) 1.61s (± 0.62%) +0.01s (+ 0.63%) 1.59s 1.64s
Emit Time 0.07s (± 4.13%) 0.07s (± 4.13%) 0.00s ( 0.00%) 0.07s 0.08s
Total Time 5.19s (± 0.39%) 5.19s (± 0.27%) +0.00s (+ 0.04%) 5.16s 5.23s
Angular - node (v12.1.0, x64)
Memory used 348,864k (± 0.02%) 348,564k (± 0.10%) -300k (- 0.09%) 347,606k 348,862k
Parse Time 2.10s (± 0.45%) 2.10s (± 0.57%) +0.00s (+ 0.19%) 2.07s 2.13s
Bind Time 0.77s (± 0.68%) 0.76s (± 0.65%) -0.00s (- 0.52%) 0.76s 0.78s
Check Time 5.95s (± 0.42%) 5.99s (± 0.76%) +0.04s (+ 0.60%) 5.88s 6.09s
Emit Time 6.32s (± 0.80%) 6.33s (± 0.83%) +0.01s (+ 0.13%) 6.24s 6.46s
Total Time 15.14s (± 0.40%) 15.19s (± 0.58%) +0.05s (+ 0.30%) 15.00s 15.38s
Compiler-Unions - node (v12.1.0, x64)
Memory used 193,548k (± 0.28%) 194,051k (± 0.14%) +503k (+ 0.26%) 193,380k 194,449k
Parse Time 0.84s (± 1.32%) 0.83s (± 0.98%) -0.01s (- 0.84%) 0.81s 0.85s
Bind Time 0.47s (± 0.94%) 0.47s (± 0.78%) +0.00s (+ 0.64%) 0.47s 0.48s
Check Time 6.72s (± 0.76%) 6.75s (± 0.60%) +0.02s (+ 0.36%) 6.63s 6.82s
Emit Time 2.47s (± 1.12%) 2.46s (± 1.19%) -0.01s (- 0.20%) 2.42s 2.53s
Total Time 10.50s (± 0.65%) 10.51s (± 0.46%) +0.01s (+ 0.12%) 10.43s 10.62s
Monaco - node (v12.1.0, x64)
Memory used 327,799k (± 0.02%) 327,825k (± 0.01%) +26k (+ 0.01%) 327,723k 327,921k
Parse Time 1.59s (± 0.96%) 1.60s (± 0.97%) +0.01s (+ 0.76%) 1.57s 1.64s
Bind Time 0.69s (± 0.86%) 0.70s (± 0.92%) +0.01s (+ 1.01%) 0.69s 0.72s
Check Time 5.83s (± 0.33%) 5.86s (± 0.33%) +0.03s (+ 0.45%) 5.82s 5.90s
Emit Time 3.32s (± 0.57%) 3.35s (± 0.68%) +0.03s (+ 0.81%) 3.28s 3.39s
Total Time 11.44s (± 0.27%) 11.51s (± 0.20%) +0.07s (+ 0.65%) 11.46s 11.55s
TFS - node (v12.1.0, x64)
Memory used 290,711k (± 0.07%) 290,714k (± 0.03%) +3k (+ 0.00%) 290,519k 291,008k
Parse Time 1.30s (± 0.63%) 1.29s (± 0.38%) -0.01s (- 0.69%) 1.28s 1.30s
Bind Time 0.68s (± 0.85%) 0.68s (± 1.07%) -0.01s (- 0.73%) 0.66s 0.69s
Check Time 5.43s (± 0.58%) 5.38s (± 0.47%) -0.04s (- 0.77%) 5.34s 5.46s
Emit Time 3.51s (± 1.06%) 3.55s (± 0.92%) +0.04s (+ 1.23%) 3.49s 3.63s
Total Time 10.92s (± 0.52%) 10.90s (± 0.37%) -0.01s (- 0.13%) 10.84s 10.99s
material-ui - node (v12.1.0, x64)
Memory used 437,443k (± 0.01%) 437,477k (± 0.01%) +34k (+ 0.01%) 437,360k 437,571k
Parse Time 1.84s (± 0.68%) 1.84s (± 0.58%) +0.00s (+ 0.16%) 1.81s 1.86s
Bind Time 0.55s (± 1.17%) 0.55s (± 0.81%) -0.00s (- 0.72%) 0.54s 0.56s
Check Time 12.76s (± 0.69%) 12.80s (± 0.83%) +0.04s (+ 0.28%) 12.65s 13.10s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.15s (± 0.62%) 15.19s (± 0.76%) +0.04s (+ 0.23%) 15.04s 15.51s
xstate - node (v12.1.0, x64)
Memory used 546,416k (± 0.02%) 546,390k (± 0.02%) -26k (- 0.00%) 546,228k 546,587k
Parse Time 2.57s (± 0.75%) 2.55s (± 0.43%) -0.02s (- 0.93%) 2.53s 2.58s
Bind Time 0.89s (± 1.02%) 0.88s (± 0.41%) -0.00s (- 0.56%) 0.88s 0.89s
Check Time 1.50s (± 0.64%) 1.49s (± 0.51%) -0.01s (- 0.93%) 1.47s 1.50s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.03s (± 0.70%) 4.99s (± 0.33%) -0.04s (- 0.86%) 4.96s 5.03s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
Benchmark Name Iterations
Current 51076 10
Baseline main 10
Developer Information:

Download Benchmark

typescript-bot avatar Oct 05 '22 21:10 typescript-bot

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/51076/merge:

Everything looks good!

typescript-bot avatar Oct 05 '22 22:10 typescript-bot

@typescript-bot user test this @typescript-bot test top100

amcasey avatar Oct 06 '22 01:10 amcasey

Heya @amcasey, I've started to run the diff-based user code test suite on this PR at e363198a94e86ee11ac059b53d2e2a697bafd699. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Oct 06 '22 01:10 typescript-bot

Heya @amcasey, I've started to run the diff-based top-repos suite on this PR at e363198a94e86ee11ac059b53d2e2a697bafd699. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Oct 06 '22 01:10 typescript-bot

@amcasey Here are the results of running the user test suite comparing main and refs/pull/51076/merge:

Everything looks good!

typescript-bot avatar Oct 06 '22 01:10 typescript-bot

@amcasey Here are the results of running the top-repos suite comparing main and refs/pull/51076/merge:

Everything looks good!

typescript-bot avatar Oct 06 '22 02:10 typescript-bot