TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Modified optional thisArg to capture type

Open RasmusAndreassen opened this issue 3 years ago • 5 comments

This change makes most method accepting a thisArg parameter generic, thus enabling them to capture the type of the parameter and properly recognising it in the callback function.

This makes it possible to write the wordy

const object = {
   test: (n:number):boolean => (n % 2) === 0,
   method: (n:number):void => console.log(n)
};

[1,2,3].forEach(
   function(this:{test:(n:number)=>boolean,method:(n:number)=>void},n) {
      if (this.test(n))
         object.method(n)
   },
   object)

as

const object = {
   test: (n:number):boolean => (n % 2) === 0,
   method: (n:number):void => console.log(n)
};

[1,2,3].forEach(
   function(n) {
      if (this.test(n))
         this.method(n)
   },
   object)

Fixes #51020

RasmusAndreassen avatar Sep 25 '22 19:09 RasmusAndreassen

@RasmusAndreassen please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

  1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to Microsoft under this Agreement. “Project” means any of the projects owned or managed by Microsoft and offered under a license approved by the Open Source Initiative (www.opensource.org). “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as “Not a Submission.” “Submission” means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as You received them, (b) in the description accompanying Your Submission, include the phrase “Submission containing materials of a third party:” followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project’s written guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term “You” in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect.
  3. Information about Submissions. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

microsoft-github-policy-service[bot] avatar Sep 25 '22 19:09 microsoft-github-policy-service[bot]

@microsoft-github-policy-service agree

RasmusAndreassen avatar Sep 25 '22 19:09 RasmusAndreassen

This partially re-adds the changes of #12784, which were removed in #16223 again for performance reasons:

the removal of the generic signatures saves a good chunk of time of building the compiler and some 30 K symbols created.

MartinJohns avatar Oct 01 '22 09:10 MartinJohns

@sandersn To be fair, that was five years ago. Things might have changed, making the impact less severe. But I still think this is somewhat of a rare use case.

MartinJohns avatar Oct 19 '22 08:10 MartinJohns

Things might have changed, making the impact less severe.

The only thing I can think of would be improved caching of generic instantiations, but I don't think much progress has happened there.

sandersn avatar Oct 19 '22 16:10 sandersn

@typescript-bot perf test this

sandersn avatar Mar 09 '23 23:03 sandersn

Heya @sandersn, I've started to run the perf test suite on this PR at a7bab4b3e0304d09fbc80feec3efca11df0b27fe. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Mar 09 '23 23:03 typescript-bot

@sandersn The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..50947
Metric main 50947 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 363,470k (± 0.01%) 343,549k (± 0.01%) 🟩-19,922k (- 5.48%) 343,488k 343,581k p=0.005 n=6
Parse Time 3.39s (± 0.83%) 3.89s (± 0.64%) +0.49s (+14.54%) 3.85s 3.92s p=0.005 n=6
Bind Time 1.12s (± 1.13%) 1.23s (± 0.61%) +0.11s (+ 9.97%) 1.22s 1.24s p=0.004 n=6
Check Time 8.67s (± 0.58%) 9.39s (± 0.63%) +0.72s (+ 8.32%) 9.33s 9.49s p=0.005 n=6
Emit Time 7.41s (± 0.43%) 8.20s (± 1.23%) +0.79s (+10.61%) 8.09s 8.37s p=0.005 n=6
Total Time 20.60s (± 0.37%) 22.71s (± 0.68%) +2.12s (+10.28%) 22.58s 22.99s p=0.005 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 192,830k (± 1.53%) 186,194k (± 0.03%) 🟩-6,636k (- 3.44%) 186,116k 186,266k p=0.005 n=6
Parse Time 1.50s (± 0.37%) 1.64s (± 1.02%) +0.14s (+ 9.70%) 1.62s 1.66s p=0.004 n=6
Bind Time 0.77s (± 0.53%) 0.79s (± 0.95%) +0.02s (+ 2.16%) 0.78s 0.80s p=0.005 n=6
Check Time 9.41s (± 0.94%) 10.22s (± 0.54%) +0.80s (+ 8.53%) 10.14s 10.28s p=0.005 n=6
Emit Time 2.73s (± 1.05%) 2.92s (± 0.76%) +0.18s (+ 6.70%) 2.88s 2.94s p=0.005 n=6
Total Time 14.41s (± 0.69%) 15.56s (± 0.45%) +1.15s (+ 7.98%) 15.45s 15.63s p=0.005 n=6
Monaco - node (v18.10.0, x64)
Memory used 347,417k (± 0.01%) 320,387k (± 0.01%) 🟩-27,030k (- 7.78%) 320,347k 320,417k p=0.005 n=6
Parse Time 2.58s (± 0.80%) 2.91s (± 0.51%) +0.33s (+12.87%) 2.88s 2.92s p=0.005 n=6
Bind Time 1.01s (± 0.81%) 1.11s (± 0.95%) +0.10s (+ 9.77%) 1.09s 1.12s p=0.005 n=6
Check Time 7.04s (± 0.41%) 8.09s (± 0.43%) +1.05s (+14.93%) 8.05s 8.13s p=0.005 n=6
Emit Time 4.21s (± 0.42%) 4.66s (± 0.78%) +0.45s (+10.64%) 4.60s 4.71s p=0.005 n=6
Total Time 14.84s (± 0.37%) 16.77s (± 0.44%) +1.93s (+13.01%) 16.66s 16.88s p=0.005 n=6
TFS - node (v18.10.0, x64)
Memory used 300,792k (± 0.01%) 282,712k (± 0.01%) 🟩-18,080k (- 6.01%) 282,676k 282,734k p=0.005 n=6
Parse Time 2.06s (± 1.14%) 2.27s (± 1.70%) +0.22s (+10.54%) 2.21s 2.33s p=0.005 n=6
Bind Time 1.14s (± 0.91%) 1.17s (± 0.64%) +0.03s (+ 2.79%) 1.16s 1.18s p=0.004 n=6
Check Time 6.53s (± 0.26%) 7.83s (± 0.49%) +1.30s (+19.93%) 7.79s 7.90s p=0.005 n=6
Emit Time 3.86s (± 0.70%) 4.29s (± 0.54%) +0.43s (+11.27%) 4.26s 4.32s p=0.005 n=6
Total Time 13.58s (± 0.41%) 15.56s (± 0.52%) +1.98s (+14.60%) 15.47s 15.71s p=0.005 n=6
material-ui - node (v18.10.0, x64)
Memory used 478,370k (± 0.01%) 436,942k (± 0.02%) 🟩-41,428k (- 8.66%) 436,807k 437,010k p=0.005 n=6
Parse Time 3.02s (± 2.22%) 3.35s (± 0.59%) +0.34s (+11.22%) 3.32s 3.38s p=0.005 n=6
Bind Time 0.95s (± 6.37%) 1.19s (± 1.68%) +0.24s (+25.48%) 1.17s 1.22s p=0.005 n=6
Check Time 17.13s (± 0.30%) 18.03s (± 0.34%) +0.89s (+ 5.21%) 17.94s 18.10s p=0.005 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.10s (± 0.26%) 22.58s (± 0.27%) +1.48s (+ 7.01%) 22.50s 22.67s p=0.005 n=6
xstate - node (v18.10.0, x64)
Memory used 553,160k (± 0.03%) 678,847k (± 0.02%) +125,688k (+22.72%) 678,712k 679,042k p=0.005 n=6
Parse Time 3.76s (± 0.73%) 4.55s (± 0.72%) +0.79s (+21.01%) 4.49s 4.58s p=0.005 n=6
Bind Time 1.68s (± 0.70%) 1.85s (± 1.18%) +0.17s (+10.23%) 1.81s 1.87s p=0.005 n=6
Check Time 2.76s (± 0.65%) 2.81s (± 0.35%) +0.05s (+ 1.87%) 2.80s 2.82s p=0.005 n=6
Emit Time 0.08s (± 0.00%) 0.02s (±18.82%) 🟩-0.06s (-72.92%) 0.02s 0.03s p=0.002 n=6
Total Time 8.28s (± 0.59%) 9.23s (± 0.54%) +0.95s (+11.43%) 9.13s 9.26s p=0.005 n=6
Angular - node (v16.17.1, x64)
Memory used 362,834k (± 0.01%) 342,924k (± 0.00%) 🟩-19,910k (- 5.49%) 342,901k 342,944k p=0.005 n=6
Parse Time 3.50s (± 0.55%) 4.05s (± 0.16%) +0.55s (+15.77%) 4.04s 4.06s p=0.004 n=6
Bind Time 1.18s (± 0.54%) 1.29s (± 0.58%) +0.11s (+ 9.18%) 1.28s 1.30s p=0.004 n=6
Check Time 9.41s (± 0.47%) 10.19s (± 0.43%) +0.78s (+ 8.27%) 10.13s 10.26s p=0.005 n=6
Emit Time 7.86s (± 0.35%) 8.69s (± 0.58%) +0.82s (+10.49%) 8.63s 8.76s p=0.005 n=6
Total Time 21.95s (± 0.34%) 24.21s (± 0.27%) +2.26s (+10.30%) 24.15s 24.31s p=0.005 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,702k (± 0.02%) 187,875k (± 0.01%) -4,827k (- 2.50%) 187,861k 187,903k p=0.005 n=6
Parse Time 1.57s (± 1.10%) 1.80s (± 0.00%) +0.23s (+14.77%) 1.80s 1.80s p=0.003 n=6
Bind Time 0.82s (± 0.50%) 0.83s (± 1.40%) +0.01s (+ 1.63%) 0.82s 0.85s p=0.025 n=6
Check Time 10.09s (± 0.66%) 11.21s (± 0.83%) +1.12s (+11.08%) 11.10s 11.37s p=0.005 n=6
Emit Time 2.98s (± 0.86%) 3.17s (± 0.33%) +0.19s (+ 6.37%) 3.16s 3.19s p=0.005 n=6
Total Time 15.46s (± 0.54%) 17.02s (± 0.60%) +1.56s (+10.09%) 16.90s 17.20s p=0.005 n=6
Monaco - node (v16.17.1, x64)
Memory used 346,715k (± 0.00%) 319,733k (± 0.01%) 🟩-26,982k (- 7.78%) 319,712k 319,754k p=0.005 n=6
Parse Time 2.72s (± 0.55%) 3.09s (± 0.85%) +0.36s (+13.40%) 3.06s 3.12s p=0.005 n=6
Bind Time 1.09s (± 0.75%) 1.15s (± 0.45%) +0.07s (+ 6.13%) 1.15s 1.16s p=0.003 n=6
Check Time 7.71s (± 0.25%) 8.87s (± 0.46%) +1.16s (+15.09%) 8.82s 8.93s p=0.005 n=6
Emit Time 4.45s (± 0.68%) 4.88s (± 0.75%) +0.42s (+ 9.54%) 4.82s 4.93s p=0.005 n=6
Total Time 15.97s (± 0.28%) 17.99s (± 0.39%) +2.02s (+12.66%) 17.92s 18.11s p=0.005 n=6
TFS - node (v16.17.1, x64)
Memory used 300,148k (± 0.01%) 282,069k (± 0.01%) 🟩-18,079k (- 6.02%) 282,055k 282,090k p=0.005 n=6
Parse Time 2.18s (± 0.54%) 2.48s (± 1.61%) +0.30s (+13.70%) 2.43s 2.55s p=0.005 n=6
Bind Time 1.24s (± 0.41%) 1.26s (± 0.78%) +0.02s (+ 1.21%) 1.24s 1.27s p=0.022 n=6
Check Time 7.18s (± 0.31%) 8.50s (± 0.29%) +1.31s (+18.26%) 8.47s 8.53s p=0.005 n=6
Emit Time 4.35s (± 0.92%) 4.82s (± 0.57%) +0.47s (+10.89%) 4.79s 4.87s p=0.005 n=6
Total Time 14.95s (± 0.40%) 17.05s (± 0.29%) +2.10s (+14.06%) 17.00s 17.11s p=0.005 n=6
material-ui - node (v16.17.1, x64)
Memory used 477,676k (± 0.02%) 436,282k (± 0.00%) 🟩-41,394k (- 8.67%) 436,254k 436,298k p=0.005 n=6
Parse Time 3.21s (± 0.23%) 3.59s (± 0.67%) +0.38s (+11.83%) 3.55s 3.61s p=0.004 n=6
Bind Time 0.95s (± 0.00%) 1.10s (± 1.78%) +0.15s (+16.14%) 1.08s 1.12s p=0.003 n=6
Check Time 18.02s (± 0.53%) 19.13s (± 0.77%) +1.11s (+ 6.15%) 19.02s 19.42s p=0.005 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.18s (± 0.45%) 23.83s (± 0.64%) +1.65s (+ 7.41%) 23.72s 24.13s p=0.005 n=6
xstate - node (v16.17.1, x64)
Memory used 550,643k (± 0.01%) 675,690k (± 0.01%) +125,047k (+22.71%) 675,641k 675,850k p=0.005 n=6
Parse Time 3.94s (± 0.32%) 4.71s (± 0.37%) +0.77s (+19.63%) 4.69s 4.74s p=0.005 n=6
Bind Time 1.78s (± 1.09%) 1.94s (± 0.46%) +0.16s (+ 8.89%) 1.93s 1.95s p=0.005 n=6
Check Time 2.99s (± 0.34%) 2.99s (± 0.54%) ~ 2.97s 3.01s p=0.512 n=6
Emit Time 0.09s (± 0.00%) 0.02s (± 0.00%) 🟩-0.07s (-77.78%) 0.02s 0.02s p=0.001 n=6
Total Time 8.80s (± 0.25%) 9.67s (± 0.22%) +0.86s (+ 9.83%) 9.64s 9.70s p=0.005 n=6
Angular - node (v14.15.1, x64)
Memory used 356,652k (± 0.01%) 336,504k (± 0.01%) 🟩-20,148k (- 5.65%) 336,483k 336,540k p=0.005 n=6
Parse Time 3.58s (± 0.78%) 4.16s (± 0.97%) +0.58s (+16.12%) 4.11s 4.22s p=0.005 n=6
Bind Time 1.23s (± 0.42%) 1.37s (± 0.40%) +0.13s (+10.68%) 1.36s 1.37s p=0.004 n=6
Check Time 9.73s (± 0.51%) 10.48s (± 0.45%) +0.74s (+ 7.64%) 10.39s 10.53s p=0.005 n=6
Emit Time 8.34s (± 0.65%) 8.96s (± 0.55%) +0.62s (+ 7.48%) 8.89s 9.04s p=0.005 n=6
Total Time 22.89s (± 0.38%) 24.96s (± 0.35%) +2.07s (+ 9.05%) 24.87s 25.12s p=0.005 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,927k (± 0.01%) 182,918k (± 0.01%) -5,009k (- 2.67%) 182,891k 182,948k p=0.005 n=6
Parse Time 1.59s (± 0.73%) 1.83s (± 0.45%) +0.24s (+14.76%) 1.82s 1.84s p=0.005 n=6
Bind Time 0.84s (± 0.65%) 0.88s (± 0.93%) +0.03s (+ 3.75%) 0.87s 0.89s p=0.004 n=6
Check Time 10.23s (± 0.76%) 11.17s (± 0.53%) +0.94s (+ 9.19%) 11.09s 11.26s p=0.005 n=6
Emit Time 3.11s (± 0.85%) 3.27s (± 0.56%) +0.16s (+ 5.09%) 3.24s 3.29s p=0.005 n=6
Total Time 15.78s (± 0.56%) 17.15s (± 0.36%) +1.37s (+ 8.69%) 17.09s 17.26s p=0.005 n=6
Monaco - node (v14.15.1, x64)
Memory used 341,705k (± 0.01%) 314,465k (± 0.01%) 🟩-27,240k (- 7.97%) 314,449k 314,485k p=0.005 n=6
Parse Time 2.84s (± 0.61%) 3.19s (± 1.01%) +0.34s (+12.08%) 3.13s 3.22s p=0.005 n=6
Bind Time 1.10s (± 0.47%) 1.20s (± 0.63%) +0.10s (+ 9.27%) 1.19s 1.21s p=0.004 n=6
Check Time 8.14s (± 0.45%) 9.16s (± 0.40%) +1.02s (+12.55%) 9.11s 9.20s p=0.005 n=6
Emit Time 4.68s (± 0.44%) 5.19s (± 0.50%) +0.51s (+10.94%) 5.16s 5.22s p=0.005 n=6
Total Time 16.75s (± 0.18%) 18.74s (± 0.41%) +1.98s (+11.84%) 18.61s 18.84s p=0.005 n=6
TFS - node (v14.15.1, x64)
Memory used 295,228k (± 0.00%) 277,033k (± 0.01%) 🟩-18,195k (- 6.16%) 277,013k 277,072k p=0.005 n=6
Parse Time 2.39s (± 0.82%) 2.68s (± 1.51%) +0.28s (+11.84%) 2.62s 2.73s p=0.005 n=6
Bind Time 1.06s (± 0.00%) 1.12s (± 0.67%) +0.06s (+ 5.50%) 1.11s 1.13s p=0.003 n=6
Check Time 7.48s (± 0.18%) 8.86s (± 0.25%) +1.37s (+18.33%) 8.82s 8.88s p=0.005 n=6
Emit Time 4.27s (± 1.06%) 5.09s (± 0.62%) +0.81s (+19.08%) 5.04s 5.13s p=0.005 n=6
Total Time 15.21s (± 0.22%) 17.74s (± 0.12%) +2.53s (+16.61%) 17.71s 17.77s p=0.005 n=6
material-ui - node (v14.15.1, x64)
Memory used 473,298k (± 0.00%) 431,663k (± 0.01%) 🟩-41,635k (- 8.80%) 431,626k 431,694k p=0.005 n=6
Parse Time 3.34s (± 0.64%) 3.93s (± 0.71%) +0.59s (+17.62%) 3.90s 3.96s p=0.005 n=6
Bind Time 1.00s (± 0.75%) 1.16s (± 0.77%) +0.16s (+15.81%) 1.15s 1.17s p=0.004 n=6
Check Time 18.97s (± 0.43%) 20.10s (± 0.92%) +1.13s (+ 5.96%) 19.86s 20.35s p=0.005 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.31s (± 0.46%) 25.18s (± 0.84%) +1.88s (+ 8.06%) 24.91s 25.48s p=0.005 n=6
xstate - node (v14.15.1, x64)
Memory used 539,288k (± 0.00%) 661,705k (± 0.00%) +122,417k (+22.70%) 661,694k 661,740k p=0.005 n=6
Parse Time 4.22s (± 1.38%) 5.10s (± 0.84%) +0.88s (+20.91%) 5.05s 5.16s p=0.005 n=6
Bind Time 1.70s (± 3.05%) 1.83s (± 0.66%) +0.14s (+ 8.16%) 1.82s 1.85s p=0.005 n=6
Check Time 3.16s (± 1.01%) 3.06s (± 0.60%) 🟩-0.10s (- 3.06%) 3.03s 3.08s p=0.005 n=6
Emit Time 0.09s (± 0.00%) 0.03s (±14.39%) 🟩-0.06s (-68.52%) 0.02s 0.03s p=0.002 n=6
Total Time 9.16s (± 0.32%) 10.02s (± 0.51%) +0.86s (+ 9.37%) 9.95s 10.08s p=0.005 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50947 6
Baseline main 6

TSServer

Comparison Report - main..50947
Metric main 50947 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,390ms (± 0.93%) 2,609ms (± 0.91%) +219ms (+ 9.18%) 2,573ms 2,641ms p=0.005 n=6
Req 2 - geterr 5,372ms (± 0.70%) 5,913ms (± 0.43%) +542ms (+10.08%) 5,866ms 5,938ms p=0.005 n=6
Req 3 - references 339ms (± 1.34%) 359ms (± 0.70%) +20ms (+ 5.80%) 356ms 362ms p=0.005 n=6
Req 4 - navto 280ms (± 0.20%) 274ms (± 0.54%) -5ms (- 1.91%) 272ms 276ms p=0.004 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 81ms (± 3.98%) 89ms (± 2.84%) +8ms (+ 9.88%) 87ms 93ms p=0.005 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,526ms (± 0.93%) 2,766ms (± 0.65%) +241ms (+ 9.53%) 2,743ms 2,797ms p=0.005 n=6
Req 2 - geterr 4,000ms (± 0.78%) 4,170ms (± 0.46%) +170ms (+ 4.25%) 4,153ms 4,194ms p=0.005 n=6
Req 3 - references 351ms (± 0.67%) 365ms (± 0.68%) +15ms (+ 4.18%) 362ms 369ms p=0.005 n=6
Req 4 - navto 292ms (± 0.79%) 284ms (± 0.59%) -8ms (- 2.68%) 282ms 286ms p=0.005 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 83ms (± 3.52%) 72ms (± 1.36%) 🟩-11ms (-13.23%) 71ms 74ms p=0.004 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,051ms (± 0.43%) 3,490ms (± 1.06%) +439ms (+14.39%) 3,454ms 3,533ms p=0.005 n=6
Req 2 - geterr 1,596ms (± 0.95%) 1,292ms (± 0.50%) 🟩-304ms (-19.02%) 1,285ms 1,303ms p=0.005 n=6
Req 3 - references 109ms (± 0.50%) 113ms (± 1.85%) +5ms (+ 4.15%) 111ms 117ms p=0.004 n=6
Req 4 - navto 360ms (± 0.52%) 385ms (± 0.42%) +26ms (+ 7.14%) 383ms 387ms p=0.005 n=6
Req 5 - completionInfo count 3,177 (± 0.00%) 3,149 (± 0.00%) -28 (- 0.88%) 3,149 3,149 p=0.001 n=6
Req 5 - completionInfo 426ms (± 1.43%) 444ms (± 3.04%) +18ms (+ 4.15%) 424ms 461ms p=0.045 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,518ms (± 0.49%) 2,827ms (± 0.30%) +309ms (+12.28%) 2,811ms 2,834ms p=0.005 n=6
Req 2 - geterr 5,740ms (± 0.53%) 6,255ms (± 2.29%) +515ms (+ 8.98%) 5,976ms 6,362ms p=0.005 n=6
Req 3 - references 346ms (± 0.50%) 365ms (± 1.51%) +19ms (+ 5.40%) 359ms 374ms p=0.005 n=6
Req 4 - navto 278ms (± 0.49%) 274ms (± 0.40%) -4ms (- 1.56%) 273ms 276ms p=0.004 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 74ms (± 1.48%) 82ms (± 4.42%) +8ms (+10.36%) 76ms 86ms p=0.006 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,677ms (± 0.31%) 2,931ms (± 0.59%) +254ms (+ 9.48%) 2,905ms 2,950ms p=0.005 n=6
Req 2 - geterr 4,348ms (± 0.59%) 4,539ms (± 0.35%) +190ms (+ 4.37%) 4,519ms 4,560ms p=0.005 n=6
Req 3 - references 362ms (± 1.20%) 385ms (± 2.32%) +23ms (+ 6.31%) 377ms 402ms p=0.005 n=6
Req 4 - navto 290ms (± 0.36%) 277ms (± 1.31%) 🟩-13ms (- 4.49%) 272ms 281ms p=0.005 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 77ms (± 3.06%) 77ms (± 0.98%) ~ 76ms 78ms p=0.366 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,198ms (± 0.33%) 3,609ms (± 0.39%) +411ms (+12.84%) 3,594ms 3,631ms p=0.005 n=6
Req 2 - geterr 1,750ms (± 0.49%) 1,414ms (± 1.00%) 🟩-336ms (-19.20%) 1,397ms 1,433ms p=0.005 n=6
Req 3 - references 119ms (± 0.92%) 118ms (± 1.07%) ~ 117ms 120ms p=0.155 n=6
Req 4 - navto 344ms (± 0.37%) 361ms (± 0.76%) +17ms (+ 5.04%) 359ms 366ms p=0.004 n=6
Req 5 - completionInfo count 3,177 (± 0.00%) 3,149 (± 0.00%) -28 (- 0.88%) 3,149 3,149 p=0.001 n=6
Req 5 - completionInfo 439ms (± 4.31%) 496ms (± 0.95%) +57ms (+12.96%) 490ms 503ms p=0.005 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,608ms (± 0.74%) 2,926ms (± 0.71%) +319ms (+12.22%) 2,904ms 2,960ms p=0.005 n=6
Req 2 - geterr 6,144ms (± 0.61%) 6,227ms (± 0.35%) +84ms (+ 1.36%) 6,204ms 6,255ms p=0.005 n=6
Req 3 - references 364ms (± 1.27%) 383ms (± 1.09%) +19ms (+ 5.17%) 378ms 389ms p=0.005 n=6
Req 4 - navto 280ms (± 1.57%) 280ms (± 0.27%) ~ 279ms 281ms p=1.000 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 99ms (± 4.45%) 82ms (± 0.00%) 🟩-17ms (-17.03%) 82ms 82ms p=0.003 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,824ms (± 0.48%) 3,055ms (± 0.24%) +231ms (+ 8.18%) 3,042ms 3,061ms p=0.005 n=6
Req 2 - geterr 4,452ms (± 0.44%) 4,442ms (± 0.57%) ~ 4,402ms 4,474ms p=0.575 n=6
Req 3 - references 428ms (± 0.93%) 395ms (± 0.71%) 🟩-33ms (- 7.67%) 392ms 399ms p=0.005 n=6
Req 4 - navto 288ms (± 0.68%) 296ms (± 1.64%) +8ms (+ 2.78%) 286ms 299ms p=0.036 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 96ms (± 2.51%) 79ms (± 0.52%) 🟩-18ms (-18.17%) 78ms 79ms p=0.003 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,499ms (± 0.30%) 3,874ms (± 0.86%) +375ms (+10.72%) 3,845ms 3,939ms p=0.005 n=6
Req 2 - geterr 1,846ms (± 0.82%) 1,465ms (± 0.67%) 🟩-381ms (-20.62%) 1,446ms 1,472ms p=0.005 n=6
Req 3 - references 125ms (± 1.57%) 128ms (± 0.66%) ~ 126ms 128ms p=0.070 n=6
Req 4 - navto 368ms (± 0.61%) 397ms (± 0.69%) +29ms (+ 7.84%) 392ms 399ms p=0.005 n=6
Req 5 - completionInfo count 3,177 (± 0.00%) 3,149 (± 0.00%) -28 (- 0.88%) 3,149 3,149 p=0.001 n=6
Req 5 - completionInfo 447ms (± 1.30%) 499ms (± 0.38%) +52ms (+11.67%) 497ms 501ms p=0.005 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50947 6
Baseline main 6

Startup

Comparison Report - main..50947
Metric main 50947 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 141.11ms (± 0.20%) 138.28ms (± 0.18%) -2.84ms (- 2.01%) 137.63ms 141.20ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 225.72ms (± 0.13%) 222.40ms (± 0.18%) -3.32ms (- 1.47%) 221.34ms 228.22ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 227.77ms (± 0.13%) 218.16ms (± 0.23%) 🟩-9.61ms (- 4.22%) 216.86ms 224.06ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 208.66ms (± 0.16%) 202.39ms (± 0.18%) 🟩-6.27ms (- 3.01%) 201.48ms 207.42ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 50947 6
Baseline main 6
Developer Information:

Download Benchmark

typescript-bot avatar Mar 10 '23 04:03 typescript-bot

@typescript-bot test top100 @typescript-bot user test this @typescript-bot run dt @typescript-bot perf test this

sandersn avatar Dec 05 '23 16:12 sandersn

Heya @sandersn, I've started to run the regular perf test suite on this PR at 7904d743ca085e28b1988d303853f9715edc7fe9. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Dec 05 '23 16:12 typescript-bot

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 7904d743ca085e28b1988d303853f9715edc7fe9. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Dec 05 '23 16:12 typescript-bot

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 7904d743ca085e28b1988d303853f9715edc7fe9. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Dec 05 '23 16:12 typescript-bot

Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at 7904d743ca085e28b1988d303853f9715edc7fe9. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Dec 05 '23 16:12 typescript-bot

@sandersn Here are the results of running the user test suite comparing main and refs/pull/50947/merge:

There were infrastructure failures potentially unrelated to your change:

  • 2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

pyright

/mnt/ts_downloads/pyright/build.sh

  • [NEW] error TS2558: Expected 2 type arguments, but got 1.
    • /mnt/ts_downloads/pyright/pyright: ../pyright-internal/src/backgroundAnalysisBase.ts(681,28)
    • /mnt/ts_downloads/pyright/pyright-internal: src/backgroundAnalysisBase.ts(681,28)
    • /mnt/ts_downloads/pyright/vscode-pyright: ../pyright-internal/src/backgroundAnalysisBase.ts(681,28)

typescript-bot avatar Dec 05 '23 16:12 typescript-bot

@sandersn The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 295,374k (± 0.01%) 298,018k (± 0.01%) +2,643k (+ 0.89%) 297,993k 298,034k p=0.005 n=6
Parse Time 2.65s (± 0.19%) 2.65s (± 0.39%) ~ 2.64s 2.67s p=0.242 n=6
Bind Time 0.82s (± 0.50%) 0.82s (± 0.50%) ~ 0.82s 0.83s p=1.000 n=6
Check Time 8.14s (± 0.30%) 8.10s (± 0.34%) -0.04s (- 0.49%) 8.06s 8.14s p=0.029 n=6
Emit Time 7.08s (± 0.15%) 7.06s (± 0.35%) ~ 7.03s 7.09s p=0.188 n=6
Total Time 18.69s (± 0.17%) 18.64s (± 0.12%) -0.05s (- 0.29%) 18.60s 18.66s p=0.012 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 193,341k (± 1.54%) 195,258k (± 1.56%) ~ 193,238k 199,323k p=0.128 n=6
Parse Time 1.36s (± 0.89%) 1.37s (± 1.26%) ~ 1.35s 1.39s p=0.227 n=6
Bind Time 0.72s (± 0.00%) 0.72s (± 0.00%) ~ 0.72s 0.72s p=1.000 n=6
Check Time 9.27s (± 0.55%) 9.29s (± 0.48%) ~ 9.22s 9.34s p=0.574 n=6
Emit Time 2.62s (± 0.70%) 2.63s (± 0.89%) ~ 2.59s 2.65s p=0.572 n=6
Total Time 13.96s (± 0.43%) 14.00s (± 0.46%) ~ 13.91s 14.10s p=0.254 n=6
Monaco - node (v18.15.0, x64)
Memory used 347,393k (± 0.01%) 347,379k (± 0.00%) ~ 347,354k 347,399k p=0.297 n=6
Parse Time 2.45s (± 0.48%) 2.46s (± 0.34%) ~ 2.44s 2.46s p=0.300 n=6
Bind Time 0.93s (± 0.44%) 0.92s (± 0.44%) -0.01s (- 0.72%) 0.92s 0.93s p=0.034 n=6
Check Time 6.90s (± 0.29%) 6.90s (± 0.18%) ~ 6.89s 6.92s p=0.391 n=6
Emit Time 4.06s (± 0.22%) 4.05s (± 0.61%) ~ 4.02s 4.08s p=0.568 n=6
Total Time 14.34s (± 0.15%) 14.33s (± 0.29%) ~ 14.29s 14.39s p=0.810 n=6
TFS - node (v18.15.0, x64)
Memory used 302,669k (± 0.00%) 302,667k (± 0.00%) ~ 302,657k 302,680k p=0.630 n=6
Parse Time 1.99s (± 1.19%) 2.00s (± 1.20%) ~ 1.96s 2.02s p=0.681 n=6
Bind Time 1.00s (± 0.52%) 0.99s (± 0.55%) ~ 0.99s 1.00s p=0.640 n=6
Check Time 6.31s (± 0.56%) 6.30s (± 0.47%) ~ 6.26s 6.35s p=0.466 n=6
Emit Time 3.57s (± 0.75%) 3.58s (± 0.23%) ~ 3.56s 3.58s p=0.667 n=6
Total Time 12.87s (± 0.31%) 12.87s (± 0.24%) ~ 12.82s 12.89s p=0.569 n=6
material-ui - node (v18.15.0, x64)
Memory used 506,736k (± 0.00%) 507,875k (± 0.01%) +1,138k (+ 0.22%) 507,834k 507,917k p=0.005 n=6
Parse Time 2.58s (± 0.49%) 2.57s (± 0.20%) ~ 2.57s 2.58s p=0.418 n=6
Bind Time 0.98s (± 0.85%) 0.99s (± 0.82%) ~ 0.99s 1.01s p=0.081 n=6
Check Time 16.90s (± 0.66%) 16.88s (± 0.60%) ~ 16.76s 17.04s p=1.000 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.46s (± 0.50%) 20.45s (± 0.56%) ~ 20.32s 20.64s p=1.000 n=6
xstate - node (v18.15.0, x64)
Memory used 512,723k (± 0.02%) 669,853k (± 0.01%) 🔻+157,131k (+30.65%) 669,780k 669,929k p=0.005 n=6
Parse Time 3.27s (± 0.19%) 3.33s (± 0.35%) +0.06s (+ 1.89%) 3.31s 3.34s p=0.004 n=6
Bind Time 1.54s (± 0.41%) 1.54s (± 0.64%) ~ 1.53s 1.55s p=0.733 n=6
Check Time 2.81s (± 0.58%) 2.86s (± 0.93%) +0.04s (+ 1.48%) 2.83s 2.89s p=0.008 n=6
Emit Time 0.08s (± 0.00%) 0.02s (±22.11%) 🟩-0.06s (-70.83%) 0.02s 0.03s p=0.002 n=6
Total Time 7.70s (± 0.30%) 7.75s (± 0.49%) +0.05s (+ 0.71%) 7.71s 7.80s p=0.031 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,350ms (± 0.66%) 2,367ms (± 0.41%) +17ms (+ 0.74%) 2,354ms 2,380ms p=0.045 n=6
Req 2 - geterr 5,386ms (± 0.86%) 5,457ms (± 1.46%) +71ms (+ 1.32%) 5,409ms 5,617ms p=0.045 n=6
Req 3 - references 324ms (± 1.71%) 323ms (± 0.36%) ~ 322ms 325ms p=0.685 n=6
Req 4 - navto 278ms (± 1.08%) 270ms (± 0.45%) 🟩-9ms (- 3.12%) 267ms 270ms p=0.003 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 84ms (± 5.76%) 91ms (± 0.89%) 🔻+8ms (+ 8.95%) 90ms 92ms p=0.011 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,481ms (± 0.55%) 2,455ms (± 1.17%) ~ 2,413ms 2,481ms p=0.109 n=6
Req 2 - geterr 4,110ms (± 1.85%) 4,252ms (± 0.26%) +142ms (+ 3.46%) 4,236ms 4,263ms p=0.005 n=6
Req 3 - references 343ms (± 1.70%) 332ms (± 0.59%) 🟩-11ms (- 3.06%) 330ms 335ms p=0.010 n=6
Req 4 - navto 287ms (± 0.98%) 286ms (± 1.26%) ~ 282ms 291ms p=0.570 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 85ms (± 7.28%) 77ms (± 1.42%) ~ 75ms 78ms p=0.075 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,607ms (± 0.50%) 2,589ms (± 0.81%) ~ 2,568ms 2,616ms p=0.109 n=6
Req 2 - geterr 1,681ms (± 2.10%) 1,672ms (± 2.24%) ~ 1,640ms 1,738ms p=0.810 n=6
Req 3 - references 108ms (± 7.54%) 116ms (± 9.26%) ~ 102ms 124ms p=0.325 n=6
Req 4 - navto 365ms (± 0.34%) 364ms (± 0.41%) ~ 363ms 367ms p=0.739 n=6
Req 5 - completionInfo count 2,073 (± 0.00%) 2,073 (± 0.00%) ~ 2,073 2,073 p=1.000 n=6
Req 5 - completionInfo 311ms (± 0.61%) 311ms (± 1.72%) ~ 305ms 319ms p=0.629 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 152.73ms (± 0.20%) 152.62ms (± 0.20%) -0.11ms (- 0.07%) 151.47ms 157.57ms p=0.000 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 227.90ms (± 0.18%) 227.69ms (± 0.16%) -0.21ms (- 0.09%) 226.43ms 230.56ms p=0.000 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 229.21ms (± 0.18%) 229.29ms (± 0.21%) ~ 227.60ms 235.73ms p=0.208 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 229.12ms (± 0.17%) 229.14ms (± 0.20%) ~ 227.56ms 235.52ms p=0.908 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6
Developer Information:

Download Benchmarks

typescript-bot avatar Dec 05 '23 16:12 typescript-bot

Hey @sandersn, it looks like the DT test run failed. Please check the log for more details. You can check the log here.

typescript-bot avatar Dec 05 '23 16:12 typescript-bot

@sandersn Here are the results of running the top-repos suite comparing main and refs/pull/50947/merge:

Something interesting changed - please have a look.

Details

ant-design/ant-design

tsconfig.json

immutable-js/immutable-js

1 of 4 projects failed to build with the old tsc and were ignored

website/tsconfig.json

microsoft/vscode

3 of 54 projects failed to build with the old tsc and were ignored

build/tsconfig.build.json

extensions/extension-editing/tsconfig.json

extensions/git/tsconfig.json

src/tsconfig.json

src/tsconfig.monaco.json

src/tsconfig.tsec.json

portainer/portainer

tsconfig.json

quilljs/quill

2 of 3 projects failed to build with the old tsc and were ignored

packages/quill/tsconfig.json

tldraw/tldraw

1 of 5 projects failed to build with the old tsc and were ignored

apps/examples/tsconfig.json

apps/vscode/editor/tsconfig.json

apps/vscode/extension/tsconfig.json

vuetifyjs/vuetify

4 of 7 projects failed to build with the old tsc and were ignored

packages/vuetify/tsconfig.checks.json

packages/vuetify/tsconfig.dist.json

packages/vuetify/tsconfig.json

withfig/autocomplete

tsconfig.json

typescript-bot avatar Dec 05 '23 17:12 typescript-bot

xstate uses 30% more memory than before, which is consistent with my concerns.

Also, user tests show failures in calls to functions that have some type arguments already, meaning that the new type parameters need defaults to avoid this.

However, I don't think it's worthwhile to make that change given the slowdown in xstate.

sandersn avatar Dec 05 '23 21:12 sandersn