TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Fix(47969): String.prototypr.replace docs fix

Open navya9singh opened this issue 3 years ago • 5 comments
trafficstars

Fixes https://github.com/microsoft/TypeScript/issues/47969

navya9singh avatar Jul 25 '22 20:07 navya9singh

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

typescript-bot avatar Jul 25 '22 20:07 typescript-bot

@sandersn Shouldn't this be Author: Team?

amcasey avatar Jul 25 '22 20:07 amcasey

Shouldn't this be Author: Team?

edit: https://github.com/microsoft/TypeScript/blob/main/.github/pr_owners.txt to update this (comes from here)

orta avatar Jul 27 '22 21:07 orta

Shouldn't this be Author: Team?

edit: https://github.com/microsoft/TypeScript/blob/main/.github/pr_owners.txt to update this (comes from here)

Done. Thanks, @orta!

amcasey avatar Jul 27 '22 22:07 amcasey

Looks pretty good but I'd like to address @Josh-Cena 's point about the sticky flag before merging.

sandersn avatar Jul 27 '22 23:07 sandersn

@sandersn I can hardly understand that how come the documentation of only 2 out of 4 overloads are updated. And replaceAll is not touched at all. Anyway I have updated them in my PR (#50452).

graphemecluster avatar Oct 11 '22 13:10 graphemecluster